remove lazy-conditions.

a963e2dc · Ben Houston · a1ac92db · a963e2dc · a963e2dc · a963e2dc
隐藏空白更改
内联并排

Showing with 6 addition and 6 deletion

src/math/Vector2.js src/math/Vector2.js +2 -2

src/math/Vector3.js src/math/Vector3.js +2 -2

src/math/Vector4.js src/math/Vector4.js +2 -2

未找到文件。
--- a/src/math/Vector2.js
+++ b/src/math/Vector2.js
@@ -118,7 +118,7 @@ THREE.Vector2.prototype = {

 	divideScalar: function ( s ) {

-		if ( s ) {
+		if ( s !== 0 ) {

 			this.x /= s;
 			this.y /= s;
@@ -244,7 +244,7 @@ THREE.Vector2.prototype = {

 		var oldLength = this.length();
 		
-		if( oldLength ) {
+		if ( oldLength !== 0 && l !== oldLength  ) {

 			this.multiplyScalar( l / oldLength );
 		}

--- a/src/math/Vector3.js
+++ b/src/math/Vector3.js
@@ -168,7 +168,7 @@ THREE.Vector3.prototype = {

 	divideScalar: function ( s ) {

-		if ( s ) {
+		if ( s !== 0 ) {

 			this.x /= s;
 			this.y /= s;
@@ -312,7 +312,7 @@ THREE.Vector3.prototype = {

 		var oldLength = this.length();
 		
-		if( oldLength ) {
+		if ( oldLength !== 0 && l !== oldLength  ) {

 			this.multiplyScalar( l / oldLength );
 		}

--- a/src/math/Vector4.js
+++ b/src/math/Vector4.js
@@ -153,7 +153,7 @@ THREE.Vector4.prototype = {

 	divideScalar: function ( s ) {

-		if ( s ) {
+		if ( s !== 0 ) {

 			this.x /= s;
 			this.y /= s;
@@ -321,7 +321,7 @@ THREE.Vector4.prototype = {

 		var oldLength = this.length();
 		
-		if( oldLength ) {
+		if ( oldLength !== 0 && l !== oldLength  ) {

 			this.multiplyScalar( l / oldLength );
 		}