1. 29 8月, 2013 1 次提交
    • A
      Fixed critical memory leak from EVAL. · 41d31473
      antirez 提交于
      Multiple missing calls to lua_pop prevented the error handler function
      pushed on the stack for lua_pcall() to be popped before returning,
      causing a memory leak in almost all the code paths of EVAL (both
      successful calls and calls returning errors).
      
      This caused two issues: Lua leaking memory (and this was very visible
      from INFO memory output, as the 'used_memory_lua' field reported an
      always increasing amount of memory used), and as a result slower and
      slower GC cycles resulting in all the CPU being used.
      
      Thanks to Tanguy Le Barzic for noticing something was wrong with his 2.8
      slave, and for creating a testing EC2 environment where I was able to
      investigate the issue.
      41d31473
  2. 27 8月, 2013 9 次提交
  3. 26 8月, 2013 1 次提交
    • A
      Don't update node pong time via gossip. · 303dde37
      antirez 提交于
      This feature was implemented in the initial days of the Redis Cluster
      implementaiton but is not a good idea at all.
      
      1) It depends on clocks to be synchronized, that is already very bad.
      2) Moreover it adds a bug where the pong time is updated via gossip so
      no new PING is ever sent by the current node, with the effect of no PONG
      received, no update of tables, no clearing of PFAIL flag.
      
      In general to trust other nodes about the reachability of other nodes is
      a broken distributed programming model.
      303dde37
  4. 22 8月, 2013 6 次提交
  5. 21 8月, 2013 3 次提交
  6. 20 8月, 2013 2 次提交
  7. 19 8月, 2013 8 次提交
    • A
      Revert "Fixed type in dict.c comment: 265 -> 256." · 00ddc350
      antirez 提交于
      This reverts commit 6253180a.
      00ddc350
    • A
      Fixed type in dict.c comment: 265 -> 256. · 6253180a
      antirez 提交于
      6253180a
    • A
      assert.h replaced with redisassert.h when appropriate. · 1c754084
      antirez 提交于
      Also a warning was suppressed by including unistd.h in redisassert.h
      (needed for _exit()).
      1c754084
    • A
      Added redisassert.h as drop in replacement for assert.h. · ca294c6b
      antirez 提交于
      By using redisassert.h version of assert() you get stack traces in the
      log instead of a process disappearing on assertions.
      ca294c6b
    • A
      dictFingerprint() fingerprinting made more robust. · 905d4822
      antirez 提交于
      The previous hashing used the trivial algorithm of xoring the integers
      together. This is not optimal as it is very likely that different
      hash table setups will hash the same, for instance an hash table at the
      start of the rehashing process, and at the end, will have the same
      fingerprint.
      
      Now we hash N integers in a smarter way, by summing every integer to the
      previous hash, and taking the integer hashing again (see the code for
      further details). This way it is a lot less likely that we get a
      collision. Moreover this way of hashing explicitly protects from the
      same set of integers in a different order to hash to the same number.
      
      This commit is related to issue #1240.
      905d4822
    • A
      Fix comments for correctness in zunionInterGenericCommand(). · 3039e806
      antirez 提交于
      Related to issue #1240.
      3039e806
    • A
      Properly init/release iterators in zunionInterGenericCommand(). · cfb9d025
      antirez 提交于
      This commit does mainly two things:
      
      1) It fixes zunionInterGenericCommand() by removing mass-initialization
      of all the iterators used, so that we don't violate the unsafe iterator
      API of dictionaries. This fixes issue #1240.
      
      2) Since the zui* APIs required the allocator to be initialized in the
      zsetopsrc structure in order to use non-iterator related APIs, this
      commit fixes this strict requirement by accessing objects directly via
      the op->subject->ptr pointer we have to the object.
      cfb9d025
    • A
      dict.c iterator API misuse protection. · 48cde3fe
      antirez 提交于
      dict.c allows the user to create unsafe iterators, that are iterators
      that will not touch the dictionary data structure in any way, preventing
      copy on write, but at the same time are limited in their usage.
      
      The limitation is that when itearting with an unsafe iterator, no call
      to other dictionary functions must be done inside the iteration loop,
      otherwise the dictionary may be incrementally rehashed resulting into
      missing elements in the set of the elements returned by the iterator.
      
      However after introducing this kind of iterators a number of bugs were
      found due to misuses of the API, and we are still finding
      bugs about this issue. The bugs are not trivial to track because the
      effect is just missing elements during the iteartion.
      
      This commit introduces auto-detection of the API misuse. The idea is
      that an unsafe iterator has a contract: from initialization to the
      release of the iterator the dictionary should not change.
      
      So we take a fingerprint of the dictionary state, xoring a few important
      dict properties when the unsafe iteartor is initialized. We later check
      when the iterator is released if the fingerprint is still the same. If it
      is not, we found a misuse of the iterator, as not allowed API calls
      changed the internal state of the dictionary.
      
      This code was checked against a real bug, issue #1240.
      
      This is what Redis prints (aborting) when a misuse is detected:
      
      Assertion failed: (iter->fingerprint == dictFingerprint(iter->d)),
      function dictReleaseIterator, file dict.c, line 587.
      48cde3fe
  8. 12 8月, 2013 6 次提交
  9. 08 8月, 2013 2 次提交
    • A
      redis-benchmark: changes to random arguments substitution. · db862e8e
      antirez 提交于
      Before this commit redis-benchmark supported random argumetns in the
      form of :rand:000000000000. In every string of that form, the zeros were
      replaced with a random number of 12 digits at every command invocation.
      
      However this was far from perfect as did not allowed to generate simply
      random numbers as arguments, there was always the :rand: prefix.
      
      Now instead every argument in the form __rand_int__ is replaced with a
      12 digits number. Note that "__rand_int__" is 12 characters itself.
      
      In order to implement the new semantic, it was needed to change a few
      thigns in the internals of redis-benchmark, as new clients are created
      cloning old clients, so without a stable prefix such as ":rand:" the old
      way of cloning the client was no longer able to understand, from the old
      command line, what was the position of the random strings to substitute.
      
      Now instead a client structure is passed as a reference for cloning, so
      that we can directly clone the offsets inside the command line.
      db862e8e
    • A
      redis-benchmark: replace snprintf()+memcpy with faster code. · 92ab77f8
      antirez 提交于
      This change was profiler-driven, but the actual effect is hard to
      measure in real-world redis benchmark runs.
      92ab77f8
  10. 07 8月, 2013 2 次提交