提交 37f5ac48 编写于 作者: K Kamran Ahmed

Handle non-existing elements

上级 5829a936
...@@ -11,6 +11,7 @@ export default class Overlay { ...@@ -11,6 +11,7 @@ export default class Overlay {
this.lastSelectedPosition = new Position({}); this.lastSelectedPosition = new Position({});
this.window = window; this.window = window;
this.document = document;
this.prepareContext(); this.prepareContext();
this.setSize(); this.setSize();
...@@ -18,7 +19,7 @@ export default class Overlay { ...@@ -18,7 +19,7 @@ export default class Overlay {
// Prepares the overlay // Prepares the overlay
prepareContext() { prepareContext() {
const overlay = document.createElement('canvas'); const overlay = this.document.createElement('canvas');
this.overlay = overlay; this.overlay = overlay;
this.context = overlay.getContext('2d'); this.context = overlay.getContext('2d');
...@@ -34,7 +35,6 @@ export default class Overlay { ...@@ -34,7 +35,6 @@ export default class Overlay {
// Highlights the dom element on the screen // Highlights the dom element on the screen
highlight(element) { highlight(element) {
if (!element) { if (!element) {
// @todo - clearing the overlay
return; return;
} }
...@@ -48,6 +48,10 @@ export default class Overlay { ...@@ -48,6 +48,10 @@ export default class Overlay {
this.draw(); this.draw();
} }
clear() {
this.document.body.removeChild(this.overlay);
}
draw() { draw() {
// Reset the overlay // Reset the overlay
this.context.clearRect(0, 0, this.overlay.width, this.overlay.height); this.context.clearRect(0, 0, this.overlay.width, this.overlay.height);
...@@ -56,15 +60,15 @@ export default class Overlay { ...@@ -56,15 +60,15 @@ export default class Overlay {
// Cut out the cleared region // Cut out the cleared region
this.context.clearRect( this.context.clearRect(
this.selectedPosition.left - window.scrollX, this.selectedPosition.left - this.window.scrollX,
this.selectedPosition.top - window.scrollY, this.selectedPosition.top - this.window.scrollY,
(this.selectedPosition.right - this.selectedPosition.left), (this.selectedPosition.right - this.selectedPosition.left),
(this.selectedPosition.bottom - this.selectedPosition.top), (this.selectedPosition.bottom - this.selectedPosition.top),
); );
// Append the overlay if not there already // Append the overlay if not there already
if (!this.overlay.parentNode) { if (!this.overlay.parentNode) {
document.body.appendChild(this.overlay); this.document.body.appendChild(this.overlay);
} }
} }
......
...@@ -21,7 +21,11 @@ export default class Sholo { ...@@ -21,7 +21,11 @@ export default class Sholo {
throw new Error('Element can only be string or the dom element'); throw new Error('Element can only be string or the dom element');
} }
const element = new Element(domElement); if (domElement) {
this.overlay.highlight(element); const element = new Element(domElement);
this.overlay.highlight(element);
} else {
this.overlay.clear();
}
} }
} }
...@@ -46,6 +46,7 @@ ...@@ -46,6 +46,7 @@
<script> <script>
const nodesToSelect = [ const nodesToSelect = [
'.section__header', '.section__header',
'asdfsfd',
'.section__how', '.section__how',
'.section__examples' '.section__examples'
]; ];
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册