Merge pull request #17326 from Mugen87/dev29

BufferGeometryLoader: Inherit from Loader.

Merge pull request #17326 from Mugen87/dev29
BufferGeometryLoader: Inherit from Loader.
257f66c9 · Michael Herzog · GitHub · ba9ec37a · 2ea1004c · 257f66c9
5 changed file
--- a/docs/api/en/loaders/BufferGeometryLoader.html
+++ b/docs/api/en/loaders/BufferGeometryLoader.html
@@ -8,6 +8,8 @@
 		<link type="text/css" rel="stylesheet" href="page.css" />
 	</head>
 	<body>
+		[page:Loader] &rarr;
+
 		<h1>[name]</h1>

 		<p class="desc">
@@ -57,15 +59,11 @@
 		Creates a new [name].
 		</p>

-
 		<h2>Properties</h2>
-
-		<h3>[property:LoadingManager manager]</h3>
-		<p>
-			The [page:LoadingManager loadingManager] the loader is using. Default is [page:DefaultLoadingManager].
-		</p>
+		<p>See the base [page:Loader] class for common properties.</p>

 		<h2>Methods</h2>
+		<p>See the base [page:Loader] class for common methods.</p>

 		<h3>[method:null load]( [param:String url], [param:Function onLoad], [param:Function onProgress], [param:Function onError] )</h3>
 		<p>
@@ -85,14 +83,6 @@
 		Parse a <em>JSON</em> structure and return a [page:BufferGeometry].
 		</p>

-		<h3>[method:BufferGeometryLoader setPath]( [param:String path] )</h3>
-		<p>
-			[page:String path] — Base path of the file to load.<br /><br />
-
-			Sets the base path or URL from which to load files. This can be useful if
-			you are loading many geometries from the same directory.
-		</p>
-
 		<h2>Source</h2>

 		[link:https://github.com/mrdoob/three.js/blob/master/src/[path].js src/[path].js]

--- a/docs/api/zh/loaders/BufferGeometryLoader.html
+++ b/docs/api/zh/loaders/BufferGeometryLoader.html
@@ -8,6 +8,8 @@
 		<link type="text/css" rel="stylesheet" href="page.css" />
 	</head>
 	<body>
+		[page:Loader] &rarr;
+
 		<h1>[name]</h1>

 		<p class="desc">
@@ -57,15 +59,11 @@
 		创建一个新的[name].
 		</p>

-
 		<h2>属性</h2>
-
-		<h3>[property:LoadingManager manager]</h3>
-		<p>
-            正在使用的[page:LoadingManager loadingManager]。默认为[page:DefaultLoadingManager].
-		</p>
+		<p>See the base [page:Loader] class for common properties.</p>

 		<h2>方法</h2>
+		<p>See the base [page:Loader] class for common methods.</p>

 		<h3>[method:null load]( [param:String url], [param:Function onLoad], [param:Function onProgress], [param:Function onError] )</h3>
 		<p>

--- a/src/loaders/AnimationLoader.js
+++ b/src/loaders/AnimationLoader.js
@@ -14,6 +14,8 @@ function AnimationLoader( manager ) {

 AnimationLoader.prototype = Object.assign( Object.create( Loader.prototype ), {

+	constructor: AnimationLoader,
+
 	load: function ( url, onLoad, onProgress, onError ) {

 		var scope = this;

--- a/src/loaders/BufferGeometryLoader.d.ts
+++ b/src/loaders/BufferGeometryLoader.d.ts
+import { Loader } from './Loader';
 import { LoadingManager } from './LoadingManager';
 import { BufferGeometry } from './../core/BufferGeometry';

-export class BufferGeometryLoader {
+export class BufferGeometryLoader extends Loader {

 	constructor( manager?: LoadingManager );

-	manager: LoadingManager;
-
 	load(
 		url: string,
 		onLoad: ( bufferGeometry: BufferGeometry ) => void,

--- a/src/loaders/BufferGeometryLoader.js
+++ b/src/loaders/BufferGeometryLoader.js
@@ -3,7 +3,7 @@ import { Vector3 } from '../math/Vector3.js';
 import { BufferAttribute } from '../core/BufferAttribute.js';
 import { BufferGeometry } from '../core/BufferGeometry.js';
 import { FileLoader } from './FileLoader.js';
-import { DefaultLoadingManager } from './LoadingManager.js';
+import { Loader } from './Loader.js';
 import { InstancedBufferGeometry } from '../core/InstancedBufferGeometry.js';
 import { InstancedBufferAttribute } from '../core/InstancedBufferAttribute.js';

@@ -13,11 +13,13 @@ import { InstancedBufferAttribute } from '../core/InstancedBufferAttribute.js';

 function BufferGeometryLoader( manager ) {

-	this.manager = ( manager !== undefined ) ? manager : DefaultLoadingManager;
+	Loader.call( this, manager );

 }

-Object.assign( BufferGeometryLoader.prototype, {
+BufferGeometryLoader.prototype = Object.assign( Object.create( Loader.prototype ), {
+
+	constructor: BufferGeometryLoader,

 	load: function ( url, onLoad, onProgress, onError ) {

@@ -121,13 +123,6 @@ Object.assign( BufferGeometryLoader.prototype, {

 		return geometry;

-	},
-
-	setPath: function ( value ) {
-
-		this.path = value;
-		return this;
-
 	}

 } );