Rename error flag parameter in Matrix3.getInverse()

The previous flag is incorrectly named. The flag is supposed to signify a degenerate matrix. Fixes issue #7612.

Rename error flag parameter in Matrix3.getInverse()
The previous flag is incorrectly named. The flag is supposed to signify a degenerate matrix. Fixes issue #7612.
1621f57f · Brent Walther · 8811349d · 1621f57f · 1621f57f
隐藏空白更改
内联并排

Showing with 6 addition and 6 deletion

docs/api/math/Matrix3.html docs/api/math/Matrix3.html +4 -4

src/math/Matrix3.js src/math/Matrix3.js +2 -2

未找到文件。
--- a/docs/api/math/Matrix3.html
+++ b/docs/api/math/Matrix3.html
 <!DOCTYPE html>
 <html lang="en">
 	<head>
-		<meta charset="utf-8" />
+		<meta charset="utf-8" />
 		<base href="../../" />
 		<script src="list.js"></script>
 		<script src="page.js"></script>
@@ -92,10 +92,10 @@
 		Sets this matrix as the normal matrix (upper left 3x3)of the passed [page:Matrix4 matrix4]. The normal matrix is the inverse transpose of the matrix *m*.
 		</div>

-		<h3>[method:Matrix3 getInverse]([page:Matrix4 m], [page:Boolean throwOnInvertible]) [page:Matrix3 this]</h3>
+		<h3>[method:Matrix3 getInverse]([page:Matrix4 m], [page:Boolean throwOnDegenerate]) [page:Matrix3 this]</h3>
 		<div>
 		m -- [page:Matrix4]<br />
-		throwOnInvertible -- [Page:Boolean] If true, throw an error if the matrix is invertible.
+		throwOnDegenerate -- [Page:Boolean] If true, throw an error if the matrix is degenerate (not invertible).
 		</div>
 		<div>
 		Set this matrix to the inverse of the passed matrix.
@@ -117,7 +117,7 @@
 		<h3>[method:Matrix3 identity]() [page:Matrix3 this]</h3>
 		<div>
 		Resets this matrix to identity.<br/><br/>
-		
+
 		1, 0, 0<br/>
 		0, 1, 0<br/>
 		0, 0, 1<br/>

--- a/src/math/Matrix3.js
+++ b/src/math/Matrix3.js
@@ -150,7 +150,7 @@ THREE.Matrix3.prototype = {

 	},

-	getInverse: function ( matrix, throwOnInvertible ) {
+	getInverse: function ( matrix, throwOnDegenerate ) {

 		// input: THREE.Matrix4
 		// ( based on http://code.google.com/p/webgl-mjs/ )
@@ -176,7 +176,7 @@ THREE.Matrix3.prototype = {

 			var msg = "THREE.Matrix3.getInverse(): can't invert matrix, determinant is 0";

-			if ( throwOnInvertible || false ) {
+			if ( throwOnDegenerate || false ) {

 				throw new Error( msg );