Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
killuaz丶x
SkyWalking
提交
35d7a520
S
SkyWalking
项目概览
killuaz丶x
/
SkyWalking
与 Fork 源项目一致
Fork自
apache / SkyWalking
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
S
SkyWalking
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
35d7a520
编写于
3月 25, 2021
作者:
C
CharliePu
提交者:
GitHub
3月 25, 2021
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
A unit test can be better. (#6620)
上级
a396888d
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
29 addition
and
42 deletion
+29
-42
apm-sniffer/apm-sdk-plugin/lettuce-5.x-plugin/src/test/java/org/apache/skywalking/apm/plugin/lettuce/v5/RedisChannelWriterInterceptorTest.java
.../plugin/lettuce/v5/RedisChannelWriterInterceptorTest.java
+5
-3
apm-sniffer/apm-sdk-plugin/lettuce-5.x-plugin/src/test/java/org/apache/skywalking/apm/plugin/lettuce/v5/mock/MockClientOptions.java
...walking/apm/plugin/lettuce/v5/mock/MockClientOptions.java
+19
-13
apm-sniffer/apm-sdk-plugin/lettuce-5.x-plugin/src/test/java/org/apache/skywalking/apm/plugin/lettuce/v5/mock/MockRedisClusterClient.java
...ng/apm/plugin/lettuce/v5/mock/MockRedisClusterClient.java
+5
-26
未找到文件。
apm-sniffer/apm-sdk-plugin/lettuce-5.x-plugin/src/test/java/org/apache/skywalking/apm/plugin/lettuce/v5/RedisChannelWriterInterceptorTest.java
浏览文件 @
35d7a520
...
@@ -33,8 +33,8 @@ import org.apache.skywalking.apm.agent.test.tools.AgentServiceRule;
...
@@ -33,8 +33,8 @@ import org.apache.skywalking.apm.agent.test.tools.AgentServiceRule;
import
org.apache.skywalking.apm.agent.test.tools.SegmentStorage
;
import
org.apache.skywalking.apm.agent.test.tools.SegmentStorage
;
import
org.apache.skywalking.apm.agent.test.tools.SegmentStoragePoint
;
import
org.apache.skywalking.apm.agent.test.tools.SegmentStoragePoint
;
import
org.apache.skywalking.apm.agent.test.tools.TracingSegmentRunner
;
import
org.apache.skywalking.apm.agent.test.tools.TracingSegmentRunner
;
import
org.apache.skywalking.apm.plugin.lettuce.v5.mock.MockClientOptions
;
import
org.apache.skywalking.apm.plugin.lettuce.v5.mock.MockRedisClusterClient
;
import
org.apache.skywalking.apm.plugin.lettuce.v5.mock.MockRedisClusterClient
;
import
org.apache.skywalking.apm.plugin.lettuce.v5.mock.MockRedisClusterClientConstructorInterceptor
;
import
org.hamcrest.CoreMatchers
;
import
org.hamcrest.CoreMatchers
;
import
org.hamcrest.MatcherAssert
;
import
org.hamcrest.MatcherAssert
;
import
org.hamcrest.core.Is
;
import
org.hamcrest.core.Is
;
...
@@ -120,11 +120,13 @@ public class RedisChannelWriterInterceptorTest {
...
@@ -120,11 +120,13 @@ public class RedisChannelWriterInterceptorTest {
redisURIs
.
add
(
RedisURI
.
create
(
"localhost"
,
i
));
redisURIs
.
add
(
RedisURI
.
create
(
"localhost"
,
i
));
}
}
MockRedisClusterClient
mockRedisClusterClient
=
new
MockRedisClusterClient
();
MockRedisClusterClient
mockRedisClusterClient
=
new
MockRedisClusterClient
();
MockRedisClusterClientConstructorInterceptor
constructorInterceptor
=
new
MockRedisClusterClientConstructorInterceptor
();
MockClientOptions
options
=
new
MockClientOptions
();
mockRedisClusterClient
.
setOptions
(
options
);
RedisClusterClientConstructorInterceptor
constructorInterceptor
=
new
RedisClusterClientConstructorInterceptor
();
constructorInterceptor
.
onConstruct
(
mockRedisClusterClient
,
new
Object
[]
{
constructorInterceptor
.
onConstruct
(
mockRedisClusterClient
,
new
Object
[]
{
null
,
null
,
redisURIs
redisURIs
});
});
assertThat
(
mockRedisClusterClient
.
getOptions
()
.
getSkyWalkingDynamicField
().
toString
().
length
(),
Is
.
is
(
200
));
assertThat
(
options
.
getSkyWalkingDynamicField
().
toString
().
length
(),
Is
.
is
(
200
));
}
}
}
}
apm-sniffer/apm-sdk-plugin/lettuce-5.x-plugin/src/test/java/org/apache/skywalking/apm/plugin/lettuce/v5/mock/Mock
RedisClusterClientConstructorInterceptor
.java
→
apm-sniffer/apm-sdk-plugin/lettuce-5.x-plugin/src/test/java/org/apache/skywalking/apm/plugin/lettuce/v5/mock/Mock
ClientOptions
.java
浏览文件 @
35d7a520
...
@@ -18,22 +18,28 @@
...
@@ -18,22 +18,28 @@
package
org.apache.skywalking.apm.plugin.lettuce.v5.mock
;
package
org.apache.skywalking.apm.plugin.lettuce.v5.mock
;
import
io.lettuce.core.
RedisURI
;
import
io.lettuce.core.
cluster.ClusterClientOptions
;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance
;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance
;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor
;
import
org.apache.skywalking.apm.agent.core.context.util.PeerFormat
;
public
class
MockRedisClusterClientConstructorInterceptor
implements
InstanceConstructorInterceptor
{
public
class
MockClientOptions
extends
ClusterClientOptions
implements
EnhancedInstance
{
private
Object
object
;
public
MockClientOptions
()
{
this
(
ClusterClientOptions
.
builder
());
}
protected
MockClientOptions
(
Builder
builder
)
{
super
(
builder
);
}
@Override
public
Object
getSkyWalkingDynamicField
()
{
return
object
;
}
@Override
@Override
public
void
onConstruct
(
EnhancedInstance
objInst
,
Object
[]
allArguments
)
{
public
void
setSkyWalkingDynamicField
(
Object
value
)
{
@SuppressWarnings
(
"unchecked"
)
Iterable
<
RedisURI
>
redisURIs
=
(
Iterable
<
RedisURI
>)
allArguments
[
1
];
this
.
object
=
value
;
MockRedisClusterClient
redisClusterClient
=
(
MockRedisClusterClient
)
objInst
;
StringBuilder
peer
=
new
StringBuilder
();
for
(
RedisURI
redisURI
:
redisURIs
)
{
peer
.
append
(
redisURI
.
getHost
()).
append
(
":"
).
append
(
redisURI
.
getPort
()).
append
(
";"
);
}
EnhancedInstance
optionsInst
=
redisClusterClient
.
getOptions
();
optionsInst
.
setSkyWalkingDynamicField
(
PeerFormat
.
shorten
(
peer
.
toString
()));
}
}
}
}
apm-sniffer/apm-sdk-plugin/lettuce-5.x-plugin/src/test/java/org/apache/skywalking/apm/plugin/lettuce/v5/mock/MockRedisClusterClient.java
浏览文件 @
35d7a520
...
@@ -18,41 +18,20 @@
...
@@ -18,41 +18,20 @@
package
org.apache.skywalking.apm.plugin.lettuce.v5.mock
;
package
org.apache.skywalking.apm.plugin.lettuce.v5.mock
;
import
io.lettuce.core.cluster.RedisClusterClient
;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance
;
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance
;
public
class
MockRedisClusterClient
implements
EnhancedInstance
{
public
class
MockRedisClusterClient
extends
RedisClusterClient
implements
EnhancedInstance
{
private
Object
ms
;
private
Object
object
;
private
EnhancedInstance
options
=
new
EnhancedInstance
()
{
private
Object
os
;
@Override
public
Object
getSkyWalkingDynamicField
()
{
return
os
;
}
@Override
public
void
setSkyWalkingDynamicField
(
Object
value
)
{
this
.
os
=
value
;
}
};
public
EnhancedInstance
getOptions
()
{
return
options
;
}
public
void
setOptions
(
EnhancedInstance
options
)
{
this
.
options
=
options
;
}
@Override
@Override
public
Object
getSkyWalkingDynamicField
()
{
public
Object
getSkyWalkingDynamicField
()
{
return
ms
;
return
object
;
}
}
@Override
@Override
public
void
setSkyWalkingDynamicField
(
Object
value
)
{
public
void
setSkyWalkingDynamicField
(
Object
value
)
{
this
.
ms
=
value
;
this
.
object
=
value
;
}
}
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录