Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
沉迷打码的小凳子
glide
提交
e7e7620f
G
glide
项目概览
沉迷打码的小凳子
/
glide
与 Fork 源项目一致
从无法访问的项目Fork
通知
3
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
glide
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
e7e7620f
编写于
3月 24, 2015
作者:
S
Sam Judd
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Avoid concurrent modification in lifecycle impl.
Fixes #375.
上级
c3ee8a28
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
30 addition
and
21 deletion
+30
-21
library/src/main/java/com/bumptech/glide/manager/ActivityFragmentLifecycle.java
...com/bumptech/glide/manager/ActivityFragmentLifecycle.java
+5
-3
library/src/main/java/com/bumptech/glide/manager/RequestTracker.java
.../main/java/com/bumptech/glide/manager/RequestTracker.java
+5
-17
library/src/main/java/com/bumptech/glide/util/Util.java
library/src/main/java/com/bumptech/glide/util/Util.java
+20
-1
未找到文件。
library/src/main/java/com/bumptech/glide/manager/ActivityFragmentLifecycle.java
浏览文件 @
e7e7620f
package
com.bumptech.glide.manager
;
package
com.bumptech.glide.manager
;
import
com.bumptech.glide.util.Util
;
import
java.util.Collections
;
import
java.util.Collections
;
import
java.util.Set
;
import
java.util.Set
;
import
java.util.WeakHashMap
;
import
java.util.WeakHashMap
;
...
@@ -44,21 +46,21 @@ class ActivityFragmentLifecycle implements Lifecycle {
...
@@ -44,21 +46,21 @@ class ActivityFragmentLifecycle implements Lifecycle {
void
onStart
()
{
void
onStart
()
{
isStarted
=
true
;
isStarted
=
true
;
for
(
LifecycleListener
lifecycleListener
:
lifecycleListeners
)
{
for
(
LifecycleListener
lifecycleListener
:
Util
.
getSnapshot
(
lifecycleListeners
)
)
{
lifecycleListener
.
onStart
();
lifecycleListener
.
onStart
();
}
}
}
}
void
onStop
()
{
void
onStop
()
{
isStarted
=
false
;
isStarted
=
false
;
for
(
LifecycleListener
lifecycleListener
:
lifecycleListeners
)
{
for
(
LifecycleListener
lifecycleListener
:
Util
.
getSnapshot
(
lifecycleListeners
)
)
{
lifecycleListener
.
onStop
();
lifecycleListener
.
onStop
();
}
}
}
}
void
onDestroy
()
{
void
onDestroy
()
{
isDestroyed
=
true
;
isDestroyed
=
true
;
for
(
LifecycleListener
lifecycleListener
:
lifecycleListeners
)
{
for
(
LifecycleListener
lifecycleListener
:
Util
.
getSnapshot
(
lifecycleListeners
)
)
{
lifecycleListener
.
onDestroy
();
lifecycleListener
.
onDestroy
();
}
}
}
}
...
...
library/src/main/java/com/bumptech/glide/manager/RequestTracker.java
浏览文件 @
e7e7620f
package
com.bumptech.glide.manager
;
package
com.bumptech.glide.manager
;
import
com.bumptech.glide.request.Request
;
import
com.bumptech.glide.request.Request
;
import
com.bumptech.glide.util.Util
;
import
java.util.ArrayList
;
import
java.util.ArrayList
;
import
java.util.Collections
;
import
java.util.Collections
;
...
@@ -64,7 +65,7 @@ public class RequestTracker {
...
@@ -64,7 +65,7 @@ public class RequestTracker {
*/
*/
public
void
pauseRequests
()
{
public
void
pauseRequests
()
{
isPaused
=
true
;
isPaused
=
true
;
for
(
Request
request
:
getSnapshot
(
))
{
for
(
Request
request
:
Util
.
getSnapshot
(
requests
))
{
if
(
request
.
isRunning
())
{
if
(
request
.
isRunning
())
{
request
.
pause
();
request
.
pause
();
pendingRequests
.
add
(
request
);
pendingRequests
.
add
(
request
);
...
@@ -77,7 +78,7 @@ public class RequestTracker {
...
@@ -77,7 +78,7 @@ public class RequestTracker {
*/
*/
public
void
resumeRequests
()
{
public
void
resumeRequests
()
{
isPaused
=
false
;
isPaused
=
false
;
for
(
Request
request
:
getSnapshot
(
))
{
for
(
Request
request
:
Util
.
getSnapshot
(
requests
))
{
if
(!
request
.
isComplete
()
&&
!
request
.
isCancelled
()
&&
!
request
.
isRunning
())
{
if
(!
request
.
isComplete
()
&&
!
request
.
isCancelled
()
&&
!
request
.
isRunning
())
{
request
.
begin
();
request
.
begin
();
}
}
...
@@ -89,7 +90,7 @@ public class RequestTracker {
...
@@ -89,7 +90,7 @@ public class RequestTracker {
* Cancels all requests and clears their resources.
* Cancels all requests and clears their resources.
*/
*/
public
void
clearRequests
()
{
public
void
clearRequests
()
{
for
(
Request
request
:
getSnapshot
(
))
{
for
(
Request
request
:
Util
.
getSnapshot
(
requests
))
{
request
.
clear
();
request
.
clear
();
}
}
pendingRequests
.
clear
();
pendingRequests
.
clear
();
...
@@ -99,7 +100,7 @@ public class RequestTracker {
...
@@ -99,7 +100,7 @@ public class RequestTracker {
* Restarts failed requests and cancels and restarts in progress requests.
* Restarts failed requests and cancels and restarts in progress requests.
*/
*/
public
void
restartRequests
()
{
public
void
restartRequests
()
{
for
(
Request
request
:
getSnapshot
(
))
{
for
(
Request
request
:
Util
.
getSnapshot
(
requests
))
{
if
(!
request
.
isComplete
()
&&
!
request
.
isCancelled
())
{
if
(!
request
.
isComplete
()
&&
!
request
.
isCancelled
())
{
// Ensure the request will be restarted in onResume.
// Ensure the request will be restarted in onResume.
request
.
pause
();
request
.
pause
();
...
@@ -111,17 +112,4 @@ public class RequestTracker {
...
@@ -111,17 +112,4 @@ public class RequestTracker {
}
}
}
}
}
}
// Avoids a ConcurrentModificationException when requests are started by another request completing. See #303.
private
List
<
Request
>
getSnapshot
()
{
// toArray creates a new ArrayList internally and this way we can guarantee entries will not be
// null. See #322.
List
<
Request
>
result
=
new
ArrayList
<
Request
>(
requests
.
size
());
// We could also just call new ArrayList<Request>(requests) but that actually creates two new ArrayLists because
// that constructor in ArrayList calls toArray().
for
(
Request
request
:
requests
)
{
result
.
add
(
request
);
}
return
result
;
}
}
}
library/src/main/java/com/bumptech/glide/util/Util.java
浏览文件 @
e7e7620f
...
@@ -8,6 +8,9 @@ import android.os.Looper;
...
@@ -8,6 +8,9 @@ import android.os.Looper;
import
com.bumptech.glide.request.target.Target
;
import
com.bumptech.glide.request.target.Target
;
import
java.util.ArrayDeque
;
import
java.util.ArrayDeque
;
import
java.util.ArrayList
;
import
java.util.Collection
;
import
java.util.List
;
import
java.util.Queue
;
import
java.util.Queue
;
/**
/**
...
@@ -157,9 +160,25 @@ public final class Util {
...
@@ -157,9 +160,25 @@ public final class Util {
}
}
/**
/**
*
Create
s a {@link java.util.Queue} of the given size using Glide's preferred implementation.
*
Return
s a {@link java.util.Queue} of the given size using Glide's preferred implementation.
*/
*/
public
static
<
T
>
Queue
<
T
>
createQueue
(
int
size
)
{
public
static
<
T
>
Queue
<
T
>
createQueue
(
int
size
)
{
return
new
ArrayDeque
<
T
>(
size
);
return
new
ArrayDeque
<
T
>(
size
);
}
}
/**
* Returns a copy of the given list that is safe to iterate over and perform actions that may
* modify the original list.
*
* <p> See #303 and #375. </p>
*/
public
static
<
T
>
List
<
T
>
getSnapshot
(
Collection
<
T
>
other
)
{
// toArray creates a new ArrayList internally and this way we can guarantee entries will not
// be null. See #322.
List
<
T
>
result
=
new
ArrayList
<
T
>(
other
.
size
());
for
(
T
item
:
other
)
{
result
.
add
(
item
);
}
return
result
;
}
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录