Merge pull request #176 from cydrain/caiyd_add_invalid_config_unittest

#175 add invalid config unittest

Former-commit-id: 63de3a5b060729839fe0d1a57816fd8a44322781

CHANGELOG.md

@@ -30,6 +30,7 @@ Please mark all change in change log and use the ticket from JIRA.
 - \#156 - Not return error when search_resources and index_build_device set cpu
 - \#159 - Change the configuration name from 'use_gpu_threshold' to 'gpu_search_threshold'
 - \#168 - Improve result reduce
+- \#175 - add invalid config unittest
 
 ## Task
 

core/src/server/Config.cpp

@@ -401,8 +401,7 @@ Status
 Config::CheckServerConfigDeployMode(const std::string& value) {
     if (value != "single" && value != "cluster_readonly" && value != "cluster_writable") {
         return Status(SERVER_INVALID_ARGUMENT,
-                      "server_config.deploy_mode is not one of "
-                      "single, cluster_readonly, and cluster_writable.");
+                      "server_config.deploy_mode is not one of single, cluster_readonly, and cluster_writable.");
     }
     return Status::OK();
 }

core/unittest/server/test_config.cpp

@@ -112,3 +112,120 @@ TEST_F(ConfigTest, SERVER_CONFIG_TEST) {
     s = config.ResetDefaultConfig();
     ASSERT_TRUE(s.ok());
 }
+
+TEST_F(ConfigTest, SERVER_CONFIG_INVALID_TEST) {
+    std::string config_path(CONFIG_PATH);
+    milvus::server::Config& config = milvus::server::Config::GetInstance();
+    milvus::Status s;
+
+    s = config.LoadConfigFile("");
+    ASSERT_FALSE(s.ok());
+
+    s = config.LoadConfigFile(config_path + INVALID_CONFIG_FILE);
+    ASSERT_FALSE(s.ok());
+
+    /* server config */
+    s = config.SetServerConfigAddress("0.0.0");
+    ASSERT_FALSE(s.ok());
+    s = config.SetServerConfigAddress("0.0.0.256");
+    ASSERT_FALSE(s.ok());
+
+    s = config.SetServerConfigPort("a");
+    ASSERT_FALSE(s.ok());
+    s = config.SetServerConfigPort("99999");
+    ASSERT_FALSE(s.ok());
+
+    s = config.SetServerConfigDeployMode("cluster");
+    ASSERT_FALSE(s.ok());
+
+    s = config.SetServerConfigTimeZone("GM");
+    ASSERT_FALSE(s.ok());
+    s = config.SetServerConfigTimeZone("GMT8");
+    ASSERT_FALSE(s.ok());
+    s = config.SetServerConfigTimeZone("UTCA");
+    ASSERT_FALSE(s.ok());
+
+    /* db config */
+    s = config.SetDBConfigPrimaryPath("");
+    ASSERT_FALSE(s.ok());
+
+//    s = config.SetDBConfigSecondaryPath("");
+//    ASSERT_FALSE(s.ok());
+
+    s = config.SetDBConfigBackendUrl("http://www.google.com");
+    ASSERT_FALSE(s.ok());
+    s = config.SetDBConfigBackendUrl("sqlite://:@:");
+    ASSERT_FALSE(s.ok());
+    s = config.SetDBConfigBackendUrl("mysql://root:123456@127.0.0.1/milvus");
+    ASSERT_FALSE(s.ok());
+
+    s = config.SetDBConfigArchiveDiskThreshold("0x10");
+    ASSERT_FALSE(s.ok());
+
+    s = config.SetDBConfigArchiveDaysThreshold("0x10");
+    ASSERT_FALSE(s.ok());
+
+    s = config.SetDBConfigInsertBufferSize("a");
+    ASSERT_FALSE(s.ok());
+    s = config.SetDBConfigInsertBufferSize("-1");
+    ASSERT_FALSE(s.ok());
+    s = config.SetDBConfigInsertBufferSize("2048");
+    ASSERT_FALSE(s.ok());
+
+    /* metric config */
+    s = config.SetMetricConfigEnableMonitor("Y");
+    ASSERT_FALSE(s.ok());
+
+    s = config.SetMetricConfigCollector("zilliz");
+    ASSERT_FALSE(s.ok());
+
+    s = config.SetMetricConfigPrometheusPort("0xff");
+    ASSERT_FALSE(s.ok());
+
+    /* cache config */
+    s = config.SetCacheConfigCpuCacheCapacity("a");
+    ASSERT_FALSE(s.ok());
+    s = config.SetCacheConfigCpuCacheCapacity("-1");
+    ASSERT_FALSE(s.ok());
+    s = config.SetCacheConfigCpuCacheCapacity("2048");
+    ASSERT_FALSE(s.ok());
+
+    s = config.SetCacheConfigCpuCacheThreshold("a");
+    ASSERT_FALSE(s.ok());
+    s = config.SetCacheConfigCpuCacheThreshold("1.0");
+    ASSERT_FALSE(s.ok());
+
+    s = config.SetCacheConfigGpuCacheCapacity("a");
+    ASSERT_FALSE(s.ok());
+    s = config.SetCacheConfigGpuCacheCapacity("128");
+    ASSERT_FALSE(s.ok());
+
+    s = config.SetCacheConfigGpuCacheThreshold("a");
+    ASSERT_FALSE(s.ok());
+    s = config.SetCacheConfigGpuCacheThreshold("1.0");
+    ASSERT_FALSE(s.ok());
+
+    s = config.SetCacheConfigCacheInsertData("N");
+    ASSERT_FALSE(s.ok());
+
+    /* engine config */
+    s = config.SetEngineConfigUseBlasThreshold("0xff");
+    ASSERT_FALSE(s.ok());
+
+    s = config.SetEngineConfigOmpThreadNum("a");
+    ASSERT_FALSE(s.ok());
+    s = config.SetEngineConfigOmpThreadNum("-1");
+    ASSERT_FALSE(s.ok());
+
+    s = config.SetEngineConfigGpuSearchThreshold("-1");
+    ASSERT_FALSE(s.ok());
+
+    /* resource config */
+    s = config.SetResourceConfigMode("default");
+    ASSERT_FALSE(s.ok());
+
+    s = config.SetResourceConfigIndexBuildDevice("gup2");
+    ASSERT_FALSE(s.ok());
+    s = config.SetResourceConfigIndexBuildDevice("gpu16");
+    ASSERT_FALSE(s.ok());
+}
\ No newline at end of file