ExecutionEngineImpl.cpp 16.2 KB
Newer Older
J
jinhai 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements.  See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership.  The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License.  You may obtain a copy of the License at
//
//   http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied.  See the License for the
// specific language governing permissions and limitations
// under the License.

S
starlord 已提交
18
#include "db/engine/ExecutionEngineImpl.h"
S
starlord 已提交
19
#include "cache/CpuCacheMgr.h"
S
starlord 已提交
20
#include "cache/GpuCacheMgr.h"
S
starlord 已提交
21
#include "metrics/Metrics.h"
J
jinhai 已提交
22
#include "utils/CommonUtil.h"
S
starlord 已提交
23
#include "utils/Exception.h"
S
starlord 已提交
24
#include "utils/Log.h"
S
starlord 已提交
25

X
xiaojun.lin 已提交
26
#include "knowhere/common/Config.h"
S
starlord 已提交
27
#include "knowhere/common/Exception.h"
S
starlord 已提交
28 29
#include "knowhere/index/vector_index/IndexIVFSQHybrid.h"
#include "scheduler/Utils.h"
30
#include "server/Config.h"
S
starlord 已提交
31 32
#include "wrapper/ConfAdapter.h"
#include "wrapper/ConfAdapterMgr.h"
S
starlord 已提交
33 34
#include "wrapper/VecImpl.h"
#include "wrapper/VecIndex.h"
X
xj.lin 已提交
35

S
starlord 已提交
36
#include <stdexcept>
S
starlord 已提交
37
#include <utility>
W
wxyu 已提交
38
#include <vector>
S
starlord 已提交
39

J
JinHai-CN 已提交
40
//#define ON_SEARCH
S
starlord 已提交
41 42 43
namespace milvus {
namespace engine {

W
wxyu 已提交
44 45
class CachedQuantizer : public cache::DataObj {
 public:
W
wxyu 已提交
46 47
    explicit CachedQuantizer(knowhere::QuantizerPtr data) : data_(std::move(data)) {
    }
W
wxyu 已提交
48 49 50 51 52 53 54 55 56 57 58 59 60 61 62

    knowhere::QuantizerPtr
    Data() {
        return data_;
    }

    int64_t
    Size() override {
        return data_->size;
    }

 private:
    knowhere::QuantizerPtr data_;
};

S
starlord 已提交
63 64 65
ExecutionEngineImpl::ExecutionEngineImpl(uint16_t dimension, const std::string& location, EngineType index_type,
                                         MetricType metric_type, int32_t nlist)
    : location_(location), dim_(dimension), index_type_(index_type), metric_type_(metric_type), nlist_(nlist) {
X
xj.lin 已提交
66
    index_ = CreatetVecIndex(EngineType::FAISS_IDMAP);
67
    if (!index_) {
68
        throw Exception(DB_ERROR, "Unsupported index type");
69
    }
X
xj.lin 已提交
70

X
xiaojun.lin 已提交
71 72 73
    TempMetaConf temp_conf;
    temp_conf.gpu_id = gpu_num_;
    temp_conf.dim = dimension;
S
starlord 已提交
74
    temp_conf.metric_type = (metric_type_ == MetricType::IP) ? knowhere::METRICTYPE::IP : knowhere::METRICTYPE::L2;
X
xiaojun.lin 已提交
75 76 77 78
    auto adapter = AdapterMgr::GetInstance().GetAdapter(index_->GetType());
    auto conf = adapter->Match(temp_conf);

    auto ec = std::static_pointer_cast<BFIndex>(index_)->Build(conf);
79 80 81
    if (ec != KNOWHERE_SUCCESS) {
        throw Exception(DB_ERROR, "Build index error");
    }
S
starlord 已提交
82 83
}

S
starlord 已提交
84 85 86
ExecutionEngineImpl::ExecutionEngineImpl(VecIndexPtr index, const std::string& location, EngineType index_type,
                                         MetricType metric_type, int32_t nlist)
    : index_(std::move(index)), location_(location), index_type_(index_type), metric_type_(metric_type), nlist_(nlist) {
X
xj.lin 已提交
87
}
S
starlord 已提交
88

S
starlord 已提交
89 90
VecIndexPtr
ExecutionEngineImpl::CreatetVecIndex(EngineType type) {
X
xj.lin 已提交
91 92 93 94
    std::shared_ptr<VecIndex> index;
    switch (type) {
        case EngineType::FAISS_IDMAP: {
            index = GetVecIndexFactory(IndexType::FAISS_IDMAP);
S
starlord 已提交
95 96
            break;
        }
J
jinhai 已提交
97
        case EngineType::FAISS_IVFFLAT: {
X
xj.lin 已提交
98
            index = GetVecIndexFactory(IndexType::FAISS_IVFFLAT_MIX);
S
starlord 已提交
99 100
            break;
        }
J
jinhai 已提交
101 102
        case EngineType::FAISS_IVFSQ8: {
            index = GetVecIndexFactory(IndexType::FAISS_IVFSQ8_MIX);
S
starlord 已提交
103 104
            break;
        }
X
xj.lin 已提交
105 106 107 108
        case EngineType::NSG_MIX: {
            index = GetVecIndexFactory(IndexType::NSG_MIX);
            break;
        }
W
wxyu 已提交
109 110 111 112
        case EngineType::FAISS_IVFSQ8H: {
            index = GetVecIndexFactory(IndexType::FAISS_IVFSQ8_HYBRID);
            break;
        }
X
xj.lin 已提交
113
        default: {
114
            ENGINE_LOG_ERROR << "Unsupported index type";
S
starlord 已提交
115 116 117
            return nullptr;
        }
    }
X
xj.lin 已提交
118
    return index;
S
starlord 已提交
119 120
}

121
void
W
wxyu 已提交
122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178
ExecutionEngineImpl::HybridLoad() const {
    if (index_type_ != EngineType::FAISS_IVFSQ8H) {
        return;
    }

    const std::string key = location_ + ".quantizer";
    std::vector<uint64_t> gpus = scheduler::get_gpu_pool();

    // cache hit
    {
        const int64_t NOT_FOUND = -1;
        int64_t device_id = NOT_FOUND;
        knowhere::QuantizerPtr quantizer = nullptr;

        for (auto& gpu : gpus) {
            auto cache = cache::GpuCacheMgr::GetInstance(gpu);
            if (auto cached_quantizer = cache->GetIndex(key)) {
                device_id = gpu;
                quantizer = std::static_pointer_cast<CachedQuantizer>(cached_quantizer)->Data();
            }
        }

        if (device_id != NOT_FOUND) {
            index_->SetQuantizer(quantizer);
            return;
        }
    }

    // cache miss
    {
        std::vector<int64_t> all_free_mem;
        for (auto& gpu : gpus) {
            auto cache = cache::GpuCacheMgr::GetInstance(gpu);
            auto free_mem = cache->CacheCapacity() - cache->CacheUsage();
            all_free_mem.push_back(free_mem);
        }

        auto max_e = std::max_element(all_free_mem.begin(), all_free_mem.end());
        auto best_index = std::distance(all_free_mem.begin(), max_e);
        auto best_device_id = gpus[best_index];

        auto quantizer_conf = std::make_shared<knowhere::QuantizerCfg>();
        quantizer_conf->mode = 1;
        quantizer_conf->gpu_id = best_device_id;
        auto quantizer = index_->LoadQuantizer(quantizer_conf);
        index_->SetQuantizer(quantizer);
        auto cache_quantizer = std::make_shared<CachedQuantizer>(quantizer);
        cache::GpuCacheMgr::GetInstance(best_device_id)->InsertItem(key, cache_quantizer);
    }
}

void
ExecutionEngineImpl::HybridUnset() const {
    if (index_type_ != EngineType::FAISS_IVFSQ8H) {
        return;
    }
    index_->UnsetQuantizer();
179 180
}

S
starlord 已提交
181
Status
S
starlord 已提交
182
ExecutionEngineImpl::AddWithIds(int64_t n, const float* xdata, const int64_t* xids) {
183 184
    auto status = index_->Add(n, xdata, xids);
    return status;
S
starlord 已提交
185 186
}

S
starlord 已提交
187 188 189
size_t
ExecutionEngineImpl::Count() const {
    if (index_ == nullptr) {
S
starlord 已提交
190
        ENGINE_LOG_ERROR << "ExecutionEngineImpl: index is null, return count 0";
S
starlord 已提交
191 192
        return 0;
    }
X
xj.lin 已提交
193
    return index_->Count();
S
starlord 已提交
194 195
}

S
starlord 已提交
196 197
size_t
ExecutionEngineImpl::Size() const {
S
starlord 已提交
198
    return (size_t)(Count() * Dimension()) * sizeof(float);
S
starlord 已提交
199 200
}

S
starlord 已提交
201 202 203
size_t
ExecutionEngineImpl::Dimension() const {
    if (index_ == nullptr) {
S
starlord 已提交
204
        ENGINE_LOG_ERROR << "ExecutionEngineImpl: index is null, return dimension " << dim_;
S
starlord 已提交
205 206
        return dim_;
    }
X
xj.lin 已提交
207
    return index_->Dimension();
S
starlord 已提交
208 209
}

S
starlord 已提交
210 211
size_t
ExecutionEngineImpl::PhysicalSize() const {
J
jinhai 已提交
212
    return server::CommonUtil::GetFileSize(location_);
S
starlord 已提交
213 214
}

S
starlord 已提交
215 216
Status
ExecutionEngineImpl::Serialize() {
217 218
    auto status = write_index(index_, location_);
    return status;
S
starlord 已提交
219 220
}

S
starlord 已提交
221 222
Status
ExecutionEngineImpl::Load(bool to_cache) {
223
    index_ = std::static_pointer_cast<VecIndex>(cache::CpuCacheMgr::GetInstance()->GetIndex(location_));
J
jinhai 已提交
224
    bool already_in_cache = (index_ != nullptr);
S
starlord 已提交
225
    if (!already_in_cache) {
X
xj.lin 已提交
226
        try {
Y
Yu Kun 已提交
227 228
            double physical_size = PhysicalSize();
            server::CollectExecutionEngineMetrics metrics(physical_size);
X
xj.lin 已提交
229
            index_ = read_index(location_);
S
starlord 已提交
230
            if (index_ == nullptr) {
S
starlord 已提交
231 232
                std::string msg = "Failed to load index from " + location_;
                ENGINE_LOG_ERROR << msg;
S
starlord 已提交
233
                return Status(DB_ERROR, msg);
S
starlord 已提交
234 235 236
            } else {
                ENGINE_LOG_DEBUG << "Disk io from: " << location_;
            }
S
starlord 已提交
237
        } catch (std::exception& e) {
S
starlord 已提交
238
            ENGINE_LOG_ERROR << e.what();
S
starlord 已提交
239
            return Status(DB_ERROR, e.what());
X
xj.lin 已提交
240
        }
X
xj.lin 已提交
241 242
    }

J
jinhai 已提交
243
    if (!already_in_cache && to_cache) {
X
xj.lin 已提交
244 245 246
        Cache();
    }
    return Status::OK();
X
xj.lin 已提交
247 248
}

S
starlord 已提交
249
Status
W
wxyu 已提交
250 251 252 253 254
ExecutionEngineImpl::CopyToGpu(uint64_t device_id, bool hybrid) {
    if (hybrid) {
        return Status::OK();
    }

255
    auto index = std::static_pointer_cast<VecIndex>(cache::GpuCacheMgr::GetInstance(device_id)->GetIndex(location_));
W
wxyu 已提交
256 257 258 259
    bool already_in_cache = (index != nullptr);
    if (already_in_cache) {
        index_ = index;
    } else {
S
starlord 已提交
260
        if (index_ == nullptr) {
S
starlord 已提交
261
            ENGINE_LOG_ERROR << "ExecutionEngineImpl: index is null, failed to copy to gpu";
S
starlord 已提交
262
            return Status(DB_ERROR, "index is null");
S
starlord 已提交
263 264
        }

Y
Yu Kun 已提交
265 266 267
        try {
            index_ = index_->CopyToGpu(device_id);
            ENGINE_LOG_DEBUG << "CPU to GPU" << device_id;
S
starlord 已提交
268
        } catch (std::exception& e) {
S
starlord 已提交
269
            ENGINE_LOG_ERROR << e.what();
S
starlord 已提交
270
            return Status(DB_ERROR, e.what());
Y
Yu Kun 已提交
271
        }
272
    }
Y
Yu Kun 已提交
273 274 275 276 277

    if (!already_in_cache) {
        GpuCache(device_id);
    }

278 279 280
    return Status::OK();
}

Y
Yu Kun 已提交
281 282
Status
ExecutionEngineImpl::CopyToIndexFileToGpu(uint64_t device_id) {
Y
Yu Kun 已提交
283 284 285
    auto to_index_data = std::make_shared<ToIndexData>(PhysicalSize());
    cache::DataObjPtr obj = std::static_pointer_cast<cache::DataObj>(to_index_data);
    milvus::cache::GpuCacheMgr::GetInstance(device_id)->InsertItem(location_, obj);
Y
Yu Kun 已提交
286 287 288
    return Status::OK();
}

S
starlord 已提交
289 290
Status
ExecutionEngineImpl::CopyToCpu() {
291
    auto index = std::static_pointer_cast<VecIndex>(cache::CpuCacheMgr::GetInstance()->GetIndex(location_));
W
wxyu 已提交
292 293 294 295
    bool already_in_cache = (index != nullptr);
    if (already_in_cache) {
        index_ = index;
    } else {
S
starlord 已提交
296
        if (index_ == nullptr) {
S
starlord 已提交
297
            ENGINE_LOG_ERROR << "ExecutionEngineImpl: index is null, failed to copy to cpu";
S
starlord 已提交
298
            return Status(DB_ERROR, "index is null");
S
starlord 已提交
299 300
        }

Y
Yu Kun 已提交
301 302 303
        try {
            index_ = index_->CopyToCpu();
            ENGINE_LOG_DEBUG << "GPU to CPU";
S
starlord 已提交
304
        } catch (std::exception& e) {
S
starlord 已提交
305
            ENGINE_LOG_ERROR << e.what();
S
starlord 已提交
306
            return Status(DB_ERROR, e.what());
Y
Yu Kun 已提交
307 308 309
        }
    }

W
wxyu 已提交
310
    if (!already_in_cache) {
Y
Yu Kun 已提交
311
        Cache();
312 313 314 315
    }
    return Status::OK();
}

S
starlord 已提交
316 317 318
ExecutionEnginePtr
ExecutionEngineImpl::Clone() {
    if (index_ == nullptr) {
S
starlord 已提交
319 320 321 322
        ENGINE_LOG_ERROR << "ExecutionEngineImpl: index is null, failed to clone";
        return nullptr;
    }

W
wxyu 已提交
323 324 325 326 327 328
    auto ret = std::make_shared<ExecutionEngineImpl>(dim_, location_, index_type_, metric_type_, nlist_);
    ret->Init();
    ret->index_ = index_->Clone();
    return ret;
}

S
starlord 已提交
329
Status
S
starlord 已提交
330
ExecutionEngineImpl::Merge(const std::string& location) {
X
xj.lin 已提交
331
    if (location == location_) {
S
starlord 已提交
332
        return Status(DB_ERROR, "Cannot Merge Self");
X
xj.lin 已提交
333 334
    }
    ENGINE_LOG_DEBUG << "Merge index file: " << location << " to: " << location_;
S
starlord 已提交
335

S
starlord 已提交
336
    auto to_merge = cache::CpuCacheMgr::GetInstance()->GetIndex(location);
X
xj.lin 已提交
337
    if (!to_merge) {
X
xj.lin 已提交
338
        try {
Y
Yu Kun 已提交
339 340
            double physical_size = server::CommonUtil::GetFileSize(location);
            server::CollectExecutionEngineMetrics metrics(physical_size);
X
xj.lin 已提交
341
            to_merge = read_index(location);
S
starlord 已提交
342
        } catch (std::exception& e) {
S
starlord 已提交
343
            ENGINE_LOG_ERROR << e.what();
S
starlord 已提交
344
            return Status(DB_ERROR, e.what());
X
xj.lin 已提交
345
        }
X
xj.lin 已提交
346 347
    }

S
starlord 已提交
348
    if (index_ == nullptr) {
S
starlord 已提交
349
        ENGINE_LOG_ERROR << "ExecutionEngineImpl: index is null, failed to merge";
S
starlord 已提交
350
        return Status(DB_ERROR, "index is null");
S
starlord 已提交
351 352
    }

X
xj.lin 已提交
353
    if (auto file_index = std::dynamic_pointer_cast<BFIndex>(to_merge)) {
354 355
        auto status = index_->Add(file_index->Count(), file_index->GetRawVectors(), file_index->GetRawIds());
        if (!status.ok()) {
X
xj.lin 已提交
356 357
            ENGINE_LOG_ERROR << "Merge: Add Error";
        }
358
        return status;
X
xj.lin 已提交
359
    } else {
S
starlord 已提交
360
        return Status(DB_ERROR, "file index type is not idmap");
X
xj.lin 已提交
361
    }
S
starlord 已提交
362 363 364
}

ExecutionEnginePtr
S
starlord 已提交
365
ExecutionEngineImpl::BuildIndex(const std::string& location, EngineType engine_type) {
X
xj.lin 已提交
366 367 368
    ENGINE_LOG_DEBUG << "Build index file: " << location << " from: " << location_;

    auto from_index = std::dynamic_pointer_cast<BFIndex>(index_);
S
starlord 已提交
369
    if (from_index == nullptr) {
S
starlord 已提交
370 371 372 373
        ENGINE_LOG_ERROR << "ExecutionEngineImpl: from_index is null, failed to build index";
        return nullptr;
    }

S
starlord 已提交
374
    auto to_index = CreatetVecIndex(engine_type);
X
xj.lin 已提交
375
    if (!to_index) {
376
        throw Exception(DB_ERROR, "Unsupported index type");
X
xj.lin 已提交
377 378
    }

X
xiaojun.lin 已提交
379 380 381 382
    TempMetaConf temp_conf;
    temp_conf.gpu_id = gpu_num_;
    temp_conf.dim = Dimension();
    temp_conf.nlist = nlist_;
S
starlord 已提交
383
    temp_conf.metric_type = (metric_type_ == MetricType::IP) ? knowhere::METRICTYPE::IP : knowhere::METRICTYPE::L2;
X
xiaojun.lin 已提交
384 385 386 387
    temp_conf.size = Count();

    auto adapter = AdapterMgr::GetInstance().GetAdapter(to_index->GetType());
    auto conf = adapter->Match(temp_conf);
X
xj.lin 已提交
388

S
starlord 已提交
389 390 391 392
    auto status = to_index->BuildAll(Count(), from_index->GetRawVectors(), from_index->GetRawIds(), conf);
    if (!status.ok()) {
        throw Exception(DB_ERROR, status.message());
    }
X
xj.lin 已提交
393

S
starlord 已提交
394
    return std::make_shared<ExecutionEngineImpl>(to_index, location, engine_type, metric_type_, nlist_);
S
starlord 已提交
395 396
}

S
starlord 已提交
397
Status
W
wxyu 已提交
398
ExecutionEngineImpl::Search(int64_t n, const float* data, int64_t k, int64_t nprobe, float* distances, int64_t* labels,
J
JinHai-CN 已提交
399
                            bool hybrid) {
400
#if 0
J
JinHai-CN 已提交
401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452
    if (index_type_ == EngineType::FAISS_IVFSQ8H) {
        if (!hybrid) {
            const std::string key = location_ + ".quantizer";
            std::vector<uint64_t> gpus = scheduler::get_gpu_pool();

            const int64_t NOT_FOUND = -1;
            int64_t device_id = NOT_FOUND;

            // cache hit
            {
                knowhere::QuantizerPtr quantizer = nullptr;

                for (auto& gpu : gpus) {
                    auto cache = cache::GpuCacheMgr::GetInstance(gpu);
                    if (auto cached_quantizer = cache->GetIndex(key)) {
                        device_id = gpu;
                        quantizer = std::static_pointer_cast<CachedQuantizer>(cached_quantizer)->Data();
                    }
                }

                if (device_id != NOT_FOUND) {
                    // cache hit
                    auto config = std::make_shared<knowhere::QuantizerCfg>();
                    config->gpu_id = device_id;
                    config->mode = 2;
                    auto new_index = index_->LoadData(quantizer, config);
                    index_ = new_index;
                }
            }

            if (device_id == NOT_FOUND) {
                // cache miss
                std::vector<int64_t> all_free_mem;
                for (auto& gpu : gpus) {
                    auto cache = cache::GpuCacheMgr::GetInstance(gpu);
                    auto free_mem = cache->CacheCapacity() - cache->CacheUsage();
                    all_free_mem.push_back(free_mem);
                }

                auto max_e = std::max_element(all_free_mem.begin(), all_free_mem.end());
                auto best_index = std::distance(all_free_mem.begin(), max_e);
                device_id = gpus[best_index];

                auto pair = index_->CopyToGpuWithQuantizer(device_id);
                index_ = pair.first;

                // cache
                auto cached_quantizer = std::make_shared<CachedQuantizer>(pair.second);
                cache::GpuCacheMgr::GetInstance(device_id)->InsertItem(key, cached_quantizer);
            }
        }
    }
453
#endif
J
JinHai-CN 已提交
454

S
starlord 已提交
455
    if (index_ == nullptr) {
S
starlord 已提交
456
        ENGINE_LOG_ERROR << "ExecutionEngineImpl: index is null, failed to search";
S
starlord 已提交
457
        return Status(DB_ERROR, "index is null");
S
starlord 已提交
458 459
    }

Y
Yu Kun 已提交
460
    ENGINE_LOG_DEBUG << "Search Params: [k]  " << k << " [nprobe] " << nprobe;
X
xiaojun.lin 已提交
461 462 463 464 465 466 467 468 469

    // TODO(linxj): remove here. Get conf from function
    TempMetaConf temp_conf;
    temp_conf.k = k;
    temp_conf.nprobe = nprobe;

    auto adapter = AdapterMgr::GetInstance().GetAdapter(index_->GetType());
    auto conf = adapter->MatchSearch(temp_conf, index_->GetType());

W
wxyu 已提交
470 471 472
    if (hybrid) {
        HybridLoad();
    }
W
wxyu 已提交
473

X
xiaojun.lin 已提交
474
    auto status = index_->Search(n, data, distances, labels, conf);
W
wxyu 已提交
475

W
wxyu 已提交
476 477 478
    if (hybrid) {
        HybridUnset();
    }
W
wxyu 已提交
479

480
    if (!status.ok()) {
X
xj.lin 已提交
481 482
        ENGINE_LOG_ERROR << "Search error";
    }
483
    return status;
S
starlord 已提交
484 485
}

S
starlord 已提交
486 487
Status
ExecutionEngineImpl::Cache() {
488
    cache::DataObjPtr obj = std::static_pointer_cast<cache::DataObj>(index_);
S
starlord 已提交
489
    milvus::cache::CpuCacheMgr::GetInstance()->InsertItem(location_, obj);
S
starlord 已提交
490 491 492 493

    return Status::OK();
}

S
starlord 已提交
494 495
Status
ExecutionEngineImpl::GpuCache(uint64_t gpu_id) {
496
    cache::DataObjPtr obj = std::static_pointer_cast<cache::DataObj>(index_);
S
starlord 已提交
497
    milvus::cache::GpuCacheMgr::GetInstance(gpu_id)->InsertItem(location_, obj);
498 499

    return Status::OK();
Y
Yu Kun 已提交
500 501
}

X
xj.lin 已提交
502
// TODO(linxj): remove.
S
starlord 已提交
503 504
Status
ExecutionEngineImpl::Init() {
S
starlord 已提交
505
    server::Config& config = server::Config::GetInstance();
506
    Status s = config.GetResourceConfigIndexBuildDevice(gpu_num_);
S
starlord 已提交
507
    if (!s.ok()) {
S
starlord 已提交
508
        return s;
S
starlord 已提交
509
    }
S
starlord 已提交
510 511 512 513

    return Status::OK();
}

S
starlord 已提交
514 515
}  // namespace engine
}  // namespace milvus