1. 29 3月, 2014 1 次提交
  2. 28 3月, 2014 2 次提交
    • A
      HLLADD implemented. · 156929ee
      antirez 提交于
      156929ee
    • A
      HLLSELFTEST command implemented. · 552eb540
      antirez 提交于
      To test the bitfield array of counters set/get macros from the Redis Tcl
      suite is hard, so a specialized command that is able to test the
      internals was developed.
      552eb540
  3. 25 3月, 2014 1 次提交
    • M
      Add REDIS_MIN_RESERVED_FDS define for open fds · 3b54ee6e
      Matt Stancliff 提交于
      Also update the original REDIS_EVENTLOOP_FDSET_INCR to
      include REDIS_MIN_RESERVED_FDS. REDIS_EVENTLOOP_FDSET_INCR
      exists to make sure more than (maxclients+RESERVED) entries
      are allocated, but we can only guarantee that if we include
      the current value of REDIS_MIN_RESERVED_FDS as a minimum
      for the INCR size.
      3b54ee6e
  4. 24 3月, 2014 2 次提交
    • M
      Fix maxclients error handling · c138631c
      Matt Stancliff 提交于
      Everywhere in the Redis code base, maxclients is treated
      as an int with (int)maxclients or `maxclients = atoi(source)`,
      so let's make maxclients an int.
      
      This fixes a bug where someone could specify a negative maxclients
      on startup and it would work (as well as set maxclients very high)
      because:
      
          unsigned int maxclients;
          char *update = "-300";
          maxclients = atoi(update);
          if (maxclients < 1) goto fail;
      
      But, (maxclients < 1) can only catch the case when maxclients
      is exactly 0.  maxclients happily sets itself to -300, which isn't
      -300, but rather 4294966996, which isn't < 1, so... everything
      "worked."
      
      maxclients config parsing checks for the case of < 1, but maxclients
      CONFIG SET parsing was checking for case of < 0 (allowing
      maxclients to be set to 0).  CONFIG SET parsing is now updated to
      match config parsing of < 1.
      
      It's tempting to add a MINIMUM_CLIENTS define, but... I didn't.
      
      These changes were inspired by antirez#356, but this doesn't
      fix that issue.
      c138631c
    • A
      Sample and cache RSS in serverCron(). · 93253c27
      antirez 提交于
      Obtaining the RSS (Resident Set Size) info is slow in Linux and OSX.
      This slowed down the generation of the INFO 'memory' section.
      
      Since the RSS does not require to be a real-time measurement, we
      now sample it with server.hz frequency (10 times per second by default)
      and use this value both to show the INFO rss field and to compute the
      fragmentation ratio.
      
      Practically this does not make any difference for memory profiling of
      Redis but speeds up the INFO call significantly.
      93253c27
  5. 21 3月, 2014 3 次提交
    • A
      The default maxmemory policy is now noeviction. · 5fa3248b
      antirez 提交于
      This is safer as by default maxmemory should just set a memory limit
      without any key to be deleted, unless the policy is set to something
      more relaxed.
      5fa3248b
    • A
      Use 24 bits for the lru object field and improve resolution. · a9836992
      antirez 提交于
      There were 2 spare bits inside the Redis object structure that are now
      used in order to enlarge 4x the range of the LRU field.
      
      At the same time the resolution was improved from 10 to 1 second: this
      still provides 194 days before the LRU counter overflows (restarting from
      zero).
      
      This is not a problem since it only causes lack of eviction precision for
      objects not touched for a very long time, and the lack of precision is
      only temporary.
      a9836992
    • A
      Default LRU samples is now 5. · f4da796c
      antirez 提交于
      f4da796c
  6. 20 3月, 2014 5 次提交
    • A
      LRU eviction pool implementation. · 22c9cfaf
      antirez 提交于
      This is an improvement over the previous eviction algorithm where we use
      an eviction pool that is persistent across evictions of keys, and gets
      populated with the best candidates for evictions found so far.
      
      It allows to approximate LRU eviction at a given number of samples
      better than the previous algorithm used.
      22c9cfaf
    • A
      Obtain LRU clock in a resolution dependent way. · ad6b0f70
      antirez 提交于
      For testing purposes it is handy to have a very high resolution of the
      LRU clock, so that it is possible to experiment with scripts running in
      just a few seconds how the eviction algorithms works.
      
      This commit allows Redis to use the cached LRU clock, or a value
      computed on demand, depending on the resolution. So normally we have the
      good performance of a precomputed value, and a clock that wraps in many
      days using the normal resolution, but if needed, changing a define will
      switch behavior to an high resolution LRU clock.
      ad6b0f70
    • A
      Specify lruclock in redisServer structure via REDIS_LRU_BITS. · 1faf8266
      antirez 提交于
      The padding field was totally useless: removed.
      1faf8266
    • A
      Specify LRU resolution in milliseconds. · d77e2316
      antirez 提交于
      d77e2316
    • A
      Set LRU parameters via REDIS_LRU_BITS define. · fe308470
      antirez 提交于
      fe308470
  7. 19 3月, 2014 1 次提交
  8. 10 3月, 2014 3 次提交
    • A
      Cluster: SORT get keys helper implemented. · 04cf02e8
      antirez 提交于
      04cf02e8
    • A
      Cluster: evalGetKey() added for EVAL/EVALSHA. · c0e818ab
      antirez 提交于
      Previously we used zunionInterGetKeys(), however after this function was
      fixed to account for the destination key (not needed when the API was
      designed for "diskstore") the two set of commands can no longer be served
      by an unique keys-extraction function.
      c0e818ab
    • A
      Cluster: getKeysFromCommand() API cleaned up. · 787b2970
      antirez 提交于
      This API originated from the "diskstore" experiment, not for Redis
      Cluster itself, so there were legacy/useless things trying to
      differentiate between keys that are going to be overwritten and keys
      that need to be fetched from disk (preloaded).
      
      All useless with Cluster, so removed with the result of code
      simplification.
      787b2970
  9. 04 3月, 2014 1 次提交
  10. 27 2月, 2014 1 次提交
    • A
      Initial implementation of BITPOS. · 38c620b3
      antirez 提交于
      It appears to work but more stress testing, and both unit tests and
      fuzzy testing, is needed in order to ensure the implementation is sane.
      38c620b3
  11. 13 2月, 2014 1 次提交
    • A
      Update cached time in rdbLoad() callback. · 51bd9da1
      antirez 提交于
      server.unixtime and server.mstime are cached less precise timestamps
      that we use every time we don't need an accurate time representation and
      a syscall would be too slow for the number of calls we require.
      
      Such an example is the initialization and update process of the last
      interaction time with the client, that is used for timeouts.
      
      However rdbLoad() can take some time to load the DB, but at the same
      time it did not updated the time during DB loading. This resulted in the
      bug described in issue #1535, where in the replication process the slave
      loads the DB, creates the redisClient representation of its master, but
      the timestamp is so old that the master, under certain conditions, is
      sensed as already "timed out".
      
      Thanks to @yoav-steinberg and Redis Labs Inc for the bug report and
      analysis.
      51bd9da1
  12. 12 2月, 2014 1 次提交
    • A
      AOF: don't abort on write errors unless fsync is 'always'. · fe835254
      antirez 提交于
      A system similar to the RDB write error handling is used, in which when
      we can't write to the AOF file, writes are no longer accepted until we
      are able to write again.
      
      For fsync == always we still abort on errors since there is currently no
      easy way to avoid replying with success to the user otherwise, and this
      would violate the contract with the user of only acknowledging data
      already secured on disk.
      fe835254
  13. 04 2月, 2014 1 次提交
    • A
      CLIENT PAUSE and related API implemented. · 4919a13f
      antirez 提交于
      The API is one of the bulding blocks of CLUSTER FAILOVER command that
      executes a manual failover in Redis Cluster. However exposed as a
      command that the user can call directly, it makes much simpler to
      upgrade a standalone Redis instance using a slave in a safer way.
      
      The commands works like that:
      
          CLIENT PAUSE <milliesconds>
      
      All the clients that are not slaves and not in MONITOR state are paused
      for the specified number of milliesconds. This means that slaves are
      normally served in the meantime.
      
      At the end of the specified amount of time all the clients are unblocked
      and will continue operations normally. This command has no effects on
      the population of the slow log, since clients are not blocked in the
      middle of operations but only when there is to process new data.
      
      Note that while the clients are unblocked, still new commands are
      accepted and queued in the client buffer, so clients will likely not
      block while writing to the server while the pause is active.
      4919a13f
  14. 03 2月, 2014 1 次提交
  15. 31 1月, 2014 3 次提交
  16. 29 1月, 2014 1 次提交
    • A
      Cluster: function clusterGetSlaveRank() added. · 6f540320
      antirez 提交于
      Return the number of slaves for the same master having a better
      replication offset of the current slave, that is, the slave "rank" used
      to pick a delay before the request for election.
      6f540320
  17. 14 1月, 2014 2 次提交
    • A
      Cluster: support to read from slave nodes. · 28273394
      antirez 提交于
      A client can enter a special cluster read-only mode using the READONLY
      command: if the client read from a slave instance after this command,
      for slots that are actually served by the instance's master, the queries
      will be processed without redirection, allowing clients to read from
      slaves (but without any kind fo read-after-write guarantee).
      
      The READWRITE command can be used in order to exit the readonly state.
      28273394
    • A
      Set REDIS_AOF_REWRITE_MIN_SIZE to 64mb. · 51894856
      antirez 提交于
      64mb is the default value in redis.conf. For some reason instead the
      hard-coded default was 1mb that is too small.
      51894856
  18. 08 1月, 2014 1 次提交
    • A
      Don't send REPLCONF ACK to old masters. · 90a81b4e
      antirez 提交于
      Masters not understanding REPLCONF ACK will reply with errors to our
      requests causing a number of possible issues.
      
      This commit detects a global replication offest set to -1 at the end of
      the replication, and marks the client representing the master with the
      REDIS_PRE_PSYNC flag.
      
      Note that this flag was called REDIS_PRE_PSYNC_SLAVE but now it is just
      REDIS_PRE_PSYNC as it is used for both slaves and masters starting with
      this commit.
      
      This commit fixes issue #1488.
      90a81b4e
  19. 19 12月, 2013 1 次提交
  20. 11 12月, 2013 3 次提交
    • Y
    • A
      Slaves heartbeats during sync improved. · 11120689
      antirez 提交于
      The previous fix for false positive timeout detected by master was not
      complete. There is another blocking stage while loading data for the
      first synchronization with the master, that is, flushing away the
      current data from the DB memory.
      
      This commit uses the newly introduced dict.c callback in order to make
      some incremental work (to send "\n" heartbeats to the master) while
      flushing the old data from memory.
      
      It is hard to write a regression test for this issue unfortunately. More
      support for debugging in the Redis core would be needed in terms of
      functionalities to simulate a slow DB loading / deletion.
      11120689
    • A
      dict.c: added optional callback to dictEmpty(). · 2eb781b3
      antirez 提交于
      Redis hash table implementation has many non-blocking features like
      incremental rehashing, however while deleting a large hash table there
      was no way to have a callback called to do some incremental work.
      
      This commit adds this support, as an optiona callback argument to
      dictEmpty() that is currently called at a fixed interval (one time every
      65k deletions).
      2eb781b3
  21. 04 12月, 2013 2 次提交
  22. 03 12月, 2013 1 次提交
  23. 30 11月, 2013 1 次提交
  24. 21 11月, 2013 1 次提交
    • A
      Sentinel: test for writable config file. · 297de1ab
      antirez 提交于
      This commit introduces a funciton called when Sentinel is ready for
      normal operations to avoid putting Sentinel specific stuff in redis.c.
      297de1ab