- 04 12月, 2014 10 次提交
-
-
由 James Robinson 提交于
Since we don't support using the component build to produce mojo apps, we can simplify the build targets in a few ways: *) every mojo_native_application must depend on the c system thunks, so just make that part of the template instead of requiring the dep *) there's no such thing as depending on gles2 headers from a component, so delete the forwarding group. Most targets that want to use the gles2 headers in a mojo context want to depend on an implementation through the thunks, so //mojo/public/c/gles2 does just that. A smaller number of targets (such as the implementation of the thunks) want to just depend on the headers but not an impl, so they can depend on //mojo/public/c/gles2:headers. The //mojo/public/gles target isn't that useful since the only thing we expose is a set of C entry points. We can probably also simplify the c system targets, but that's trickier due to more extensive use from the chromium side. BUG=438701 R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/780733002
-
由 Elliott Sprehn 提交于
Mojo handles the security of our network layer, so we don't need SchemeRegistry, and WebSecurityPolicy was just a wrapper around it. R=eseidel@google.com Review URL: https://codereview.chromium.org/758233004
-
由 Elliott Sprehn 提交于
The StyleRule classes supported copy() operations and mutable property sets so that we could do copy-on-write and mutate them using the CSSOM. Sky doesn't have a CSSOM like this though, so we can remove all this code and make the StyleRule classes effectively immutable after construction (the parser does mutate some rules though). I also removed some other dead code in the StyleRule hierarchy, like some left over mutation methods that the CSSOM used to use. R=eseidel@chromium.org, ojan@chromium.org Review URL: https://codereview.chromium.org/758573005
-
由 Eric Seidel 提交于
These were a feature for allowing multiple scripting contexts to access the same global state without leaking wrappers between them. For example, if the inspector wanted to modify window.Array.dangerousFunction = ... it wouldn't want the author's content to have access to that. This feature is not part of Sky's security model and thus this is just dead code. I tried to remove worlds all together, but there is something special about how we use a "fake" world (which is neither main nor isolated) for GC, regexp and testing. R=rafaelw@chromium.org, abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/776143003
-
由 Elliott Sprehn 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/778743003
-
由 Adam Barth 提交于
-
https://crrev.com/306655由 James Robinson 提交于
Includes updates to ui/ and mojo/services for cc and gpu changes and a minor update to a unit test in sky/ for skia interface changes. Review URL: https://codereview.chromium.org/761903003
-
由 Elliott Sprehn 提交于
TouchAdjustment adjusts the hit test rects to nearby elements so that when touch targets are too small they can still be hit by users. Instead applications should just make their touch targets big enough, and if they need adjustment it should be implemented at the framework level. R=ojan@chromium.org Review URL: https://codereview.chromium.org/774053003
-
由 Elliott Sprehn 提交于
This leaves CSSValue, but removes everything else. R=ojan@chromium.org Review URL: https://codereview.chromium.org/780483002
-
由 Ojan Vafai 提交于
This was for RenderReplica, which we no longer have. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/772333002
-
- 03 12月, 2014 21 次提交
-
-
由 Yury Semikhatsky 提交于
It is unused in Sky. I'm going to remove it in Blink too. BUG=None TBR=eseidel Review URL: https://codereview.chromium.org/754463004
-
由 Elliott Sprehn 提交于
We should come up with a better way to implement this feature for the inspector, the current implementation uses CSSOM wrappers and is n^2 over the number of rules in the page. R=ojan@chromium.org Review URL: https://codereview.chromium.org/772363002
-
由 Elliott Sprehn 提交于
Also remove related dead code. R=ojan@chromium.org Review URL: https://codereview.chromium.org/780443002
-
由 Elliott Sprehn 提交于
In preparation of simplifying how we collect and process sheets now that we don't support descendant, sibling and tree boundary crossing rules we should switch to always going down the Reconstruct path. This might be somewhat slower to start, but because our rules are so much simpler we should be able to rebuild the StyleEngine to do something simpler and faster. R=ojan@chromium.org Review URL: https://codereview.chromium.org/774953002
-
由 Ojan Vafai 提交于
It's never set. It was added in https://chromium.googlesource.com/chromium/blink/+/7176977ba5087a97ef38b1a88d0e450e924404ca%5E%21/#F21 The test cases from that patch seem to pass. Included one in this patch. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/772193004
-
由 Elliott Sprehn 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/775783002
-
由 Eric Seidel 提交于
It was attempting to load InjectedScript, etc. with the wrong path and hitting a CHECK(). I moved InjectedScript and DebugScript into the v8_inspector directory and fixed their loading. I also broke the dependency from v8_inspector onto engine/platform by moving the horrible Platform::loadResource hack out of PlatformImpl into a new file just for v8_inspector. In this process I also found some (broken!) code for showing the broken image icon which if we ever hit would just have crashed, so I removed that code as well. BUG=435243 R=ojan@chromium.org Review URL: https://codereview.chromium.org/776743002
-
由 Rafael Weinstein 提交于
This patch (re)hooks up animations so they start and removes the infrastructure required by blink to synchronize the compositor and main threads. R=ojan@chromium.org Review URL: https://codereview.chromium.org/772673002
-
由 Eric Seidel 提交于
I also removed it from a bunch of core/ as almost all the places its included it is not actually needed. BUG=435243 TBR=yurys@chromium.org Review URL: https://codereview.chromium.org/775803002
-
由 Eric Seidel 提交于
Removed all uses of Frame in InspectorTraceEvents in the process, since none of them actually needed a Frame (since each sky instance only has one frame). I've just been burning down the list of core includes using: grep "#include" sky/engine/v8_inspector/* -h | sort | uniq | sort | grep core TBR=yurys@chromium.org BUG=435243 Review URL: https://codereview.chromium.org/771323002
-
由 Eric Seidel 提交于
This doesn't fully separate v8_inspector from core, but it does lay the path. The next steps to removing v8_inspector is to remove all the # FIXME: Remove lines in the deps section of v8_inspector/BUILD.gn. gn check out/Debug v8_inspector will tell us if we've successfully removed all the dependencies. It's unclear if we want to remove the wtf dependency, but definitely all of the engine/core dependencies should be removed and presumably replaced with abstract interfaces which can be provided to v8_inspector by its host. Given the size of this patch (and that it's largely mechanical) I plan to TBR it. Most of this was done with tools/git/move_source_file.py TBR=yurys@chromium.org Review URL: https://codereview.chromium.org/772563003
-
由 Elliott Sprehn 提交于
R=eseidel@chromium.org, ojan@chromium.org Review URL: https://codereview.chromium.org/772133003
-
由 Elliott Sprehn 提交于
This is a framework feature. R=ojan@chromium.org Review URL: https://codereview.chromium.org/774793002
-
由 Elliott Sprehn 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/772743004
-
由 Elliott Sprehn 提交于
R=ojan@chromium.org Review URL: https://codereview.chromium.org/767623004
-
由 James Robinson 提交于
R=erg@chromium.org Review URL: https://codereview.chromium.org/765753003
-
由 Ojan Vafai 提交于
We not longer have compositing, so these states are gone. This was causing asserts to hit because we'd go from PaintInvalidationClean to InPaintInvalidation, which is now a valid transition if a new frame is pumped without style or layout being dirtied. Unfortunately, we can't test this until we fix test_sky to actually pump fake frames. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/755843003
-
由 Elliott Sprehn 提交于
R=ojan@chromium.org Review URL: https://codereview.chromium.org/771933002
-
由 Elliott Sprehn 提交于
This makes MarkupAccumulator and all related code into dead code. R=ojan@chromium.org Review URL: https://codereview.chromium.org/771093002
-
由 Elliott Sprehn 提交于
We only support inline stylesheets or <style scoped> so we can remove this helper. R=ojan@chromium.org Review URL: https://codereview.chromium.org/767013004
-
由 Elliott Sprehn 提交于
R=ojan@chromium.org Review URL: https://codereview.chromium.org/776493002
-
- 02 12月, 2014 9 次提交
-
-
由 Elliott Sprehn 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/770223002
-
由 Adam Barth 提交于
According to jamesr, static_library is almost never what we want because we just configure static libraries to be thin archives anyway. R=jamesr@chromium.org Review URL: https://codereview.chromium.org/766053007
-
由 Elliott Sprehn 提交于
This isn't needed, we don't have any tree boundary crossing rules. R=ojan@chromium.org Review URL: https://codereview.chromium.org/767273003
-
由 Ian Hickson 提交于
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/730693007
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/772713002
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/771853002
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/773683002
-
由 James Robinson 提交于
This adds a tracing service that can aggregate tracing data from multiple sources and write a json file out to disk that trace-viewer can understand. This also teaches the shell, sky_viewer, and various other services how to register themselves with the tracing service and provide tracing data on demand. Finally, this teaches the skydb prompt to tell the tracing service to start/stop tracing when the 'trace' command is issued. The tracing service exposes two APIs, a collector interface and a coordinator interface. The collector interface allows different entities to register themselves as being capable of producing tracing data. The coordinator interface allows asking the service to collect data from all registered sources and flushing the collected data to disk. The service keeps track of all open connections to registered sources and broadcasts a request for data whenever the coordinator's Start method is called, then aggregates all data send back into a single trace file. In this patch, the tracing service simply gives all sources 1 second to return data then flushes to disk. Ideally it would keep track of how many requests it sent out and give each source a certain amount of time to respond but this is simple and works for most cases. The tracing service can talk to any source that is capable of producing data that the trace-viewer can handle, which is a broad set, but in practice many programs will want to use //base/debug's tracing to produce trace data. This adds code at //mojo/common:tracing_impl that registers a collector hooked up to //base/debug's tracing system. This can be dropped in to the mojo::ApplicationDelegate::Initialize() implementation for most services and applications to easily enable base tracing. Programs that don't use //base, or that want to register additional data sources that can talk to trace viewer (perhaps providing data that's more easily available from another thread, say) may want to create additional connections to the tracing service. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/769963004
-