- 30 10月, 2014 19 次提交
-
-
由 Elliott Sprehn 提交于
We don't need a lot of the Widget API. I also removed the visibility code which seems to have been broken when we removed FrameView::show and hide(), which looks like it would have broken image loading. Unfortuantely we don't have pixel tests or tests that load images so I can't test this yet. Even so it's a good simplificatin since our system has no concept of hidden widgets. R=abarth@chromium.org, ojan@chromium.org Review URL: https://codereview.chromium.org/691453002
-
由 Adam Barth 提交于
R=esprehn@chromium.org Review URL: https://codereview.chromium.org/687263005
-
由 Elliott Sprehn 提交于
This leaves some uses of FloatingObject*, but it doesn't leave the impl of the class so it's all dead code passing around null pointers. I'll remove that in a future patch. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/689733003
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/687353003
-
由 Eric Seidel 提交于
Also fixed the exception caused by IndexedDB being missing. It was there, just not used by inspector.sky. R=esprehn@chromium.org, abarth@chromium.org Review URL: https://codereview.chromium.org/662523003
-
由 Elliott Sprehn 提交于
R=eseidel@chromium.org, ojan@chromium.org Review URL: https://codereview.chromium.org/678113005
-
由 Adam Barth 提交于
Instead of calling the function constructor to compile script in Sky, we now concatenate strings. This has the advantage of making the line numbers generated in error messages correct but the disadvantage of being a hack. I've filed https://code.google.com/p/v8/issues/detail?id=3624 to request a proper API for this purpose. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/688033003
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/689763003
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/687353002
-
由 Hixie 提交于
Specs: Pass the module last so that if we add other values later we don't shift things in the arguments array Review URL: https://codereview.chromium.org/689763002
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/692563003
-
由 Adam Barth 提交于
R=esprehn@chromium.org Review URL: https://codereview.chromium.org/690803002
-
由 Hixie 提交于
Specs: Make it possible to import a module from a module or application by calling module.import(url) Review URL: https://codereview.chromium.org/690793002
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/686243002
-
由 Ojan Vafai 提交于
R=esprehn@chromium.org Review URL: https://codereview.chromium.org/683803006
-
由 Ojan Vafai 提交于
This removes the parsing and the enum. This leaves a bunch of dead code around to fix in a followup. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/689743002
-
由 Eric Seidel 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/678833004
-
由 Eric Seidel 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/692593004
-
由 Scott Violet 提交于
Only fails in release. R=abarth@chromium.org BUG=none Review URL: https://codereview.chromium.org/684123003
-
- 29 10月, 2014 21 次提交
-
-
由 Eric Seidel 提交于
I think longer-term we want to instead fork InjectedScriptSource.js: http://blink.lc/blink/tree/Source/core/inspector/InjectedScriptSource.js since a ton of the "remote object" logic could be shared between Blink and Sky here. Since we're trying to talk exactly Chrome's inspector protocol we should start from the Blink JS as much as possible. That said, this is enough to get the Chrome devtools inspector to talk to sky and have the console handle basic commands! R=abarth@chromium.org Review URL: https://codereview.chromium.org/674823003
-
由 Elliott Sprehn 提交于
These were only used for doing effects in Clank and the shadows around the page when bouncing on the Mac. Now they're dead code. In the future if we decide nine patch is an API we really want we should expose web platform primitives instead of having a special API on layer. R=ojan@chromium.org, abarth@chromium.org Review URL: https://codereview.chromium.org/685983002
-
由 Ojan Vafai 提交于
We don't need to know anymore whether the scroll was programmatic. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/684063002
-
由 Ojan Vafai 提交于
This makes the output much more readable and you can actually see stacktraces. Long-term, we need to stick this output into the result of the previous test instead of having them be printed to stderr. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/686723004
-
由 Elliott Sprehn 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/687893003
-
由 Ojan Vafai 提交于
This is all dead code. No change in behavior. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/678193005
-
由 Elliott Sprehn 提交于
R=ojan@chromium.org Review URL: https://codereview.chromium.org/681293005
-
由 Hixie 提交于
TestExpectations file to skip the ones that fail or crash. It also updates the TestExpectations parser to support URLs pointing to the mojo repo's issue tracker. R=abarth@chromium.org Review URL: https://codereview.chromium.org/685593006
-
由 Ojan Vafai 提交于
No change in behavior. Just deleting dead code. Also removes ScrollAnimatorNone since it's unused. We'll need to bring some of this back, but we'll do that when we get rid of composited scrolling. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/682363002
-
由 Ojan Vafai 提交于
More cleanup of dead code now that we don't have frame-level scrolling. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/687553006
-
由 Elliott Sprehn 提交于
R=ojan@chromium.org Review URL: https://codereview.chromium.org/685003003
-
由 Adam Barth 提交于
This CL adds an "inspect" command to skydb that injects the inspector module into the page and prints some instructions for opening the inspector. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/690433004
-
https://crrev.com/301725/由 James Robinson 提交于
This updates DEPS to reflect changes in 301725 / 90a7c4e3fdeb82a18e17f24e56345b9086a8308b, imports changes, and adds a patch file for our ui/gl/gl_surface modifications. Review URL: https://codereview.chromium.org/669813003
-
由 Ojan Vafai 提交于
No change in behavior. The overflowchanged event was never fired. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/687783003
-
由 Elliott Sprehn 提交于
FrameView doesn't really need to know about the child widgets, which are just Scrollbars now. I also deleted some dead code from Widget and removed FrameWidget since we don't need that abstraction now. R=ojan@chromium.org Review URL: https://codereview.chromium.org/685593005
-
由 Elliott Sprehn 提交于
These were related to the inspector overlays, if we want to do this in the future we should place mojo::Views over the page in the sky debugger so sky itself doesn't need to manage the overlay views. R=ojan@chromium.org Review URL: https://codereview.chromium.org/687003002
-
由 Adam Barth 提交于
Moving the inspector WebSocket proxy server out of the framework directory simplifies the mappings for the HTTP servers. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/687673004
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/682283002
-
由 Elliott Sprehn 提交于
This is part of the old iframe and plugin system, we don't need it. R=ojan@chromium.org Review URL: https://codereview.chromium.org/682263003
-
由 Elliott Sprehn 提交于
This was part of the old plugin system, we don't need it. R=ojan@chromium.org Review URL: https://codereview.chromium.org/686903003
-
由 Ojan Vafai 提交于
We will only have one scrolling path in Sky, so we don't need machinery for mutiple scrolling codepaths. Remove viewportConstrained plumbing. Sky doesn't have viewport constrained elements (no position:fixed). R=esprehn@chromium.org Review URL: https://codereview.chromium.org/661633003
-