- 21 3月, 2015 14 次提交
-
-
由 Eric Seidel 提交于
Also bumped package:sky's version in prep for publishing. R=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/1024243002
-
由 Eric Seidel 提交于
I'm not sure this is the final long-term solution, but works for now. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1022193002
-
由 Adam Barth 提交于
This CL teaches shelldb how to trace SkyShell. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1027903002
-
由 Rafael Weinstein 提交于
BUG= R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1023213003
-
由 Eric Seidel 提交于
TBR=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/1021933004
-
由 Rafael Weinstein 提交于
-
由 Rafael Weinstein 提交于
-
由 Rafael Weinstein 提交于
TBR=abarth BUG= Review URL: https://codereview.chromium.org/1024183002
-
由 Eric Seidel 提交于
https://github.com/domokit/mojo/issues/68 R=abarth@chromium.org Review URL: https://codereview.chromium.org/1026873002
-
由 Eric Seidel 提交于
Sending out a new version to fix the hittesting bug. TBR=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/1025653005
-
由 Eric Seidel 提交于
I also now deploy sky/bin/sky as sky/lib/sky_tool since pub run doesn't really work very well yet. R=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/1026863002
-
由 Rafael Weinstein 提交于
This patch adds an assert that the mount/unmount queues are not subject to concurrent modification and refactors the sync-tracing to avoid the cost of string interpolation if tracing is disabled. BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/1020103004
-
由 Adam Barth 提交于
StockMenu was creating a container for the sole purpose of applying style to PopupMenu. Now we just use a StyleNode. Also, I've reverted the change to make box-sizing default to border-box. It turns out that CL wasn't effective because we didn't use the initialBoxSizing function to initialize box sizing. I've made us use initialBoxSizing but switch the default back to content-box because actually using border-box breaks a bunch of stuff. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1024083003
-
由 Adam Barth 提交于
This CL extracts a Scaffold component from StockApp. The Scaffold component lets you create an "app-like" layout with an action bar, a drawer, etc. R=ojan@chromium.org, rafaelw@chromium.org Review URL: https://codereview.chromium.org/1027813002
-
- 17 3月, 2015 1 次提交
-
-
由 Rafael Weinstein 提交于
This patch adds a new (non-Render) StyleNode which takes two arguments: A (content) node, which it wraps and a Style object. This allows for styles to be applied to Nodes which are constructed elsewhere (e.g. passed in as arguments). R=abarth@chromium.org Review URL: https://codereview.chromium.org/1027653002
-
- 20 3月, 2015 1 次提交
-
-
由 Benjamin Lerman 提交于
Until now, we were saving downloaded file to the temporary directory with a name being the hash of the file content. It means there is a race when the same content is downloaded from 2 different URLs. To fix this, we now create an intermediary directory that is the hash of the URL. Also, because this is only needed for debugging with gdb, and this is inefficient in term of both CPU and storage (we do not know when to delete the temporary directory), we control this with a command line flag. R=ncbray@chromium.org, eseidel@chromium.org BUG=https://github.com/domokit/mojo/issues/61 Review URL: https://codereview.chromium.org/1011333003
-
- 16 3月, 2015 1 次提交
-
-
由 Rafael Weinstein 提交于
This patch adds a base AnimatedComponent from which most components that animated should derive. It takes care of listening & unlistening from the animations during did(Un)mount as well as binding the animated value to a private field and scheduling the component for build. Note that this patch removes the did(Un)mount overridable methods from Component and replaces them with a callback mechanism which is less brittle. BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/1027633003
-
- 20 3月, 2015 1 次提交
-
-
由 Adam Barth 提交于
Instead of running paint requests during microtasks, we run them after updating layout for the current frame. After draining all the paint requests, we then drain whatever commits are available. It's still possible that requestPaint callbacks can dirty style and layout information, so we need to clean that information after servicing the requests. Ideally we'd block these callbacks from dirtying style or layout information. R=ojan@chromium.org Review URL: https://codereview.chromium.org/1027563002
-
- 16 3月, 2015 2 次提交
-
-
由 Rafael Weinstein 提交于
TBR=abarth BUG= Review URL: https://codereview.chromium.org/1021113002
-
由 Rafael Weinstein 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1023063003
-
- 20 3月, 2015 1 次提交
-
-
由 Adam Barth 提交于
This code is unused and it hooks into the DocumentLifecycle in sketchy ways. R=ojan@chromium.org Review URL: https://codereview.chromium.org/1020053002
-
- 16 3月, 2015 1 次提交
-
-
由 Rafael Weinstein 提交于
TBR=hansmuller Review URL: https://codereview.chromium.org/1028473003
-
- 20 3月, 2015 6 次提交
-
-
由 Adam Barth 提交于
This CL adds just enough custom painting to Sky to make sky/examples/painting/circle.sky draw a circle. Over time, we should be able to elaborate this system into something interesting and to make it actually work in a reasonable way. R=ojan@chromium.org Review URL: https://codereview.chromium.org/1017593005
-
由 Hans Muller 提交于
A recent change caused my scrolling app to fail because didMount() was no longer called on my Scrollable subclass at startup time. I haven't been able to sort out how this used to work. This CL is a hack to make it work again. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1019973003
-
由 Adam Barth 提交于
1) Factors InkWell out of Material so that components can use an ink well without needing the shadow/level machinery. 2) Makes the ink effect move at a different velocity once the tap has actually occurred, converging with the spec. We don't have the right speeds yet, but at least we're approaching the right shape. 3) To support (2), added a primaryPointer attribute to GestureEvents to let authors coorelate gesturetapdown events with later gesturetap events. 4) To support (2), modernized SplashAnimation to used AnimatedValue and friends. 5) Added more constants to view-configuration.dart that match Android. I've also removed the cancelling of the ink effect on scroll. The proper way to do that is to notice that someone in the event chain is listening for scrollstart and delay the beginning of the ink effect for some period of time. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1019023003
-
由 Viet-Trung Luu 提交于
(Using the query string from the URL.) R=erg@chromium.org Review URL: https://codereview.chromium.org/1019323002
-
由 Adam Barth 提交于
content-box is crazy banana-pants. R=ojan@chromium.org Review URL: https://codereview.chromium.org/1015253002
-
由 Adam Barth 提交于
This CL is a first step towards custom paint. It introduces a class that can draw a circle into an SkPicture. Future CLs will wire the SkPicture into the render tree and expose this object to script. R=ojan@chromium.org Review URL: https://codereview.chromium.org/1017373003
-
- 16 3月, 2015 1 次提交
-
-
由 Rafael Weinstein 提交于
TBR=abarth BUG= Review URL: https://codereview.chromium.org/1023673004
-
- 19 3月, 2015 1 次提交
-
-
由 Hans Muller 提交于
To define a Component subclass with mixins, a constructor without optional parameters is needed. Added Component.fromArgs() which just delegates to the main constructor. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1017353002
-
- 16 3月, 2015 1 次提交
-
-
由 Rafael Weinstein 提交于
This patch removes the mutable API to event handling (Nodes no longer have a events object with which to add listeners). Instead, a new (non-Render) Node is introduced: EventTarget. This node represents a location in the Effen tree which can handle events as they bubble. Note that this also changes the implementation to use event delegation (one set of listeners at the sky.document level) rather than direct listeners on leaf nodes. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1019633004
-
- 19 3月, 2015 6 次提交
-
-
由 Ojan Vafai 提交于
We were not passing the transformed HitTestLocation when we recursed into child layers, which meant that we wouldn't take transforms correctly into account when hit testing. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1019723002
-
由 Adam Barth 提交于
We're now doing all of the elements of the popup menu entrance animation from the material design spec, but our timing and curves might not be exactly right yet. I haven't started on the exit animation. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1017193004
-
由 Eric Seidel 提交于
This version updates the url it loads from /home to /sky_home and also adds a bit of logging on 404s. TBR=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/1015243002
-
由 Eric Seidel 提交于
This makes it much easier to debug (otherwise silent) 404s of images, etc. R=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/1019103002
-
由 Eric Seidel 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1022613002
-
由 Eric Seidel 提交于
Before this change Sky would hit 404s when trying to load examples from domokit.github.io. I also added a separate sky_home and updated the default url to point to sky_home instead of home. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1016143002
-
- 15 3月, 2015 1 次提交
-
-
由 Rafael Weinstein 提交于
All Effen which can directly create a sky.Node are now derived from RenderNode. In contrast, Component now derives from the (now) base Node class which simply represents a position in the Effen hierarchy. A fair amount of clean-up & refactoring went into this change, simplifying & unifying the "sync" logic between Element & Component as well as making the Component.didMount/didUnmount signals async WRT component building. BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/1009543008
-
- 19 3月, 2015 1 次提交
-
-
由 Adam Barth 提交于
This CL also refactors how animations work, particularly for the Drawer. I've renamed DrawerAnimation to DrawerController and switched it from being an Animation to having an Animation. I've also renamed Animation to AnimatedValue to capture the idea that the class actually presents the value being animated. Finally, I've factored AnimatedValueListener out of Drawer so that it can be used by PopupMenuItem as well. Finally, I've added a scheduleBuild convienence function to Component instead of having to call setState(() {}), which has come up a couple times. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1016093002
-
- 18 3月, 2015 1 次提交
-
-
由 Benjamin Lerman 提交于
R=abarth@chromium.org, eseidel@chromium.org Review URL: https://codereview.chromium.org/1018033002
-