- 07 3月, 2015 9 次提交
-
-
由 Ojan Vafai 提交于
hit-testing needs to walk in backwards order from paint. The previous attempt at reverse sorting by z-index didn't reverse things with the same z-index. Instead, forward sort the same way as we do with paint and then reverse the whole vector. R=abarth@chromium.org, eseidel@chromium.org Review URL: https://codereview.chromium.org/986793002
-
由 Hans Muller 提交于
TBR=sky Review URL: https://codereview.chromium.org/981143005
-
由 Rafael Weinstein 提交于
This can occur, for instance, if a child component runs before a parent component within a single animation frame, and the child does setState() while the parent removes it. The child will already have been entered into the rendering queue. TBR=eseidel BUG= Review URL: https://codereview.chromium.org/983793004
-
由 Rafael Weinstein 提交于
TBR=abarth BUG= Review URL: https://codereview.chromium.org/984983004
-
由 Rafael Weinstein 提交于
Sorry I keep changing my mind about this. My thinking had been since this was computable by just setting a bit and checking it in render(), that it was silly, but I keep finding uses for it and it's annoying to re-implement in each component. TBR=eseidel BUG= Review URL: https://codereview.chromium.org/986753002
-
由 Rafael Weinstein 提交于
TBR=eseidel BUG= Review URL: https://codereview.chromium.org/987833002
-
由 Rafael Weinstein 提交于
This patch changes the timing of the unmount call until after the component is removed (and marked as such) and allows setState to be called after this point. If this happens, setState will still invoke the closer to do any neccesary cleanup, but doesn't schedule the component for render R=eseidel@chromium.org, eseidel BUG= Review URL: https://codereview.chromium.org/985853002
-
由 Eric Seidel 提交于
In production I added an early return. I don't bother to log in production since no one is looking at the log anyway. Unfortunately this currently only fires when using a debug build we should fix our Release build to have a checked-mode option or consider hacks like having all localhost urls enable checked mode, etc. R=ianh@google.com, rafaelw@chromium.org BUG= Review URL: https://codereview.chromium.org/983973005
-
由 Rafael Weinstein 提交于
TBR=eseidel BUG= Review URL: https://codereview.chromium.org/983173003
-
- 06 3月, 2015 23 次提交
-
-
由 Adam Barth 提交于
This provokes a rendering bug in MojoShell but not in SkyShell. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/984793002
-
由 Eric Seidel 提交于
To test: sky/tools/shelldb analyze sky/examples/stocks-fn/stocksapp.dart It prints 600+ warnings about the "native" keyword, and after this change only a couple warnings about missing library names which I don't fully understand. R=abarth@chromium.org Review URL: https://codereview.chromium.org/987613002
-
由 Eric Seidel 提交于
It show 600+ "native" warnings, but those can be ignored for now. R=abarth@chromium.org Review URL: https://codereview.chromium.org/981103002
-
由 Hixie 提交于
fix typo in _syncEvent; make it possible for a component to entirely change the class of its rendering's component R=abarth@chromium.org Review URL: https://codereview.chromium.org/986463003
-
由 Adam Barth 提交于
The AnimationGenerator didn't always generate the |end| value because of floating point rounding. This CL causes it to always generate |end| at the end. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/983893002
-
由 Hixie 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/980043005
-
由 Eric Seidel 提交于
In order to make the Dart Analyzer stop complaining about Event not having a default constructor (and all Event subclasses not having an explicit constructor, thus having an implicit one which calls the default Event() constructor), I made all of Event()'s parameters named and thus optional, but did not update our one sky test which used Event(). The real fix is probably to make the autogenerator smart enough to have FooEvent() call super("foo"), but I was lazy. This at least fixes the tests (and greens the waterfall) for now. TBR=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/988573002
-
由 Eric Seidel 提交于
I also fixed all warnings. :) This is the only error remaining: [error] Native functions can only be declared in the SDK and code that is loaded through native extensions My understanding is that we need to do something similar to: https://codereview.chromium.org/950063002/ in order to work around the 'native' issue. R=abarth@chromium.org Review URL: https://codereview.chromium.org/981733009
-
由 Adam Barth 提交于
That's where it belongs. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/979283002
-
由 Adam Barth 提交于
This CL introduces a flag to control whether fn.dart prints the render duration to the console. By default, the flag is off to avoid log spam. Also, improve the way we intialize _isInCheckedMode to make use of the fact that Dart intializes final fields lazily. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/982073002
-
由 Eric Seidel 提交于
This just makes it easier to run with the correct flags. R=abarth@chromium.org Review URL: https://codereview.chromium.org/982093003
-
由 Adam Barth 提交于
It's awkward to work on fn.dart in the examples directory so this CL moves it to /sky/framework. Also, I've merged the whole library into one file instead of using the |part| mechanism. The whole thing isn't that big. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/987463002
-
由 Adam Barth 提交于
These examples don't work anymore and have been replaced with color-chooser.sky. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/987443002
-
由 Scott Violet 提交于
It's legal for the person embedding to supply null. R=abarth@chromium.org Review URL: https://codereview.chromium.org/979223003
-
由 Adam Barth 提交于
This CL changes the duration of the drawer animation to match the values used by the Android framework. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/976193002
-
由 Adam Barth 提交于
- Removed out-of-date README.md - Moved fling-curve into the animation directory because it's part of the animation behavior of the system. - Moved view-configuration into the theme directory because it's a collection of constants similar in flavor to the colors and the shadows. Eventually we'll want to make the theme configurable and have these all together will hopefully make that easier. - Moved dom-serializer into tests/resources because it is used only by tests. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/980423002
-
由 Adam Barth 提交于
Instead, we can just use the existing animation/curves.dart file in the framework. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/976373003
-
由 Adam Barth 提交于
This CL removes the hard-coded colors and shadows from the fn widgets and replaces them with compile-time constants. The color values are from the material spec: http://www.google.com/design/spec/style/color.html#color-color-palette R=eseidel@chromium.org Review URL: https://codereview.chromium.org/983733003
-
由 Adam Barth 提交于
Instead of duplicating fling-curve.dart in fn, we now share the existing copy in sky/framework. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/976363003
-
由 Adam Barth 提交于
Previously, the two versions of this sample app had separate copies of the stock data. This CL moves the common data to the common data directory so that they can share. Also, I've switched the data files to be |dart| files rather than |sky| files to make them easier to use from fn examples. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/980953002
-
由 Adam Barth 提交于
This CL removes a bunch of examples that don't actually work in the current engine. I've also renamed example-element to custom-element and example-scrollable to scrolling because the word "example" in the name is redundant with the name of the directory. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/980323003
-
由 Adam Barth 提交于
-
由 Adam Barth 提交于
This CL changes how events work in fn. Previously, event listeners were passed in as constructor arguments. Now Nodes hold an |events| object, which contains all the event registrations. When a Component renders, all its |events| are copied onto the Node it produces. When an Element syncs, it walks its |events| and adds them as event listeners on the underlying sky.Element. The net result of this change is increased flexibility in how events are registered. Now components don't need to enumerate all the possible events that they support. Instead, the parent component can listen for whatever events it likes. Also, I've cleaned up the association between DrawerAnimation and Drawer. Now the constructor for Drawer accepts an |animation| object and wires up its internal event handlers itself instead of requiring the constructor to do all the wiring. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/975863003
-
- 05 3月, 2015 3 次提交
-
-
由 Hixie 提交于
Specs: fix typos in style2.md, checkin forgotten builtins.md, add guard feature to runloop.md, rename WeakMap to MapOfWeakReferences, factor out Pair<> Review URL: https://codereview.chromium.org/974313003
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/961873004
-
由 Adam Barth 提交于
This CL adds license blocks and cleans up a number of Dart idioms in fn. Specifically, I've marked several fields as |final| and used Map#putIfAbsent in some appropriate places. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/973613004
-
- 04 3月, 2015 5 次提交
-
-
由 Rafael Weinstein 提交于
-
由 Adam Barth 提交于
R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/970393002
-
由 Adam Barth 提交于
If there is jank, we might not get a frame time that's just after the last frame, which means we'll stop generating animation frames before hitting 1.0 exactly. In this CL, we introduce state to takeWhile to cancel the stream after emitting the 1.0. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/975153002
-
由 Rafael Weinstein 提交于
TBR=abarth Review URL: https://codereview.chromium.org/975203002
-
由 Hixie 提交于
TBR=raf Review URL: https://codereview.chromium.org/974903005
-