- 31 10月, 2014 9 次提交
-
-
由 Ojan Vafai 提交于
Also remove some straggling bits of textareas along the way. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/653993007
-
由 Eric Seidel 提交于
Unfortunate these aren't very useful since we can't actually click on links, nor do navigations work anyway... TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/690133002
-
由 Elliott Sprehn 提交于
-
由 Ojan Vafai 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/696493003
-
由 Eric Seidel 提交于
This makes it possible to change the viewport size which mojo is using. The sky debugger uses this new API to set the viewport to something closer to mobile instead of 800x600 ancient desktop size. :) Still the (800, 600) constant is prevelant throughout mojo (just search for it) and mojo does not seem to fully update when the viewport size changes, so we actually only see 320x600 pixels instead of 320x640 in sky debugger after this change. Mostly this change is about validating that this is the correct way to plumb this information. R=sky@chromium.org Review URL: https://codereview.chromium.org/692693002
-
由 Adam Barth 提交于
As described in //sky/specs/apis.md R=esprehn@chromium.org Review URL: https://codereview.chromium.org/691893002
-
由 Adam Barth 提交于
We only use this data URL parser to pre-cache images loaded from data URLs. It's not clear we need that optimization in this system. If we do want it, we can just call the data URL parser directly. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/691623003
-
由 Adam Barth 提交于
This API is redundant with exposing the main-thread task runner. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/691493004
-
由 Adam Barth 提交于
This CL remove the body of Sky's TraceEvent.h in favor of the version in base. There's still some more of the system to unwind before we can remove all the other boilerplate. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/691663002
-
- 30 10月, 2014 30 次提交
-
-
由 Ojan Vafai 提交于
Yo dawg, I heard you like ternaries. R=abarth@chromium.org Review URL: https://codereview.chromium.org/688233002
-
由 Ojan Vafai 提交于
After this patch, the only instance of WritingMode is in a comment. No change in behavior. TBR=esprehn@chromium.org Review URL: https://codereview.chromium.org/674073005
-
由 Ojan Vafai 提交于
This function always returns false now that we don't have writing modes. TBR=esprehn@chromium.org Remove flipForWritingMode. It's a noop now that we don't have writing modes. Review URL: https://codereview.chromium.org/688223002
-
由 Ojan Vafai 提交于
It's a noop now that we don't have writing modes. TBR=esprehn@chromium.org Review URL: https://codereview.chromium.org/684393002
-
由 Ojan Vafai 提交于
This is a vertical writing mode feature. Sky doesn't support vertical writing mode. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/677843004
-
由 Ojan Vafai 提交于
No change in behavior. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/684383002
-
由 Ojan Vafai 提交于
This just removes a random subset of vertical writing mode bits that I grepped for. There's a ton more to do, but it seems best to do it in chunks. The key things for understanding this patch, isWritingModeRoot is always false and isHorizontalWritingMode is always true. Also, we're never flipped* modes of any kind, so we can undo any flipping. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/688213002
-
由 Adam Barth 提交于
We no longer fetch any of these types from the ResourceFetcher. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/690823002
-
由 Elliott Sprehn 提交于
This removes even more APIs from widget. This also removes some methods that had been broken and made infinitely recursive on FrameView. R=abarth@chromium.org Review URL: https://codereview.chromium.org/684353002
-
由 Adam Barth 提交于
We can just call the base API directly. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/691483005
-
由 Adam Barth 提交于
TBR=esprehn@chromium.org Review URL: https://codereview.chromium.org/685323003
-
由 Elliott Sprehn 提交于
We don't need a lot of the Widget API. I also removed the visibility code which seems to have been broken when we removed FrameView::show and hide(), which looks like it would have broken image loading. Unfortuantely we don't have pixel tests or tests that load images so I can't test this yet. Even so it's a good simplificatin since our system has no concept of hidden widgets. R=abarth@chromium.org, ojan@chromium.org Review URL: https://codereview.chromium.org/691453002
-
由 Adam Barth 提交于
R=esprehn@chromium.org Review URL: https://codereview.chromium.org/687263005
-
由 Elliott Sprehn 提交于
This leaves some uses of FloatingObject*, but it doesn't leave the impl of the class so it's all dead code passing around null pointers. I'll remove that in a future patch. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/689733003
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/687353003
-
由 Eric Seidel 提交于
Also fixed the exception caused by IndexedDB being missing. It was there, just not used by inspector.sky. R=esprehn@chromium.org, abarth@chromium.org Review URL: https://codereview.chromium.org/662523003
-
由 Elliott Sprehn 提交于
R=eseidel@chromium.org, ojan@chromium.org Review URL: https://codereview.chromium.org/678113005
-
由 Adam Barth 提交于
Instead of calling the function constructor to compile script in Sky, we now concatenate strings. This has the advantage of making the line numbers generated in error messages correct but the disadvantage of being a hack. I've filed https://code.google.com/p/v8/issues/detail?id=3624 to request a proper API for this purpose. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/688033003
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/689763003
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/687353002
-
由 Hixie 提交于
Specs: Pass the module last so that if we add other values later we don't shift things in the arguments array Review URL: https://codereview.chromium.org/689763002
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/692563003
-
由 Adam Barth 提交于
R=esprehn@chromium.org Review URL: https://codereview.chromium.org/690803002
-
由 Hixie 提交于
Specs: Make it possible to import a module from a module or application by calling module.import(url) Review URL: https://codereview.chromium.org/690793002
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/686243002
-
由 Ojan Vafai 提交于
R=esprehn@chromium.org Review URL: https://codereview.chromium.org/683803006
-
由 Ojan Vafai 提交于
This removes the parsing and the enum. This leaves a bunch of dead code around to fix in a followup. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/689743002
-
由 Eric Seidel 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/678833004
-
由 Eric Seidel 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/692593004
-
由 Scott Violet 提交于
Only fails in release. R=abarth@chromium.org BUG=none Review URL: https://codereview.chromium.org/684123003
-
- 29 10月, 2014 1 次提交
-
-
由 Eric Seidel 提交于
I think longer-term we want to instead fork InjectedScriptSource.js: http://blink.lc/blink/tree/Source/core/inspector/InjectedScriptSource.js since a ton of the "remote object" logic could be shared between Blink and Sky here. Since we're trying to talk exactly Chrome's inspector protocol we should start from the Blink JS as much as possible. That said, this is enough to get the Chrome devtools inspector to talk to sky and have the console handle basic commands! R=abarth@chromium.org Review URL: https://codereview.chromium.org/674823003
-