- 13 3月, 2015 5 次提交
-
-
由 Adam Barth 提交于
This CL teaches Scrollable how to settle back to a scroll offset of 0.0 after a fling or a scroll. There's still some room for improvement: 1) Some of this logic should be factored out into the scroll curve object. 2) We don't produce the correct animation curves when we fling into the overscroll region because we wait for the fling velocity to reach zero before we start the settling animation. R=ojan@chromium.org, eseidel@chromium.org Review URL: https://codereview.chromium.org/1005753002
-
由 Adam Barth 提交于
When using OverscrollCurve, we continue to scroll beyond the top of the scrollable area but the scroll delta is reduced by 2x. A future CL will add an animation at gesturescrollend to relax back to scroll position 0.0. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1002953003
-
由 Adam Barth 提交于
Intead of hard-coding the notion of bounded scrolling into Scrollable, this CL factors out a ScrollCurve class that applies the bounds. In the future, we'll refine this mechanism to implement overflow scrolling. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1005633002
-
由 Adam Barth 提交于
This class encapsulates the scrolling behavior but not the mechanism for building the visual components. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1006533002
-
由 Adam Barth 提交于
We're using underscores as word separators per Dart style. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/998373002
-
- 12 3月, 2015 13 次提交
-
-
由 Adam Barth 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1000863002
-
由 Viet-Trung Luu 提交于
Also: * Fix consecutive spaces (don't collapse them). * Add support for ^L. Still doesn't work: * Totally blank lines. (I know why, but I don't know why I can't seem to fix it.) R=erg@chromium.org Review URL: https://codereview.chromium.org/997873004
-
由 Zachary Anderson 提交于
This is to better support integration with Dart SDK tools. BUG= R=erg@chromium.org Review URL: https://codereview.chromium.org/998933005
-
由 Viet-Trung Luu 提交于
TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/1004533002
-
由 Viet-Trung Luu 提交于
D'oh. TBR=erg@chromium.org Review URL: https://codereview.chromium.org/998103002
-
由 Viet-Trung Luu 提交于
(Together with an app that echoes stuff from the terminal.) R=erg@chromium.org Review URL: https://codereview.chromium.org/999193002
-
由 Adam Barth 提交于
To accomplish this, I made the following changes: 1) Material is now in charge of drawing the material shadows. 2) In order to mix in the style for the shadow, Element now takes a list of Styles instead of a single style. 3) Update all clients of Element#style to understand that we now have a list. 4) Update components that drawer shadows to have Material do that work instead. a) One exception: FloatingActionButton draws its own shadow because of its crazy clip requirements. We'll probably want to find a better way for FloatingActionButton to clip in the future. I've also added a widgets-fn example to demo the fn material widgets. This CL introduces a bug into Drawer whereby you can get ink splashes everywhere in the drawer. In the future, we'll need to separate out the different material aspects to get non-splashable materials. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1003553002
-
由 Eric Seidel 提交于
We're not actively developing these at the moment. I could also just delete them, not sure if we're ready for that yet. TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/999873002
-
由 Adam Barth 提交于
R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/997073003
-
由 Adam Barth 提交于
We don't yet reset the scroll offset, so sometimes you can't see your search results properly. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1002453003
-
由 Adam Barth 提交于
R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/996213004
-
由 Adam Barth 提交于
Instead of MaterialComponent being a base class, components that want material behavior simply create a MaterialComponent during their render function. This approach gives the component more flexibility as to its structure and gives MaterialComponent more flexibility has to how the components it generates are related to the existing children. Also, I've improved some of the event delegation code. There's no reason to attach event handlers to the root component you emit during |render| because the framework already delegates events from your root component to you. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/983903003
-
由 Eric Seidel 提交于
Unclear what if any of this we will want in the Dart world. R=abarth@chromium.org Review URL: https://codereview.chromium.org/993203002
-
- 11 3月, 2015 10 次提交
-
-
由 Adam Barth 提交于
The search field doesn't do anything, but it's there. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/998803002
-
由 Adam Barth 提交于
Moving these files into sky/framework will make them easier to use from the SDK. Also, this CL also splits up the giant "widgets" library into smaller libraries, one per component. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/993033003
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/987403003
-
https://crrev.com/319330由 Dave Moore 提交于
- New chromium clang rules require explicit external destructors so system/lib added for MessagePipe, DataPipe and SharedBuffer - New chromium clang rules require override and no virtual in declarations, so many files updated. - cc_strip_video patch updated. BUG= R=jamesr@chromium.org Review URL: https://codereview.chromium.org/988693005
-
由 Adam Barth 提交于
The implementation details are in sky/framework/editing. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/983213005
-
由 Adam Barth 提交于
We don't yet have a focus controller, which means once this control becomes focused there's no way for it to lose focus. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/999553002
-
由 Eric Seidel 提交于
http://www.google.com/design/spec/components/lists.html#lists-behavior R=abarth@chromium.org Review URL: https://codereview.chromium.org/993093004
-
由 Eric Seidel 提交于
54px on small screens: http://www.google.com/design/spec/layout/metrics-keylines.html#metrics-keylines-keylines-spacing TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/995133002
-
由 Adam Barth 提交于
This CL factors EditableString out of EditableText and implements more of the InputConnection functions. As a result, EditableText now basically works. This CL also paves the way to make EditableText stateless by using EditableString as its state object. However, there's still a bit more work to do to make that a reality (e.g., factoring out the cursor blink timer and the connection to the keyboard). R=eseidel@chromium.org Review URL: https://codereview.chromium.org/995073002
-
由 Rafael Weinstein 提交于
This patch allows for an initial delay before an animation begins and also adds an Animation class which encapsulates a value which is long-lived, can be explicitly set and also animated from its current value to another value. BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/994143002
-
- 10 3月, 2015 5 次提交
-
-
由 Adam Barth 提交于
This CL introduces a new keyboard service that understands Android IME and starts work on a Input component that interacts with this service to provide an editing control. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/995613002
-
由 Adam Barth 提交于
Sometimes we try to draw a 0x0 picture. We shouldn't bother trying to turn a 0x0 picture into actual pixels. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/984153004
-
由 Rafael Weinstein 提交于
"Render" is misleading. "Build" may not be the best word either, it's closer to what's actually happening. R=ojan@chromium.org TBR=abarth BUG= Review URL: https://codereview.chromium.org/992033002
-
由 Rafael Weinstein 提交于
Ensure that sky Nodes are in the document when didMount() is fired. Refactor FixedHeightScrollable to inspect heights rather than having the passed in BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/994553003
-
由 Adam Barth 提交于
The Dart bindings changed syntax a bit. This CL updates shake-to-reload to match the new names. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/987103003
-
- 07 3月, 2015 7 次提交
-
-
由 Ojan Vafai 提交于
hit-testing needs to walk in backwards order from paint. The previous attempt at reverse sorting by z-index didn't reverse things with the same z-index. Instead, forward sort the same way as we do with paint and then reverse the whole vector. R=abarth@chromium.org, eseidel@chromium.org Review URL: https://codereview.chromium.org/986793002
-
由 Hans Muller 提交于
TBR=sky Review URL: https://codereview.chromium.org/981143005
-
由 Rafael Weinstein 提交于
This can occur, for instance, if a child component runs before a parent component within a single animation frame, and the child does setState() while the parent removes it. The child will already have been entered into the rendering queue. TBR=eseidel BUG= Review URL: https://codereview.chromium.org/983793004
-
由 Rafael Weinstein 提交于
TBR=abarth BUG= Review URL: https://codereview.chromium.org/984983004
-
由 Rafael Weinstein 提交于
Sorry I keep changing my mind about this. My thinking had been since this was computable by just setting a bit and checking it in render(), that it was silly, but I keep finding uses for it and it's annoying to re-implement in each component. TBR=eseidel BUG= Review URL: https://codereview.chromium.org/986753002
-
由 Rafael Weinstein 提交于
TBR=eseidel BUG= Review URL: https://codereview.chromium.org/987833002
-
由 Rafael Weinstein 提交于
This patch changes the timing of the unmount call until after the component is removed (and marked as such) and allows setState to be called after this point. If this happens, setState will still invoke the closer to do any neccesary cleanup, but doesn't schedule the component for render R=eseidel@chromium.org, eseidel BUG= Review URL: https://codereview.chromium.org/985853002
-