- 11 3月, 2015 9 次提交
-
-
由 Adam Barth 提交于
Moving these files into sky/framework will make them easier to use from the SDK. Also, this CL also splits up the giant "widgets" library into smaller libraries, one per component. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/993033003
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/987403003
-
https://crrev.com/319330由 Dave Moore 提交于
- New chromium clang rules require explicit external destructors so system/lib added for MessagePipe, DataPipe and SharedBuffer - New chromium clang rules require override and no virtual in declarations, so many files updated. - cc_strip_video patch updated. BUG= R=jamesr@chromium.org Review URL: https://codereview.chromium.org/988693005
-
由 Adam Barth 提交于
The implementation details are in sky/framework/editing. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/983213005
-
由 Adam Barth 提交于
We don't yet have a focus controller, which means once this control becomes focused there's no way for it to lose focus. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/999553002
-
由 Eric Seidel 提交于
http://www.google.com/design/spec/components/lists.html#lists-behavior R=abarth@chromium.org Review URL: https://codereview.chromium.org/993093004
-
由 Eric Seidel 提交于
54px on small screens: http://www.google.com/design/spec/layout/metrics-keylines.html#metrics-keylines-keylines-spacing TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/995133002
-
由 Adam Barth 提交于
This CL factors EditableString out of EditableText and implements more of the InputConnection functions. As a result, EditableText now basically works. This CL also paves the way to make EditableText stateless by using EditableString as its state object. However, there's still a bit more work to do to make that a reality (e.g., factoring out the cursor blink timer and the connection to the keyboard). R=eseidel@chromium.org Review URL: https://codereview.chromium.org/995073002
-
由 Rafael Weinstein 提交于
This patch allows for an initial delay before an animation begins and also adds an Animation class which encapsulates a value which is long-lived, can be explicitly set and also animated from its current value to another value. BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/994143002
-
- 10 3月, 2015 5 次提交
-
-
由 Adam Barth 提交于
This CL introduces a new keyboard service that understands Android IME and starts work on a Input component that interacts with this service to provide an editing control. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/995613002
-
由 Adam Barth 提交于
Sometimes we try to draw a 0x0 picture. We shouldn't bother trying to turn a 0x0 picture into actual pixels. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/984153004
-
由 Rafael Weinstein 提交于
"Render" is misleading. "Build" may not be the best word either, it's closer to what's actually happening. R=ojan@chromium.org TBR=abarth BUG= Review URL: https://codereview.chromium.org/992033002
-
由 Rafael Weinstein 提交于
Ensure that sky Nodes are in the document when didMount() is fired. Refactor FixedHeightScrollable to inspect heights rather than having the passed in BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/994553003
-
由 Adam Barth 提交于
The Dart bindings changed syntax a bit. This CL updates shake-to-reload to match the new names. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/987103003
-
- 07 3月, 2015 9 次提交
-
-
由 Ojan Vafai 提交于
hit-testing needs to walk in backwards order from paint. The previous attempt at reverse sorting by z-index didn't reverse things with the same z-index. Instead, forward sort the same way as we do with paint and then reverse the whole vector. R=abarth@chromium.org, eseidel@chromium.org Review URL: https://codereview.chromium.org/986793002
-
由 Hans Muller 提交于
TBR=sky Review URL: https://codereview.chromium.org/981143005
-
由 Rafael Weinstein 提交于
This can occur, for instance, if a child component runs before a parent component within a single animation frame, and the child does setState() while the parent removes it. The child will already have been entered into the rendering queue. TBR=eseidel BUG= Review URL: https://codereview.chromium.org/983793004
-
由 Rafael Weinstein 提交于
TBR=abarth BUG= Review URL: https://codereview.chromium.org/984983004
-
由 Rafael Weinstein 提交于
Sorry I keep changing my mind about this. My thinking had been since this was computable by just setting a bit and checking it in render(), that it was silly, but I keep finding uses for it and it's annoying to re-implement in each component. TBR=eseidel BUG= Review URL: https://codereview.chromium.org/986753002
-
由 Rafael Weinstein 提交于
TBR=eseidel BUG= Review URL: https://codereview.chromium.org/987833002
-
由 Rafael Weinstein 提交于
This patch changes the timing of the unmount call until after the component is removed (and marked as such) and allows setState to be called after this point. If this happens, setState will still invoke the closer to do any neccesary cleanup, but doesn't schedule the component for render R=eseidel@chromium.org, eseidel BUG= Review URL: https://codereview.chromium.org/985853002
-
由 Eric Seidel 提交于
In production I added an early return. I don't bother to log in production since no one is looking at the log anyway. Unfortunately this currently only fires when using a debug build we should fix our Release build to have a checked-mode option or consider hacks like having all localhost urls enable checked mode, etc. R=ianh@google.com, rafaelw@chromium.org BUG= Review URL: https://codereview.chromium.org/983973005
-
由 Rafael Weinstein 提交于
TBR=eseidel BUG= Review URL: https://codereview.chromium.org/983173003
-
- 06 3月, 2015 17 次提交
-
-
由 Adam Barth 提交于
This provokes a rendering bug in MojoShell but not in SkyShell. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/984793002
-
由 Eric Seidel 提交于
To test: sky/tools/shelldb analyze sky/examples/stocks-fn/stocksapp.dart It prints 600+ warnings about the "native" keyword, and after this change only a couple warnings about missing library names which I don't fully understand. R=abarth@chromium.org Review URL: https://codereview.chromium.org/987613002
-
由 Eric Seidel 提交于
It show 600+ "native" warnings, but those can be ignored for now. R=abarth@chromium.org Review URL: https://codereview.chromium.org/981103002
-
由 Hixie 提交于
fix typo in _syncEvent; make it possible for a component to entirely change the class of its rendering's component R=abarth@chromium.org Review URL: https://codereview.chromium.org/986463003
-
由 Adam Barth 提交于
The AnimationGenerator didn't always generate the |end| value because of floating point rounding. This CL causes it to always generate |end| at the end. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/983893002
-
由 Hixie 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/980043005
-
由 Eric Seidel 提交于
In order to make the Dart Analyzer stop complaining about Event not having a default constructor (and all Event subclasses not having an explicit constructor, thus having an implicit one which calls the default Event() constructor), I made all of Event()'s parameters named and thus optional, but did not update our one sky test which used Event(). The real fix is probably to make the autogenerator smart enough to have FooEvent() call super("foo"), but I was lazy. This at least fixes the tests (and greens the waterfall) for now. TBR=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/988573002
-
由 Eric Seidel 提交于
I also fixed all warnings. :) This is the only error remaining: [error] Native functions can only be declared in the SDK and code that is loaded through native extensions My understanding is that we need to do something similar to: https://codereview.chromium.org/950063002/ in order to work around the 'native' issue. R=abarth@chromium.org Review URL: https://codereview.chromium.org/981733009
-
由 Adam Barth 提交于
That's where it belongs. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/979283002
-
由 Adam Barth 提交于
This CL introduces a flag to control whether fn.dart prints the render duration to the console. By default, the flag is off to avoid log spam. Also, improve the way we intialize _isInCheckedMode to make use of the fact that Dart intializes final fields lazily. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/982073002
-
由 Eric Seidel 提交于
This just makes it easier to run with the correct flags. R=abarth@chromium.org Review URL: https://codereview.chromium.org/982093003
-
由 Adam Barth 提交于
It's awkward to work on fn.dart in the examples directory so this CL moves it to /sky/framework. Also, I've merged the whole library into one file instead of using the |part| mechanism. The whole thing isn't that big. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/987463002
-
由 Adam Barth 提交于
These examples don't work anymore and have been replaced with color-chooser.sky. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/987443002
-
由 Scott Violet 提交于
It's legal for the person embedding to supply null. R=abarth@chromium.org Review URL: https://codereview.chromium.org/979223003
-
由 Adam Barth 提交于
This CL changes the duration of the drawer animation to match the values used by the Android framework. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/976193002
-
由 Adam Barth 提交于
- Removed out-of-date README.md - Moved fling-curve into the animation directory because it's part of the animation behavior of the system. - Moved view-configuration into the theme directory because it's a collection of constants similar in flavor to the colors and the shadows. Eventually we'll want to make the theme configurable and have these all together will hopefully make that easier. - Moved dom-serializer into tests/resources because it is used only by tests. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/980423002
-
由 Adam Barth 提交于
Instead, we can just use the existing animation/curves.dart file in the framework. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/976373003
-