1. 09 3月, 2021 1 次提交
    • C
      Correct setup-related typos (#24846) · 2441c476
      Chris Bracken 提交于
      Corrects uses of setup as a verb to 'set up', leaves noun/noun-phrase
      forms of setup as 'setup'. Also settles on 'teardown' as opposed to
      tear-down for consistency across the codebase.
      
      A few other minor comment/wording corrections.
      2441c476
  2. 04 12月, 2020 1 次提交
  3. 03 12月, 2020 1 次提交
  4. 02 12月, 2020 1 次提交
    • G
      Fix race condition in key event handling on Android (#22658) · 40fa345c
      Greg Spencer 提交于
      This fixes a problem in Android key event handling where, because I was only using a single bool to indicate that we were re-dispatching, there was a race condition when multiple keys were pending (sent to the framework, awaiting responses).
      
      This fixes that by switching to a mechanism that uses the event itself to tell if it was redispatched.
      
      In doing this, I realized that because key events can come from either the dispatchEvent call, or through the InputConnectionAdaptor, I needed to handle both routes properly so that the events would all be handled, and all go through the same mechanism on the framework side.
      40fa345c
  5. 20 11月, 2020 1 次提交
  6. 07 11月, 2020 1 次提交
    • G
      Use dispatchKeyEvent, and handle keys sent to InputConnection.sendKeyEvent on Android (#22340) · 13a624ac
      Greg Spencer 提交于
      This (mostly) re-lands #21163, which was reverted in #22321
      
      This switches from using onKeyDown to using dispatchKeyEvent on Android so that keys can be intercepted handled by the framework and not continue to be dispatched to other controls.
      
      It also now intercepts key events sent to InputConnection.sendKeyEvent, as some IMEs do (e.g. the Hacker's Keyboard), and sends them to Flutter.
      
      This fixes the problem where (for example) pressing TAB on a hardware keyboard sends the tab to both the text field and to the focus traversal system.
      
      Note that we still can't intercept all keystrokes given to a soft keyboard, only those which the soft keyboard decides to send to InputConnection.sendKeyEvent, and system keys (like the back button) are only received if the IME doesn't eat them.
      13a624ac
  7. 06 11月, 2020 1 次提交
  8. 05 11月, 2020 1 次提交
    • G
      Reland: Use dispatchKeyEventPreIme, and handle keys sent to... · 7a8057bd
      Greg Spencer 提交于
      Reland: Use dispatchKeyEventPreIme, and handle keys sent to InputConnection.sendKeyEvent on Android (#22304)
      
      This re-lands #21163, which was reverted in #22004
      
      Now that flutter/flutter#67359 has landed, this change will no longer cause spaces (and other shortcuts) to be ignored in text fields if there is no action associated with the intent, even if there is a shortcut key mapping to an intent.
      
      It also no longer causes web test failures (as far as I can tell without submitting it: the same tests don't fail locally).
      
      Here's the original PR description:
      
      This switches from using dispatchKeyEvent to using dispatchKeyEventPreIme so that keys can be intercepted before they reach the IME and be handled by the framework.
      
      It also now intercepts key events sent to InputConnection.sendKeyEvent, as some IMEs do (e.g. the Hacker's Keyboard), and sends the to Flutter before sending them to the IME (which it now only does if they are not handled by the framework).
      
      This fixes the problem where pressing TAB on a hardware keyboard sends the tab to both the text field and to the focus traversal system.
      
      Note that we still can't intercept all keystrokes given to a soft keyboard, only those which the soft keyboard decides to send to InputConnection.sendKeyEvent.
      7a8057bd
  9. 30 10月, 2020 1 次提交
  10. 21 10月, 2020 2 次提交
    • G
      Revert "Reland: Use dispatchKeyEventPreIme, and handle keys sent to... · 3658bd7e
      Greg Spencer 提交于
      Revert "Reland: Use dispatchKeyEventPreIme, and handle keys sent to InputConnection.sendKeyEvent on Android (#21979)" (#22004)
      
      This reverts commit 3cd70f2c because it causes some failures in web tests.
      3658bd7e
    • G
      Reland: Use dispatchKeyEventPreIme, and handle keys sent to... · 3cd70f2c
      Greg Spencer 提交于
      Reland: Use dispatchKeyEventPreIme, and handle keys sent to InputConnection.sendKeyEvent on Android (#21979)
      
      This re-lands #21163, which was reverted in #21513
      
      Now that flutter/flutter#67359 has landed, this change will no longer cause spaces (and other shortcuts) to be ignored in text fields if there is no action associated with the intent, even if there is a shortcut key mapping to an intent.
      
      Here's the original PR description:
      
      This switches from using dispatchKeyEvent to using dispatchKeyEventPreIme so that keys can be intercepted before they reach the IME and be handled by the framework.
      
      It also now intercepts key events sent to InputConnection.sendKeyEvent, as some IMEs do (e.g. the Hacker's Keyboard), and sends the to Flutter before sending them to the IME (which it now only does if they are not handled by the framework).
      
      This fixes the problem where pressing TAB on a hardware keyboard sends the tab to both the text field and to the focus traversal system.
      
      Note that we still can't intercept all keystrokes given to a soft keyboard, only those which the soft keyboard decides to send to InputConnection.sendKeyEvent.
      3cd70f2c
  11. 15 10月, 2020 1 次提交
  12. 09 10月, 2020 1 次提交
  13. 01 10月, 2020 1 次提交
  14. 30 9月, 2020 1 次提交
    • G
      Use dispatchKeyEventPreIme, and handle keys sent to... · 539034ae
      Greg Spencer 提交于
      Use dispatchKeyEventPreIme, and handle keys sent to InputConnection.sendKeyEvent on Android (#21163)
      
      This switches from using dispatchKeyEvent to using dispatchKeyEventPreIme so that keys can be intercepted before they reach the IME and be handled by the framework.
      
      It also now intercepts key events sent to InputConnection.sendKeyEvent, as some IMEs do (e.g. the Hacker's Keyboard), and sends the to Flutter before sending them to the IME (which it now only does if they are not handled by the framework).
      
      This fixes the problem where pressing TAB on a hardware keyboard sends the tab to both the text field and to the focus traversal system.
      
      Note that we still can't intercept all keystrokes given to a soft keyboard, only those which the soft keyboard decides to send to InputConnection.sendKeyEvent.
      539034ae
  15. 24 9月, 2020 1 次提交
  16. 23 9月, 2020 1 次提交
  17. 22 9月, 2020 1 次提交
  18. 02 9月, 2020 1 次提交
  19. 29 8月, 2020 1 次提交
    • G
      Reland: Implement delayed event synthesis key event handling for Android (#20736) · 88fd13fc
      Greg Spencer 提交于
      This re-lands the key event synthesis implementation for Android (Original PR: #19024, Revert PR: #19956). The only difference is sending the synthesized key events to the root view instead of the current view.
      
      Without sending it to the root view, the system doesn't have any chance of handling keys like the back button. The event will still not be sent to the framework twice, since we turn off event propagation while re-dispatching the event.
      88fd13fc
  20. 20 8月, 2020 1 次提交
  21. 31 7月, 2020 1 次提交
  22. 23 7月, 2020 1 次提交
  23. 18 7月, 2020 1 次提交
  24. 15 7月, 2020 1 次提交
  25. 16 6月, 2020 1 次提交
  26. 13 6月, 2020 2 次提交
  27. 11 6月, 2020 1 次提交
  28. 02 6月, 2020 1 次提交
  29. 09 5月, 2020 1 次提交
  30. 23 4月, 2020 1 次提交
  31. 22 4月, 2020 1 次提交
  32. 18 4月, 2020 1 次提交
  33. 16 4月, 2020 1 次提交
  34. 14 3月, 2020 2 次提交
  35. 08 2月, 2020 1 次提交
    • M
      Apply Google Java format (#16501) · 077918dc
      Michael Klimushyn 提交于
      This shouldn't result in any logical changes. I've done a quick smoke
      test by building a local Android engine and running Flutter gallery, no
      compile errors or other obvious issues.
      
      Applied by running `/ci/format.sh | patch -p0` with the altered script
      added in flutter/engine#16500. I did locally modify the script slightly
      further so it would run against all Java files in the repo instead of
      just modified ones.
      077918dc
  36. 01 2月, 2020 1 次提交
    • M
      Deprecated FlutterView v1 points to FlutterView v2 (#16304) · 0816c040
      Michael Klimushyn 提交于
      FlutterView#enableTransparentBackground has been deprecated for some
      time now since it breaks a11y highlighting in most cases. When the
      warning was first added there was no known workaround, but now the v2
      embedding is in stable and ready to support this usecase. Update the
      warning to point to the v2 embedding.
      0816c040
  37. 15 10月, 2019 1 次提交