- 18 2月, 2015 12 次提交
-
-
由 Adam Barth 提交于
R=esprehn@chromium.org Review URL: https://codereview.chromium.org/933843004
-
由 Adam Barth 提交于
Now documents can have many element children, all created equal. R=esprehn@chromium.org, ojan@chromium.org Review URL: https://codereview.chromium.org/928393003
-
由 Eric Seidel 提交于
We shouldn't need pendingScripts in ScriptRunner since we should never be trying to run scripts when we're not ready to run them. However this wasn't completely true in the case of imports there was code to have us break before any start tag after an <import> was seen, but it was subtly wrong in that it it would include the start-tag it was trying to break before in the chunk it sent to the main thread. This didn't run out to be the problem I was facing, but I fixed it anyway. The problem which was actually preventing me from removing pendingScripts was adding a check inside didRecieveParsedChunk... to check if imports were pending and add the chunk to the list of pending chunks. I also renamed m_speculations to m_pendingChunks since these chunks are never speculative anymore. We can't test the off-by-one import-breaking code with our current system, but it would be trivial to test with a self-closing custom element if/when we ever add custom elements back to the system. R=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/934083002
-
由 Hixie 提交于
Specs: update the run loop and timer stuff to use the new model with task filters, priorities, and so on (the code in this checkin has not been syntax checked) Review URL: https://codereview.chromium.org/931333002
-
由 Eric Seidel 提交于
Because we dump dart errors to LOG(ERROR) (stderr) instead of console.log / stdout, tests with dart errors just "pass" and we don't notice they're not running. This was the case with canvas-rounded-corners.sky. I don't think this test actually passes yet, despite it claiming to, but I at least have made it run and not crash. Required me commenting out a ton of CanvasRenderingContext2D, but that's fine, it wasn't actually working and it's better to have it be compiling valid dart. R=abarth@chromium.org, ojan@chromium.org BUG= Review URL: https://codereview.chromium.org/936563002
-
由 Eric Seidel 提交于
This actually makes [Named] work, previously it was generating invalid dart. TBR=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/931273002
-
由 Eric Seidel 提交于
This doesn't yet support having both named and optional arguments, but once I have an example of that it should be trivial to add. I also cleaned up the generation a little so the generated dart file looks nicer. :) R=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/923093003
-
由 Adam Barth 提交于
We appear to be missing a null check here as well. R=ojan@chromium.org, esprehn@chromium.org Review URL: https://codereview.chromium.org/937443002
-
由 Przemyslaw Pietrzkiewicz 提交于
This patch cuts the last dependencies of sky on /net by hardcoding the ERR_ABORTED status code. https://codereview.chromium.org/933973002/ is a proposed solution to avoid the hardcoding. BUG=456130 R=abarth@chromium.org Review URL: https://codereview.chromium.org/935633003
-
由 Adam Barth 提交于
We just needed to throw the proper exception when handed null for a non-nullable argument. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/934863002
-
由 Przemyslaw Pietrzkiewicz 提交于
Sky Inspector is currently not working. This patch removes the Inspector server, which is based on net/http_server, to unblock dropping /net in Mojo. BUG=456130 R=abarth@chromium.org Review URL: https://codereview.chromium.org/931873002
-
由 Przemyslaw Pietrzkiewicz 提交于
This patch makes the skydb debugger use the Mojo http_server app instead of the /net http_server. BUG=456128 R=eseidel@chromium.org, qsr@chromium.org Review URL: https://codereview.chromium.org/930903002
-
- 15 2月, 2015 1 次提交
-
-
由 Adam Barth 提交于
Before this if a dart import 404s, we crash. This makes some minor improvements in our logging for better diagnosis of future errors. R=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/926753002
-
- 14 2月, 2015 18 次提交
-
-
由 Adam Barth 提交于
These still don't match the specs exactly, but they're much closer. R=ojan@chromium.org, eseidel@chromium.org Review URL: https://codereview.chromium.org/924203002
-
由 Ojan Vafai 提交于
We no longer paint background and foreground separately, so we don't need to hit test them separately. R=abarth@chromium.org Review URL: https://codereview.chromium.org/924273003
-
由 Ojan Vafai 提交于
Background and foreground on a layer can't be hit indepdently anymore, so merge them into a single hitTestContents call. R=abarth@chromium.org Review URL: https://codereview.chromium.org/924273002
-
由 Ojan Vafai 提交于
I'm not 100% what this was for, but looking at Blink, it appears that HitTestChildBlockBackground being different from HitTestBlockBackground had something to do with multi-column/regions, which we don't have. I believe this patch doesn't change any behavior. Also added to the elementFromPoint test in order to get more test coverage of the hitTesting code. R=abarth@chromium.org Review URL: https://codereview.chromium.org/924263002
-
由 Hixie 提交于
Specs: change how .where() works so that it won't leak once its own listeners are removed (e.g. by a chained .until()) R=abarth@chromium.org Review URL: https://codereview.chromium.org/923163003
-
由 Hixie 提交于
Specs: (reverts part of recent checkin) Make appendChild, prependChild, and setChild not return the child, since that can improve perf (especially if they're actually implemented natively) Review URL: https://codereview.chromium.org/924163004
-
由 Hixie 提交于
Specs: Make appendChild, prependChild, and setChild return the child; make Dispatcher's unlisten() function a mote more efficient (in theory; untested) Review URL: https://codereview.chromium.org/923023005
-
由 Adam Barth 提交于
Turns out you need a base URI to make the unit testing framework behave in a sane way. R=esprehn@chromium.org, ojan@chromium.org Review URL: https://codereview.chromium.org/926163002
-
由 Ojan Vafai 提交于
Prunes a bunch of dead code from HitTestResult and stops special-casing links for creating hand cursors. This code already isn't working today anyways, so in practice, there's no change in behavior. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/925933004
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/925923004
-
由 Ojan Vafai 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/925903005
-
由 Hixie 提交于
Specs: update elements.md to define List-based APIs in terms of Node-based APIs, and finish dartification of modules.md (and do Document->Root there) Review URL: https://codereview.chromium.org/926733002
-
由 Adam Barth 提交于
R=eseidel@chromium.org, ojan@chromium.org Review URL: https://codereview.chromium.org/921123002
-
由 Adam Barth 提交于
This CL ports sky/framework/shell.sky to Dart and makes event-sender.sky. I've also removed a number of not-that-interesting tests for the JS Mojo bindings. R=eseidel@chromium.org, rafaelw@chromium.org Review URL: https://codereview.chromium.org/922123002
-
由 Adam Barth 提交于
This CL removes a number of tests that we don't plan to port to Dart: 1) custom-elements. We're going to use a different mechanism for custom elements. We'll need to write a new set of tests as we implement it. 2) inspector. These are tests of the JS inspector backend, which we don't plan to use. 3) js. This is a test of a JavaScript feature. 4) mocha. These are tests of the JavaScript testing framework we were using. 5) mutation-observer. We're keeping the C++ code for mutation observers, but it's unclear how we want to expose this in the platform. 6) resources. These are JavaScript-based testing frameworks. R=eseidel@chromium.org, ojan@chromium.org Review URL: https://codereview.chromium.org/920343002
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/922113003
-
由 Hixie 提交于
Specs: Drop @nonnull from dom.md, drop ChildNode from dom.md, drop TreeRoot from dom.md, other minor idomatic changes Review URL: https://codereview.chromium.org/927613002
-
由 Przemyslaw Pietrzkiewicz 提交于
It seems not to be used for anything. R=abarth@chromium.org Review URL: https://codereview.chromium.org/921633006
-
- 13 2月, 2015 9 次提交
-
-
由 Adam Barth 提交于
This CL adds the ability to initialize the Dart Application class with a shell proxy (rather than with a MojoHandle). This change lets Sky use the Dart bindings for Mojo. This CL was reviewed on the SkyDart branch in https://codereview.chromium.org/919883002/ R=zra@google.com, zra@chromium.org Review URL: https://codereview.chromium.org/922083002
-
由 Adam Barth 提交于
We don't use V8 anymore. There's no reason to link it in. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/918263003
-
由 Adam Barth 提交于
There's only one bindings system now. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/915293003
-
由 Adam Barth 提交于
We don't build this code anymore. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/922053002
-
由 Adam Barth 提交于
This CL flips the switch to make Sky use Dart. TBR=eseidel@chromium.org BUG=454613 Review URL: https://codereview.chromium.org/922893002
-
由 Eric Seidel 提交于
This is all the bindings-level dart code we had to write to enable Dart in Sky. We wrote this over the last 2 weeks in: https://github.com/eseidel/skydart R=abarth@chromium.org, jamesr@chromium.org BUG=454613 Review URL: https://codereview.chromium.org/918333002
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/919693007
-
由 Adam Barth 提交于
Unfortunately, using --origin on Linux is slow and too painful to use at the moment. We should work on fixing that, but currently many of us have this in our local working copy anyway. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/922823002
-
由 Adam Barth 提交于
This CL adds the DartController and associated classes. These classes let you load and execute dart code. R=rafaelw@chromium.org BUG=454613 Review URL: https://codereview.chromium.org/921903002
-