Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

This rolls includes the following changes:

be6309690f (HEAD) Analyze pkg/dart2js_tools on the bots.
6f9073bb9d Wait for Analysis Server errors only while waiting for a response.
5d4e85ba3d Allow `x == null` to be a constant value whenever x is const.
7c77ed04f4 Move deobfuscation tools to the SDK repo
666c8c1a89 Fix @visibleForTemplate tests on Windows.
6fc1dd4480 analyzer_plugin no implicit-casts.
29401573d5 Get documentation comments before metadata as well.
3d0a663518 [vm/frontend-server] Fix frontend_server so that it can be tested.

* fix analyzer hint

* use --enable-asserts instead of --checked

* Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9

This rolls includes the following changes :

1be785ae2d Clean up some dead code
7b9fb893d2 [vm] Add a service method for 'invoke' as the dual to 'eval'.
099f1504fa Mention -O flag in CHANGELOG
79f69abace [vm/compiler] breakage fix: add missing break
96a1e9985f Fix the pkg bot
7818db20a7 Add analysis hint for invalid use of @visibleForTemplate code.
71d96019d1 [vm/compiler] Introduce 64-bit NEGATE - all archs.
5013a2ccc4 Remove spurious line.
ef2f777625 Mark some analyzer tests as being flaky
cf560fe17b Fix a couple of the tests failing on the analyzer with fasta parser bot
63c11693e6 [gardening] Fix language_2/type_variable_promotion_test.
d0f28884ff [VM] Fix expression evaluation implementation: Never register temporary/unused classes with the system.
e2a1807fc2 [gardening] Update status for io/compile_all_test in PRODUCT AOT mode
f7ff739448 Insert date of 2.0.0 release in Changelog
bcabad6014 [vm] Fix SIMARM64 build on Windows.
af02ccae83 [infra] Fix filesets for new vm-kernel-precomp builders
8e2f28e264 Update homebrew to drop the @2 tab and fix for 2.0
ba119d7292 [VM] Remove "$compiler == precompiler" sections from language_2_precompiler.status
f3a2c0e28f [release] Prepare changelog for 2.1.0-dev.0.0
88cba7d860 [vm/kernel/bytecode] Fix arguments descriptor for List._fromLiteral call in bytecode
bd45ec0c4b [vm, gc] Refactor PageSpace::CollectGarbage to ensure the safepoint and task count remain well-scoped even with early exits.
8195fd8c64 Repair dart2js/string_interpolation_test
a0b335ac6c Try no implicit casts in pkg/analyzer_cli.
3d25d3761b Update pub - leave packages directories alone
327db5e9ab [vm] Fix kernel_isolate use_field_guard flag for kbc
a1ca88f554 Resolve invocation arguments to parameters.

* Address source format error.

Auto-roller completed checks. Merging.

It includes the following changes:
eab492385c Updates for passing / failing analysis_server tests.
235ccc9374 Remove --checked from dart --help
77d6758afb Attempt to fix failing tests on the windows bots
a2b052939e [vm] Add timeline events for GC phases.
9e9adcef57 [observatory] Include observatory main.dart.js.map with debug build.
7eda513405 [infra] Add new vm-kernel-precomp builders to the test matrix
83aa463fac Enable a few more server tests under CFE
75f92ac8fe Point old super mixin informal spec to canonical copy
5dd2aca7fe [kernel] Fix non-deterministic output generation
85d85246ad [vm/kernel/bytecode] Revise access to instance fields in bytecode
af45552aa5 [gen_snapshot] Remove --print_dependencies and --dependencies_only.
34f17b2973 [VM] Add missing 6-type-test to subtypecache search in simdbc (it has it in 2 places)
19a90c2c8b More CFE tests for server
6879e4cedc Add completion contributor tests for CFE
6137511849 Add more CFE tests for server
1cd9175e3e Fix mixed dartdoc processing
575a8f8381 [VM] Extend subtype-test mechanism with support for generic methods
278d962a7f [vm/precomp] Update status files for Dart 1 AOT.
35d26c9b14 Always use relative paths to import from within the front end
84d8887d3f Fixes a minor typo in the documentation of the StreamTransformer class.
1b6992b915 [dart2js] Mark failing unit tests as RuntimeError to fix CQ (#34095)
9b5a4241de [vm, gc] Don't rebuild the remembered set during marking.
c712470bb9 dart2js status bingo
dac348c8c9 [observatory] Only run field guards test if it is enabled in the vm.
4d156f9fb0 [dart2js] Fix function_type GVN bug
4196c0e2f5 Fix dart2js/sourcemaps/minified_names_test
8c059e7a34 Update language_2 status file for kernel bytecode passing tests.
ac69a3041a [vm, gc] Rename store_buffer.h as pointer_block.h as it also defines the mark stack blocks.
9510738c62 dart2js status update
6bdf3b7ed6 [observatory] Fix _guardLength serialization to output a string, rather than an int.
1f4449658d Refactor dartdoc parsing
0fbe9d3a95 [dart2js] Dynamically generated tear-off constructors should have names
cb4f5b3a3a Resynthesize nameOffset for properties/parameters.
69f216d4f1 Fix mock SDK and Flutter to pass some Flutter tests.
c619413fef Fix for unawaited future in assists.
66693ea6e2 [VM runtime] For now, do not use field guards when using kernel bytecode.
31765bf56f Clean up some hints in server code
c30af508a4 Store import prefix offset into metadata and resynthesize.
c439ebead0 [vm, gc] Update old allocation stats when scanning instead of pushing.
d933d4aa39 Update tests for const constructors in subclasses of mixin applications
b570ea1ff1 status update to make dart2js run function_type/ tests
9767af2550 [vm/precomp] Support @pragma for fields and remove associated entry-point entries.
80e08e0913 Use 'useCFE' flag to turn on CFE in AnalysisDriver.
98cf15cf5b Remove unnecessary commentToken parameter
89fd468b89 remove unused DocumentationCommentToken.references field
49b18446c2 Refactor dartdoc parsing
bc8a8386af Fix tests that reference the flutter package
de408202a5 [vm/precomp] Take 4 for procedure- and class-entrypoints.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

This reverts commit f20c58f6.

dart-lang/sdk@17b54c7 Improve error detection in search code
dart-lang/sdk@0ac1178 Initial stress test for code completion
dart-lang/sdk@e0f6fdf Refactor testing:TestConfiguration to use smith:Configuration by inclusion.
dart-lang/sdk@95d1ebd Fix one cause of timeouts in tests
dart-lang/sdk@72b2542 Mark tests with Dart 1 constants in const context failing in all configs.
dart-lang/sdk@42b02e0 Add more test steps to the analyzer --use-cfe bots.
dart-lang/sdk@8bec83b Add the analyzer-use-cfe-linux bot to the commit queue.
dart-lang/sdk@315216e [dart2js] Avoid collision with getInterceptor.
dart-lang/sdk@f02d4d4 Fix bad merge
dart-lang/sdk@1a83245 Triage language tests for void
dart-lang/sdk@35a982b [VM kernel] Add missing type parameter finalization in type reader.
dart-lang/sdk@09a8660 fix typo
dart-lang/sdk@8cbbd7a [VM interpreter] Use write barrier in implicit setter.
dart-lang/sdk@91caf82 Do self-interceptor optimization on a per-use basis
dart-lang/sdk@8df84c0 Store resolution for out of range integer literals.
dart-lang/sdk@bfa890d [vm/compiler] Various 64-bit operator improvements.
dart-lang/sdk@92a7094 Fix three missing return warnings.
dart-lang/sdk@1babc13 [vm/kernel/bytecode] Report compile-time errors from constant evaluation while generating bytecode
dart-lang/sdk@8114ecb Fix tests after fixing constant fields with CFE.
dart-lang/sdk@85edb76 Fix field constants verifying with CFE.
dart-lang/sdk@8692936 Verify constants using Analyzer.
dart-lang/sdk@b83072c Clean up use of callFailingTest
dart-lang/sdk@8d3d82a [vm/kernel] Untangle the spaghetti-code in BuildGraphOfFunction and fix bugs.
dart-lang/sdk@368bcc4 Add parse dartdoc tests for fasta parser
dart-lang/sdk@cda3659 [fasta] Handle annotations on formals of typedefs
dart-lang/sdk@46743f3 Remove $runtime == drt sections and uses of drt from status files.
dart-lang/sdk@637e55d [kernel] Add VariableDeclarations to represent formals of Typedefs
dart-lang/sdk@4c455e7 [VM] During hot-reload check if .packages was modified, tell IKG to re-load it if so
dart-lang/sdk@5a259ac De-flake the analysis server integration tests.
dart-lang/sdk@380696f Set element/type for some resynthesized expressions.
dart-lang/sdk@4ab8408 [vm/kernel/bytecode] Support partial tear-off instantiation constants in bytecode generator and bytecode reader
dart-lang/sdk@62a2752 Translate ConstructorElement(s) of parameterized InterfaceType(s) to ConstructorMember(s).
dart-lang/sdk@a19a468 Revise CHANGELOG.
dart-lang/sdk@91c6130 CHANGELOG copyedits
dart-lang/sdk@5f4c617 Fix typo in CHANGELOG.md
dart-lang/sdk@5313553 Run the analysis server 'analysis-server-cold' with --use-cfe.
dart-lang/sdk@758e5ea Use '=' for default values of named parameters.
dart-lang/sdk@f625490 Attempt to fix failures on the windows bot
dart-lang/sdk@bbfc465 Cleaned up a few entries in the CHANGELOG
dart-lang/sdk@e402732 Improve documentation of the -O flag

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

* b04def964c [VM interpreter] Save previous argdesc_ and pp_ on reentry, restore on exit.
92ae73b6d8 Fork the remaining subclasses of AbstractAnalysisClass
884536dfaa [vm/kernel/bytecode] Fix bytecode generation for async closures
ae001707b7 [vm/kernel/bytecode] Do not call getter for a static field initialized with double literal
87f753dbd3 Replace some declarations of element with declaredElement
2be2cf2061 Bump analyzer_cli protobuf dep
206f955c43 [vm/compiler] Non-speculative ARM64 long division/remainder.
4bb3fb6cae Don't rewrite error Severity for special cases of front-end testing.
d6189709b8 Issue 33506. Rewrite MethodInvocation into InstanceCreationExpression.
26e087e66b Don't save Tokens in Judgments
4c75b49b3f Clear Token in field builder after use
ea0468dff4 Fork more server tests to run under CFE
841f62715a Clean up some hints from the analyzer code base
c5f933fdf7 [vm/lib] String._identityHashCode should be the same as String.get:hashCode
4fa139b4b8 [vm/compiler] Rework how logical expressions are compiled to IL.
9bb39ccabc [infra] Update checked in SDKs to 2.0.0-dev.69.5
2580bf87ae Fix invalid assert that slipped by in ac8fdb5a
1c2043e3a6 Update service test more to not be different in sync async mode
ac8fdb5a58 Add :controller_stream and call _asyncStarListenHelper
2e98da68f9 Call _asyncStarMoveNextHelper in kernel
cb5513fbc9 Make a single clear CHANGELOG entry for all 2.0.0 changes.
d3df394870 Add -O flag and documentation.
3f1bb85f17 [vm/kernel/bytecode] Do not generate InstantiateType for instantiated generic function types
c5ac5c0a2c [vm/kernel/bytecode] Fix serialization of closures with type arguments
ff0327be67 [vm] Streamline passing of ICData through compilation pipeline
012766901e Status file two flaky pkg bot tests.
6a6e7abfc6 Clean up some warnings in the server code base
e578b60899 Bump the analysis driver cache seed.
f169ebf418 Fork several server tests to run under CFE
b1c9b67b68 Add initial content for the analyzer --use-cfe builders.
373ed6b47f Create a LineInfo when resynthesizing a CompilationUnitElement
2a23bc2e0b Update named configurations on builders, turn off checking temporarily.
32851e157f Add support for running some non-integration tests in server using the CFE
0fd93a5c6e Test.dart exits with non-zero exit code if named configuration disagrees with flags.
804fc2add3 [VM runtime] Consider partial instantiation when printing closures (fixes #34034). Add regression test.
c3b7f29d46 Change a pair of negative tests to multitests
f10b4005cd Code to load a named configuration and check it against the existing options.
695476f115 Status file after 03df8b1
7413644de8 Change builder names from -ff- to -firefox-
0c187585c5 Added return-void-2-dynamic to whitelist of generalized-void.md
6920d6b11e Added specification of generated nSM forwarders for private methods
03df8b1eb8 Change a few language_2 tests to comply with reality
cf77a3b00f [Test.dart] Use Compiler, Runtime, etc. classes from pkg:smith.
55880dfeed Add support in the new API for CFE
4b07df24dd Store invalid deferred types used in bodies.
89cfa2edd7 Update package:test_reflective_loader.

* Update DEPS

* Update travis/licenses_golden/licenses_third_party

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

List of commits included in this roll:

8bad5c7b29 [vm/compiler] Non-speculative X64 long division/remainder.
918cda18c5 Add docs about sourcemap extensions
329e029bd6 Fixes https://github.com/dart-lang/sdk/issues/34035
12326c10e1 Store constructor field initializera when the target is not a field.
50da4b8d92 Skip ShadowInvalidFieldInitializer while resynthesizing constructor initializers.
8810b6ecc7 Translate kernel.Instantiation in constant expressions.
cb7341fceb Initial support for inlining-data in source-maps.
4206131030 Fix tracking of onStep position of arguments to new expression
384b0a9a73 Issue 34038. Fix resynthesizing imports when mixed with exports.
ba7dbcf412 Update the test output processor to produce more useful analysis
4b2ee8e9a5 Improve catch clause recovery
66500de4dc More fixes to the CFE integration tests
3f2251986d CC sra also in changes to compiler files and tests
4734c55882 Report error on unsupported operators
00e3109368 [VM] Adjust flags for creating depfiles
07c462b471 [vm] Refactoring: extract BaseFlowGraphBuilder to a separate file
ff9167ff7b Fix parseDirectives to recognize metadata
079bebb78b [ VM ] Added missing token position for `assert` statements
174649b9be [gardening] Update status of dissasemble_test on Windows
8c5aca7d4d Remove the Factory interface
3dc201e168 Update ChangeBuilder to not include empty edits (Take 2)
18047b2757 Refactor test.dart by changing class Configuration to TestConfiguration
7373d38a31 Update status for Dart2js minified CSP on Chrome with fast startup
61148eade8 Update mixin-declaration feature specification.
a98feb0f01 [VM interpreter] Fix exception handling. Convert bytecode indices to pc offsets when reading bytecode exception tables. Print pc descriptors and exception handlers in bytecode disassembly. Propagate unhandled exceptions after calling interpreter.
da2ed2fd59 Don't ignore runtime cast failures on Map<K,V>.
3d8ca8e566 [gardening] Increase debug app-jitk timeout
0313f7bd66 [gardening] Update status file for failing test
6c39bc38f3 Clear ShadowX references that are not required after compilation.
05b9bbd2b5 Remove the dart1 version of the analysis server snapshot.
9107399190 Add back in the analysis server training.
9fb6c09015 Store reference/type for invalid types.
21db860271 Remove non-strong dart2js builders from test_matrix.json
2e7b0a13f1 Add support for accessing all of the created contexts
73663ae7c6 Allow void on the RHS of null coalescing expressions
17cb6d95d1 Don't remember TypeEnvironment in resolution results.
72960de5f9 [VM] Fix one more place where bound error allocation happened on BG thread in new space
6ad79ff4bd Update status file for tests passing under CFE
23ba527735 [VM] Ensure to alloate bound errors in old space on BG compiler
fe8052428b Remove CONTENT_MODIFIED from spec/test for getSignature
c4c847a45c Revert "[CQ] Remove pkg-linux-release from the CQ trybots until it is fixed"
beaf05efa3 [vm] When generating JITDUMP also dump IR and attach it as source to code.
24158b773d [vm/compiler] Do not LICM LoadStaticField for uninitialized fields.
68bfaf3ac3 [vm/compiler] Avoid crashes when canonicalizing unreachable AssertAssignable.
5a45b2a62b [infra] Upgrade homebrew dependencies to work on Dart 2
8e287dc037 [VM] Only add direct implementor when reading script snapshots if the implemented class is from the full snapshot
6e81d74fcc [VM] Optimize generation of type testing stubs in JIT mode.
058510eeab fix #28233, add hint for missing returns to function expressions
4482d13ff7 [vm/compiler] Bug fix in 64-bit MOD (%) operator.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.

Auto-roller completed checks. Merging.