Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
qq_34031325
engine
提交
f34bc65b
E
engine
项目概览
qq_34031325
/
engine
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
E
engine
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
f34bc65b
编写于
2月 05, 2020
作者:
Y
Yegor
提交者:
GitHub
2月 05, 2020
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
use percent for golden diff rates; tighten the values (#16430)
上级
8f89bac4
变更
10
隐藏空白更改
内联
并排
Showing
10 changed file
with
33 addition
and
19 deletion
+33
-19
lib/web_ui/test/golden_tests/engine/canvas_blend_golden_test.dart
...ui/test/golden_tests/engine/canvas_blend_golden_test.dart
+1
-1
lib/web_ui/test/golden_tests/engine/canvas_clip_path_test.dart
...eb_ui/test/golden_tests/engine/canvas_clip_path_test.dart
+1
-1
lib/web_ui/test/golden_tests/engine/canvas_draw_image_golden_test.dart
...st/golden_tests/engine/canvas_draw_image_golden_test.dart
+1
-1
lib/web_ui/test/golden_tests/engine/canvas_golden_test.dart
lib/web_ui/test/golden_tests/engine/canvas_golden_test.dart
+1
-1
lib/web_ui/test/golden_tests/engine/compositing_golden_test.dart
..._ui/test/golden_tests/engine/compositing_golden_test.dart
+1
-1
lib/web_ui/test/golden_tests/engine/draw_vertices_golden_test.dart
...i/test/golden_tests/engine/draw_vertices_golden_test.dart
+6
-3
lib/web_ui/test/golden_tests/engine/scuba.dart
lib/web_ui/test/golden_tests/engine/scuba.dart
+4
-4
lib/web_ui/test/golden_tests/engine/text_style_golden_test.dart
...b_ui/test/golden_tests/engine/text_style_golden_test.dart
+2
-2
web_sdk/web_engine_tester/lib/golden_tester.dart
web_sdk/web_engine_tester/lib/golden_tester.dart
+14
-5
web_sdk/web_engine_tester/pubspec.yaml
web_sdk/web_engine_tester/pubspec.yaml
+2
-0
未找到文件。
lib/web_ui/test/golden_tests/engine/canvas_blend_golden_test.dart
浏览文件 @
f34bc65b
...
...
@@ -28,7 +28,7 @@ void main() async {
try
{
sceneElement
.
append
(
engineCanvas
.
rootElement
);
html
.
document
.
body
.
append
(
sceneElement
);
await
matchGoldenFile
(
'
$fileName
.png'
,
region:
region
,
maxDiffRate
:
0.03
);
await
matchGoldenFile
(
'
$fileName
.png'
,
region:
region
,
maxDiffRate
Percent:
0.0
);
}
finally
{
// The page is reused across tests, so remove the element after taking the
// Scuba screenshot.
...
...
lib/web_ui/test/golden_tests/engine/canvas_clip_path_test.dart
浏览文件 @
f34bc65b
...
...
@@ -28,7 +28,7 @@ void main() async {
try
{
sceneElement
.
append
(
engineCanvas
.
rootElement
);
html
.
document
.
body
.
append
(
sceneElement
);
await
matchGoldenFile
(
'
$fileName
.png'
,
region:
region
,
maxDiffRate
:
0.2
);
await
matchGoldenFile
(
'
$fileName
.png'
,
region:
region
,
maxDiffRate
Percent:
0.0
);
}
finally
{
// The page is reused across tests, so remove the element after taking the
// Scuba screenshot.
...
...
lib/web_ui/test/golden_tests/engine/canvas_draw_image_golden_test.dart
浏览文件 @
f34bc65b
...
...
@@ -31,7 +31,7 @@ void main() async {
try
{
sceneElement
.
append
(
engineCanvas
.
rootElement
);
html
.
document
.
body
.
append
(
sceneElement
);
await
matchGoldenFile
(
'
$fileName
.png'
,
region:
region
,
maxDiffRate
:
0.2
);
await
matchGoldenFile
(
'
$fileName
.png'
,
region:
region
,
maxDiffRate
Percent:
0.0
);
}
finally
{
// The page is reused across tests, so remove the element after taking the
// Scuba screenshot.
...
...
lib/web_ui/test/golden_tests/engine/canvas_golden_test.dart
浏览文件 @
f34bc65b
...
...
@@ -166,7 +166,7 @@ void main() async {
await
matchGoldenFile
(
'bitmap_canvas_draws_high_quality_text.png'
,
region:
canvasSize
,
maxDiffRate:
0.0
,
maxDiffRate
Percent
:
0.0
,
pixelComparison:
PixelComparison
.
precise
,
);
},
timeout:
const
Timeout
(
Duration
(
seconds:
10
)),
testOn:
'chrome'
);
...
...
lib/web_ui/test/golden_tests/engine/compositing_golden_test.dart
浏览文件 @
f34bc65b
...
...
@@ -592,7 +592,7 @@ void _testCullRectComputation() {
await
matchGoldenFile
(
'compositing_draw_high_quality_text.png'
,
region:
canvasSize
,
maxDiffRate:
0.0
,
maxDiffRate
Percent
:
0.0
,
pixelComparison:
PixelComparison
.
precise
,
);
},
...
...
lib/web_ui/test/golden_tests/engine/draw_vertices_golden_test.dart
浏览文件 @
f34bc65b
...
...
@@ -28,9 +28,12 @@ void main() async {
try
{
sceneElement
.
append
(
engineCanvas
.
rootElement
);
html
.
document
.
body
.
append
(
sceneElement
);
// Set rate to 0.66% for webGL difference across platforms.
await
matchGoldenFile
(
'
$fileName
.png'
,
region:
region
,
write:
write
,
maxDiffRate:
1.5
/
100.0
);
await
matchGoldenFile
(
'
$fileName
.png'
,
region:
region
,
write:
write
,
maxDiffRatePercent:
0.0
,
);
}
finally
{
// The page is reused across tests, so remove the element after taking the
// golden screenshot.
...
...
lib/web_ui/test/golden_tests/engine/scuba.dart
浏览文件 @
f34bc65b
...
...
@@ -45,12 +45,12 @@ class EngineScubaTester {
Future
<
void
>
diffScreenshot
(
String
fileName
,
{
ui
.
Rect
region
,
double
maxDiffRate
,
double
maxDiffRate
Percent
,
})
async
{
await
matchGoldenFile
(
'
$fileName
.png'
,
region:
region
??
viewportRegion
,
maxDiffRate
:
maxDiffRate
,
maxDiffRate
Percent:
maxDiffRatePercent
,
);
}
...
...
@@ -62,7 +62,7 @@ class EngineScubaTester {
EngineCanvas
canvas
,
String
fileName
,
{
ui
.
Rect
region
,
double
maxDiffRate
,
double
maxDiffRate
Percent
,
})
async
{
// Wrap in <flt-scene> so that our CSS selectors kick in.
final
html
.
Element
sceneElement
=
html
.
Element
.
tag
(
'flt-scene'
);
...
...
@@ -76,7 +76,7 @@ class EngineScubaTester {
await
diffScreenshot
(
screenshotName
,
region:
region
,
maxDiffRate
:
maxDiffRate
,
maxDiffRate
Percent:
maxDiffRatePercent
,
);
}
finally
{
// The page is reused across tests, so remove the element after taking the
...
...
lib/web_ui/test/golden_tests/engine/text_style_golden_test.dart
浏览文件 @
f34bc65b
...
...
@@ -219,7 +219,7 @@ void main() async {
testEachCanvas
(
'draws text with a shadow'
,
(
EngineCanvas
canvas
)
{
drawTextWithShadow
(
canvas
);
return
scuba
.
diffCanvasScreenshot
(
canvas
,
'text_shadow'
,
maxDiffRate:
0.2
);
return
scuba
.
diffCanvasScreenshot
(
canvas
,
'text_shadow'
,
maxDiffRate
Percent
:
0.2
);
},
bSkipHoudini:
true
);
testEachCanvas
(
'Handles disabled strut style'
,
(
EngineCanvas
canvas
)
{
...
...
@@ -238,7 +238,7 @@ void main() async {
canvas
,
'text_strut_style_disabled'
,
region:
Rect
.
fromLTRB
(
0
,
0
,
100
,
100
),
maxDiffRate
:
0.9
/
100
,
// 0.9%
maxDiffRate
Percent:
0.0
,
);
});
}
web_sdk/web_engine_tester/lib/golden_tester.dart
浏览文件 @
f34bc65b
...
...
@@ -6,6 +6,7 @@ import 'dart:async';
import
'dart:convert'
;
import
'dart:html'
as
html
;
import
'package:ui/src/engine.dart'
;
import
'package:ui/ui.dart'
;
import
'package:test/test.dart'
;
...
...
@@ -49,13 +50,13 @@ enum PixelComparison {
/// [pixelComparison] determines the algorithm used to compare pixels. Uses
/// fuzzy comparison by default.
Future
<
void
>
matchGoldenFile
(
String
filename
,
{
bool
write
=
false
,
Rect
region
=
null
,
double
maxDiffRate
=
null
,
PixelComparison
pixelComparison
=
PixelComparison
.
fuzzy
})
async
{
{
bool
write
=
false
,
Rect
region
=
null
,
double
maxDiffRate
Percent
=
null
,
PixelComparison
pixelComparison
=
PixelComparison
.
fuzzy
})
async
{
Map
<
String
,
dynamic
>
serverParams
=
<
String
,
dynamic
>{
'filename'
:
filename
,
'write'
:
write
,
'region'
:
region
==
null
?
null
:
{
:
<
String
,
dynamic
>
{
'x'
:
region
.
left
,
'y'
:
region
.
top
,
'width'
:
region
.
width
,
...
...
@@ -63,10 +64,18 @@ Future<void> matchGoldenFile(String filename,
},
'pixelComparison'
:
pixelComparison
.
toString
(),
};
if
(
maxDiffRate
!=
null
)
{
serverParams
[
'maxdiffrate'
]
=
maxDiffRate
;
// Chrome on macOS renders slighly differently from Linux, so allow it an
// extra 1% to deviate from the golden files.
if
(
maxDiffRatePercent
!=
null
)
{
if
(
operatingSystem
==
OperatingSystem
.
macOs
)
{
maxDiffRatePercent
+=
1.0
;
}
serverParams
[
'maxdiffrate'
]
=
maxDiffRatePercent
/
100
;
}
else
if
(
operatingSystem
==
OperatingSystem
.
macOs
)
{
serverParams
[
'maxdiffrate'
]
=
0.01
;
}
final
String
response
=
await
_callScreenshotServer
(
serverParams
);
final
String
response
=
await
_callScreenshotServer
(
serverParams
)
as
String
;
if
(
response
==
'OK'
)
{
// Pass
return
;
...
...
web_sdk/web_engine_tester/pubspec.yaml
浏览文件 @
f34bc65b
...
...
@@ -8,3 +8,5 @@ dependencies:
stream_channel
:
2.0.0
test
:
1.6.5
webkit_inspection_protocol
:
0.5.0
ui
:
path
:
../../lib/web_ui
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录