Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
qq_34031325
engine
提交
f288fe56
E
engine
项目概览
qq_34031325
/
engine
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
E
engine
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
f288fe56
编写于
7月 29, 2020
作者:
M
Mouad Debbar
提交者:
GitHub
7月 29, 2020
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
[web] Enable canvas measurement by default (#19924)
上级
ec9e17c5
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
18 addition
and
12 deletion
+18
-12
lib/web_ui/lib/src/engine/web_experiments.dart
lib/web_ui/lib/src/engine/web_experiments.dart
+1
-1
lib/web_ui/test/engine/web_experiments_test.dart
lib/web_ui/test/engine/web_experiments_test.dart
+13
-11
lib/web_ui/test/golden_tests/engine/scuba.dart
lib/web_ui/test/golden_tests/engine/scuba.dart
+4
-0
未找到文件。
lib/web_ui/lib/src/engine/web_experiments.dart
浏览文件 @
f288fe56
...
...
@@ -31,7 +31,7 @@ class WebExperiments {
static
const
bool
_defaultUseCanvasText
=
const
bool
.
fromEnvironment
(
'FLUTTER_WEB_USE_EXPERIMENTAL_CANVAS_TEXT'
,
defaultValue:
fals
e
,
defaultValue:
tru
e
,
);
bool
_useCanvasText
=
_defaultUseCanvasText
;
...
...
lib/web_ui/test/engine/web_experiments_test.dart
浏览文件 @
f288fe56
...
...
@@ -9,6 +9,8 @@ import 'dart:js_util' as js_util;
import
'package:test/test.dart'
;
import
'package:ui/src/engine.dart'
;
const
bool
_defaultUseCanvasText
=
true
;
void
main
(
)
{
setUp
(()
{
WebExperiments
.
ensureInitialized
();
...
...
@@ -19,7 +21,7 @@ void main() {
});
test
(
'default web experiment values'
,
()
{
expect
(
WebExperiments
.
instance
.
useCanvasText
,
false
);
expect
(
WebExperiments
.
instance
.
useCanvasText
,
_defaultUseCanvasText
);
});
test
(
'can turn on/off web experiments'
,
()
{
...
...
@@ -31,36 +33,36 @@ void main() {
WebExperiments
.
instance
.
updateExperiment
(
'useCanvasText'
,
null
);
// Goes back to default value.
expect
(
WebExperiments
.
instance
.
useCanvasText
,
false
);
expect
(
WebExperiments
.
instance
.
useCanvasText
,
_defaultUseCanvasText
);
});
test
(
'ignores unknown experiments'
,
()
{
expect
(
WebExperiments
.
instance
.
useCanvasText
,
false
);
expect
(
WebExperiments
.
instance
.
useCanvasText
,
_defaultUseCanvasText
);
WebExperiments
.
instance
.
updateExperiment
(
'foobarbazqux'
,
true
);
expect
(
WebExperiments
.
instance
.
useCanvasText
,
false
);
expect
(
WebExperiments
.
instance
.
useCanvasText
,
_defaultUseCanvasText
);
WebExperiments
.
instance
.
updateExperiment
(
'foobarbazqux'
,
false
);
expect
(
WebExperiments
.
instance
.
useCanvasText
,
false
);
expect
(
WebExperiments
.
instance
.
useCanvasText
,
_defaultUseCanvasText
);
});
test
(
'can reset web experiments'
,
()
{
WebExperiments
.
instance
.
updateExperiment
(
'useCanvasText'
,
tru
e
);
WebExperiments
.
instance
.
updateExperiment
(
'useCanvasText'
,
fals
e
);
WebExperiments
.
instance
.
reset
();
expect
(
WebExperiments
.
instance
.
useCanvasText
,
false
);
expect
(
WebExperiments
.
instance
.
useCanvasText
,
_defaultUseCanvasText
);
WebExperiments
.
instance
.
updateExperiment
(
'useCanvasText'
,
tru
e
);
WebExperiments
.
instance
.
updateExperiment
(
'useCanvasText'
,
fals
e
);
WebExperiments
.
instance
.
updateExperiment
(
'foobarbazqux'
,
true
);
WebExperiments
.
instance
.
reset
();
expect
(
WebExperiments
.
instance
.
useCanvasText
,
false
);
expect
(
WebExperiments
.
instance
.
useCanvasText
,
_defaultUseCanvasText
);
});
test
(
'js interop also works'
,
()
{
expect
(
WebExperiments
.
instance
.
useCanvasText
,
false
);
expect
(
WebExperiments
.
instance
.
useCanvasText
,
_defaultUseCanvasText
);
expect
(()
=>
jsUpdateExperiment
(
'useCanvasText'
,
true
),
returnsNormally
);
expect
(
WebExperiments
.
instance
.
useCanvasText
,
true
);
expect
(()
=>
jsUpdateExperiment
(
'useCanvasText'
,
null
),
returnsNormally
);
expect
(
WebExperiments
.
instance
.
useCanvasText
,
false
);
expect
(
WebExperiments
.
instance
.
useCanvasText
,
_defaultUseCanvasText
);
});
test
(
'js interop throws on wrong type'
,
()
{
...
...
lib/web_ui/test/golden_tests/engine/scuba.dart
浏览文件 @
f288fe56
...
...
@@ -116,8 +116,10 @@ void testEachCanvas(String description, CanvasTest body,
test
(
'
$description
(dom)'
,
()
{
try
{
TextMeasurementService
.
initialize
(
rulerCacheCapacity:
2
);
WebExperiments
.
instance
.
useCanvasText
=
false
;
return
body
(
DomCanvas
());
}
finally
{
WebExperiments
.
instance
.
useCanvasText
=
null
;
TextMeasurementService
.
clearCache
();
}
});
...
...
@@ -125,8 +127,10 @@ void testEachCanvas(String description, CanvasTest body,
test
(
'
$description
(houdini)'
,
()
{
try
{
TextMeasurementService
.
initialize
(
rulerCacheCapacity:
2
);
WebExperiments
.
instance
.
useCanvasText
=
false
;
return
body
(
HoudiniCanvas
(
bounds
));
}
finally
{
WebExperiments
.
instance
.
useCanvasText
=
null
;
TextMeasurementService
.
clearCache
();
}
});
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录