Roll Dart (#2838)

DEPS

@@ -25,7 +25,7 @@ vars = {
 
   # Note: When updating the Dart revision, ensure that all entries that are
   # dependencies of dart are also updated
-  'dart_revision': '8dc35ba47ee5f43e0f6ed8d9b6a3914a2c4d9577',
+  'dart_revision': 'd37ea681f5d80a3ab150b709baaeb1fef7a12cae',
   'dart_boringssl_revision': 'daeafc22c66ad48f6b32fc8d3362eb9ba31b774e',
   'dart_observatory_packages_revision': 'e5e1e543bea10d4bed95b22ad3e7aa2b20a23584',
   'dart_root_certificates_revision': 'aed07942ce98507d2be28cbd29e879525410c7fc',

sky/engine/core/dart/text.dart

@@ -510,22 +510,12 @@ class TextBox {
 
   /// The left edge of the box for ltr text; the right edge of the box for rtl text.
   double get start {
-    switch (direction) {
-      case TextDirection.rtl:
-        return right;
-      case TextDirection.ltr:
-        return left;
-    }
+    return (direction == TextDirection.ltr) ? left : right;
   }
 
   /// The right edge of the box for ltr text; the left edge of the box for rtl text.
   double get end {
-    switch (direction) {
-      case TextDirection.rtl:
-        return left;
-      case TextDirection.ltr:
-        return right;
-    }
+    return (direction == TextDirection.ltr) ? right : left;
   }
 
   bool operator ==(dynamic other) {

travis/analyze.sh

@@ -15,10 +15,10 @@ RESULTS=`dartanalyzer                                                          \
   | grep -v "\[error\] Target of URI does not exist: 'dart:mojo.internal'"     \
   | grep -v "\[error\] Native functions can only be declared in the SDK and code that is loaded through native extensions" \
   | grep -Ev "\[(hint|error)\] The function '.+' is not used"                  \
-  | grep -v "\[warning\] Undefined name 'main'"                                \
-  | grep -v "\[warning\] Undefined name 'VMLibraryHooks"                       \
-  | grep -v "\[warning\] Undefined name 'MojoHandleWatcher'"                   \
-  | grep -v "\[warning\] Undefined name 'MojoCoreNatives'"                     \
+  | grep -v "\[error\] Undefined name 'main'"                                  \
+  | grep -v "\[error\] Undefined name 'VMLibraryHooks"                         \
+  | grep -v "\[error\] Undefined name 'MojoHandleWatcher'"                     \
+  | grep -v "\[error\] Undefined name 'MojoCoreNatives'"                       \
   | grep -v "\[error\] The library ''dart:_internal'' is internal"             \
   | grep -Ev "Unused import .+ui\.dart"                                        \
   | grep -v "\[info\] TODO"                                                    \