• I
    Run "pub get" for the frontend_server package before building. (#4562) · 2dfeaa66
    Ian Hickson 提交于
    In https://github.com/flutter/engine/pull/4554 I removed the .packages
    file in the frontend_server directory, because it was out of sync with
    the pubspec.yaml. It seems like the right solution is to run `pub get`
    when we get the dependencies, i.e. when we run `gclient sync`.
    
    Being out of sync is a problem because it means that running "pub get"
    in that directory changes what packages are being used, and changes
    the `.packages` file, which leads to having to revert changes before
    committing code, etc. Having to regularly update this file doesn't
    make much sense either, since the files that were missing were files
    that are obtained from the network (e.g. the `io` package as used by
    the `test` package).
    
    Previously, (see
    https://github.com/flutter/engine/pull/3982#issuecomment-323213199),
    we did not do this because we did not want the build to call into the
    network. This still does not call into the network during the _build_
    phase, only during `gclient sync` (which is when all the dependencies
    are brought down).
    
    Currently the network dependencies only matter for running tests. We
    should make sure this remains the case. Ideally we wouldn't even
    depend on those.
    2dfeaa66
DEPS 17.3 KB