提交 b5832dad 编写于 作者: J Jason Song

fix potential xss issue with user id

上级 77f801c8
......@@ -118,6 +118,8 @@
<!-- bootstrap.js -->
<script src="vendor/bootstrap/js/bootstrap.min.js" type="text/javascript"></script>
<script src="../vendor/lodash.min.js"></script>
<!--valdr-->
<script src="vendor/valdr/valdr.min.js" type="text/javascript"></script>
<script src="vendor/valdr/valdr-message.min.js" type="text/javascript"></script>
......
......@@ -79,7 +79,7 @@ function AccessKeyController($scope, $location, $translate, toastr,
$scope.appRoleUsers = result;
$scope.admins = [];
$scope.appRoleUsers.masterUsers.forEach(function (user) {
$scope.admins.push(user.userId);
$scope.admins.push(_.escape(user.userId));
});
});
}
......
......@@ -118,7 +118,7 @@ function createAppController($scope, $window, $translate, toastr, AppService, Ap
if (owner) {
$(".adminSelector").parent().find(".select2-selection__rendered").prepend(
'<li class="select2-selection__choice J_owner">'
+ owner.text + '</li>')
+ _.escape(owner.text) + '</li>')
}
}
}
......@@ -86,7 +86,7 @@ function SettingController($scope, $location, $translate, toastr,
$scope.appRoleUsers = result;
$scope.admins = [];
$scope.appRoleUsers.masterUsers.forEach(function (user) {
$scope.admins.push(user.userId);
$scope.admins.push(_.escape(user.userId));
});
});
......@@ -106,7 +106,7 @@ function SettingController($scope, $location, $translate, toastr,
$orgWidget.val(app.orgId).trigger("change");
var $ownerSelector = $('.ownerSelector');
var defaultSelectedDOM = '<option value="' + app.ownerName + '" selected="selected">' + app.ownerName
var defaultSelectedDOM = '<option value="' + _.escape(app.ownerName) + '" selected="selected">' + _.escape(app.ownerName)
+ '</option>';
$ownerSelector.append(defaultSelectedDOM);
$ownerSelector.trigger('change');
......
......@@ -35,7 +35,7 @@ function controller($rootScope, $scope, $translate, toastr, AppUtil, EventManage
.then(function (result) {
var masterUsers = '';
result.masterUsers.forEach(function (user) {
masterUsers += user.userId + ',';
masterUsers += _.escape(user.userId) + ',';
});
$scope.masterUsers = masterUsers.substring(0, masterUsers.length - 1);
}, function (result) {
......
......@@ -58,7 +58,7 @@ function deleteNamespaceModalDirective($window, $q, $translate, toastr, AppUtil,
var masterUsers = [];
appRoleUsers.masterUsers.forEach(function (user) {
masterUsers.push(user.userId);
masterUsers.push(_.escape(user.userId));
if (currentUser.userId == user.userId) {
isAppMasterUser = true;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册