Connect spider_closed signal after a crawler is bound to a Spider

scrapy/spider.py

@@ -6,6 +6,7 @@ See documentation in docs/topics/spiders.rst
 import warnings
 
 from scrapy import log
+from scrapy import signals
 from scrapy.http import Request
 from scrapy.utils.trackref import object_ref
 from scrapy.utils.url import url_is_from_spider
@@ -53,6 +54,7 @@ class Spider(object_ref):
     def _set_crawler(self, crawler):
         self.crawler = crawler
         self.settings = crawler.settings
+        crawler.signals.connect(self.close, signals.spider_closed)
 
     def start_requests(self):
         for url in self.start_urls:
@@ -68,6 +70,12 @@ class Spider(object_ref):
     def handles_request(cls, request):
         return url_is_from_spider(request.url, cls)
 
+    @staticmethod
+    def close(spider, reason):
+        closed = getattr(spider, 'closed', None)
+        if callable(closed):
+            return closed(reason)
+
     def __str__(self):
         return "<%s %r at 0x%0x>" % (type(self).__name__, self.name, id(self))
 

tests/test_spider.py

@@ -8,6 +8,7 @@ try:
 except ImportError:
     import mock
 
+from scrapy import signals
 from scrapy.spider import Spider, BaseSpider
 from scrapy.http import Request, Response, TextResponse, XmlResponse, HtmlResponse
 from scrapy.contrib.spiders.init import InitSpider
@@ -76,6 +77,21 @@ class SpiderTest(unittest.TestCase):
                                            foo='bar')
             mock_init.assert_called_once_with('example.com', foo='bar')
 
+    def test_closed_signal_call(self):
+        class TestSpider(self.spider_class):
+            closed_called = False
+
+            def closed(self, reason):
+                self.closed_called = True
+
+        crawler = get_crawler()
+        spider = TestSpider.from_crawler(crawler, 'example.com')
+        crawler.signals.send_catch_log(signal=signals.spider_opened,
+                                       spider=spider)
+        crawler.signals.send_catch_log(signal=signals.spider_closed,
+                                       spider=spider, reason=None)
+        self.assertTrue(spider.closed_called)
+
 
 class InitSpiderTest(SpiderTest):