1. 15 4月, 2020 11 次提交
  2. 14 4月, 2020 12 次提交
    • N
      Removed duplicate value_expr checks · a520ee47
      Nobuyoshi Nakada 提交于
      `arg_rhs` has the same check and is always a non-void value
      expression.
      a520ee47
    • T
      f8886265
    • N
    • T
      Add missing call in 70b7304f · e6677503
      Takashi Kokubun 提交于
      e6677503
    • T
      Ignore AppVeyor vs120's pdb corruption · 70b7304f
      Takashi Kokubun 提交于
      We tried to fix this like https://github.com/ruby/ruby/pull/3029, but it
      didn't work. The failure has never been helpful for developing MJIT, and
      currently it's not prioritized to be fixed. Until we try to figure out
      the root cause on AppVeyor vs120, let's optionally disable testing when
      the random corruption happens.
      70b7304f
    • T
      Unify vm benchmark prefixes to vm_ (#3028) · f883d621
      Takashi Kokubun 提交于
      The vm1_ prefix and vm2_ had had special meaning until
      820ad9cb and
      12068aa4. AFAIK there's no special
      meaning in vm3_ prefix.
      
      As they have confused people (like "In `benchmark` what is difference
      between `vm1_`, `vm2_` and `vm3_`"), I'd like to remove the obsoleted
      prefix as we obviated that two years ago.
      f883d621
    • N
      Make y.output in ripper unlocalized [ci skip] · 9fa24018
      Nobuyoshi Nakada 提交于
      Often it is easy to search, grep, etc from command line, for
      debugging purpose.
      9fa24018
    • K
      c79e3a59
    • T
      Make vm_call_cfunc_with_frame a fastpath (#3027) · 310ef9f4
      Takashi Kokubun 提交于
      when there's no need to call CALLER_SETUP_ARG and CALLER_REMOVE_EMPTY_KW_SPLAT
      (i.e. !rb_splat_or_kwargs_p(ci) && !calling->kw_splat).
      
      Micro benchmark:
      ```
      $ benchmark-driver -v --rbenv 'before;after' benchmark/vm_send_cfunc.yml --repeat-count=4
      before: ruby 2.8.0dev (2020-04-13T23:45:05Z master b9d3ceee) [x86_64-linux]
      after: ruby 2.8.0dev (2020-04-14T00:48:52Z no-splat-fastpath 418d363722) [x86_64-linux]
      Calculating -------------------------------------
                               before       after
             vm_send_cfunc    69.585M     88.724M i/s -    100.000M times in 1.437097s 1.127096s
      
      Comparison:
                          vm_send_cfunc
                     after:  88723605.2 i/s
                    before:  69584737.1 i/s - 1.28x  slower
      ```
      
      Optcarrot:
      ```
      $ benchmark-driver -v --rbenv 'before;after' benchmark.yml --repeat-count=12 --output=all
      before: ruby 2.8.0dev (2020-04-13T23:45:05Z master b9d3ceee) [x86_64-linux]
      after: ruby 2.8.0dev (2020-04-14T00:48:52Z no-splat-fastpath 418d363722) [x86_64-linux]
      Calculating -------------------------------------
                                             before                 after
      Optcarrot Lan_Master.nes    50.76119601545175     42.73858236484051 fps
                                  50.76388649761503     51.04211379912850
                                  50.80930672252514     51.39455790755538
                                  50.90236000778749     51.75656936556145
                                  51.01744746340430     51.86875277356489
                                  51.06495279015112     51.88692482485558
                                  51.07785337168974     51.93429603190578
                                  51.20163525187862     51.95768145071314
                                  51.34671771913112     52.45577266040274
                                  51.35918340835583     52.53163888762858
                                  51.46641337418146     52.62172484121034
                                  51.50835463462257     52.85064021113239
      ```
      310ef9f4
    • T
      Unwrap vm_call_cfunc indirection on JIT · b9d3ceee
      Takashi Kokubun 提交于
      for VM_METHOD_TYPE_CFUNC.
      
      This has been known to decrease optcarrot fps:
      
      ```
      $ benchmark-driver -v --rbenv 'before --jit;after --jit' benchmark.yml --repeat-count=24 --output=all
      before --jit: ruby 2.8.0dev (2020-04-13T16:25:13Z master fb40495c) +JIT [x86_64-linux]
      after --jit: ruby 2.8.0dev (2020-04-13T23:23:11Z mjit-inline-c bdcd06d159) +JIT [x86_64-linux]
      Calculating -------------------------------------
                                       before --jit           after --jit
      Optcarrot Lan_Master.nes    66.38132676191719     67.41369177299630 fps
                                  69.42728743772243     68.90327567263054
                                  72.16028300263211     69.62605130880686
                                  72.46631319102777     70.48818243767207
                                  73.37078877002490     70.79522887347566
                                  73.69422431217367     70.99021920193194
                                  74.01471487018695     74.69931965402584
                                  75.48685183295630     74.86714575949016
                                  75.54445264507932     75.97864419721677
                                  77.28089738169756     76.48908637569581
                                  78.04183397891302     76.54320932488021
                                  78.36807984096562     76.59407262898067
                                  78.92898762543574     77.31316743361343
                                  78.93576483233765     77.97153484180480
                                  79.13754917503078     77.98478782102325
                                  79.62648945850653     78.02263322726446
                                  79.86334213878064     78.26333724045934
                                  80.05100635898518     78.60056756355614
                                  80.26186843769584     78.91082645644468
                                  80.34205717020330     79.01226659142263
                                  80.62286066044338     79.32733939423721
                                  80.95883033058557     79.63793060542024
                                  80.97376819251613     79.73108936622778
                                  81.23050939202896     80.18280109433088
      ```
      
      and I deleted this capability in an early stage of YARV-MJIT development:
      https://github.com/k0kubun/yarv-mjit/commit/0ab130feeefc2b9078a1077e4fec93b3f5e45d07
      
      I suspect either of the following things could be the cause:
      
      * Directly calling vm_call_cfunc requires more optimization effort in GCC,
        resulting in 30ms-ish compilation time increase for such methods and
        decreasing the number of methods compiled in a benchmarked period.
      
      * Code size increase => icache miss hit
      
      These hypotheses could be verified by some methodologies. However, I'd
      like to introduce this regardless of the result because this blocks
      inlining C method's definition.
      
      I may revert this commit when I give up to implement inlining C method
      definition, which requires this change.
      
      Microbenchmark-wise, this gives slight performance improvement:
      
      ```
      $ benchmark-driver -v --rbenv 'before --jit;after --jit' benchmark/mjit_send_cfunc.yml --repeat-count=4
      before --jit: ruby 2.8.0dev (2020-04-13T16:25:13Z master fb40495c) +JIT [x86_64-linux]
      after --jit: ruby 2.8.0dev (2020-04-13T23:23:11Z mjit-inline-c bdcd06d159) +JIT [x86_64-linux]
      Calculating -------------------------------------
                           before --jit  after --jit
           mjit_send_cfunc      41.961M      56.489M i/s -    100.000M times in 2.383143s 1.770244s
      
      Comparison:
                        mjit_send_cfunc
               after --jit:  56489372.5 i/s
              before --jit:  41961388.1 i/s - 1.35x  slower
      ```
      b9d3ceee
    • G
      * 2020-04-14 [ci skip] · fb40495c
      git 提交于
      fb40495c
    • B
      a6f7458e
  3. 13 4月, 2020 7 次提交
  4. 12 4月, 2020 8 次提交
  5. 11 4月, 2020 2 次提交