- 06 11月, 2017 5 次提交
-
-
由 Ryuta Kamizono 提交于
A relation includes `klass`, so it can not be used as it is if current class is different from `current_scope.klass`. It should be created new relation by current class to respect the klass and STI constraint. Fixes #17603. Fixes #23576.
-
由 Ryuta Kamizono 提交于
This is partially fixed by e617fb57 when through association has already loaded. Otherwise, second level through association should respect `preload_scope`. Fixes #30242. Closes #30076. [Ryuta Kamizono & CicholGricenchos]
-
由 Ryuta Kamizono 提交于
If through association has already loaded, `source_type` is ignored to loaded through records. The loaded records should be filtered by `source_type` in that case. Fixes #30904.
-
由 Ryuta Kamizono 提交于
If a relation has eager-loading values, `count` and `exists?` works properly, but `update_all` and `delete_all` doesn't work due to missing `apply_join_dependency`. It should be applied to work consistently. Fixes #28863.
-
由 Ryuta Kamizono 提交于
Fixes #30315.
-
- 05 11月, 2017 5 次提交
-
-
由 Eileen M. Uchitelle 提交于
Generate the correct path in nested scaffold generator
-
由 Ryuta Kamizono 提交于
Show `RequestForgeryProtection` methods in api doc [ci skip]
-
由 yuuji.yaginuma 提交于
Several methods of `RequestForgeryProtection` are not showed in the api doc even though `:doc:` is specified. (e.g. `form_authenticity_param`) http://api.rubyonrails.org/classes/ActionController/RequestForgeryProtection.html These methods are listed in the doc of v4.1. http://api.rubyonrails.org/v4.1/classes/ActionController/RequestForgeryProtection.html This is due to the influence of `:nodoc:` added in #18102, methods after `CROSS_ORIGIN_JAVASCRIPT_WARNING` not showed from the doc. Therefore, in order to show the method like originally, added `startdoc` after `CROSS_ORIGIN_JAVASCRIPT_WARNING`.
-
由 yuuji.yaginuma 提交于
Currently, namespaced scaffold generator will generate an incorrect path and the generated file will not work properly. ``` $ ./bin/rails g scaffold admin/user $ ./bin/rails db:migrate $ ./bin/rails t test/controllers # Running: E Error: Admin::UsersControllerTest#test_should_create_admin_user: NameError: undefined local variable or method `admin_admin_users_url' for #<Admin::UsersControllerTest:0x000055a59f25ff68> Did you mean? admin_users test/controllers/admin/users_controller_test.rb:20:in `block (2 levels) in <class:UsersControllerTest>' test/controllers/admin/users_controller_test.rb:19:in `block in <class:UsersControllerTest>' bin/rails test test/controllers/admin/users_controller_test.rb:18 ``` This is because combine `controller_class_path` and `singular_table_name` to generate route. https://github.com/rails/rails/blob/360698aa245b45349d1d1b12e1afb34759515e69/railties/lib/rails/generators/named_base.rb#L172 Normally, if using namspaced generator, table name already contains namespace. Therefore, adding `controller_class_path` adds extra namespace. Since it is special only when explicitly specifying `model-name`, it is modified to change the value only when `model-name`is specified. Follow up of #30729
-
由 Eileen M. Uchitelle 提交于
Fix Capybara::Webkit::Driver#resize_window deprecation warning
-
- 04 11月, 2017 7 次提交
-
-
由 Eileen M. Uchitelle 提交于
[ci skip] show the correct example to demonstrate inflections.
-
由 Akira Matsuda 提交于
-
由 Ryuta Kamizono 提交于
Improve docs of ActionDispatch::Routing::Mapper [ci skip]
-
由 Ryuta Kamizono 提交于
Remove unused `calculate_rounded_number` and `digit_count`
-
由 yuuji.yaginuma 提交于
These methods unused since 55336960.
-
由 bogdanvlviv 提交于
-
由 Nihad Abbasov 提交于
>[DEPRECATION] Capybara::Webkit::Driver#resize_window is deprecated. Please use Capybara::Window#resize_to instead.
-
- 03 11月, 2017 7 次提交
-
-
由 George Claghorn 提交于
-
由 Ryuta Kamizono 提交于
This reverts commit 6f481e05, reversing changes made to 592f790b. In favor of #31039.
-
由 Ryuta Kamizono 提交于
Fix guides build
-
由 yuuji.yaginuma 提交于
We have already specified to install `bundler` 1.15.4 in `.travis.yml`. https://github.com/rails/rails/blob/master/.travis.yml#L31..L32 However, `bundler` 1.16.0 may be used in the test. https://travis-ci.org/rails/rails/jobs/296582467#L2208 The test failed due to this influence. In order to avoid this, specifying `bundler` version in bug report templates.
-
由 Rafael França 提交于
Remove unused classes
-
由 yuuji.yaginuma 提交于
* `HasManyThroughCantDissociateNewRecords` and `HasManyThroughCantAssociateNewRecords` are no longer used since f6b12c11. * `ReadOnlyAssociation` is no longer used since 0da426be.
-
由 George Claghorn 提交于
-
- 02 11月, 2017 6 次提交
-
-
由 Eileen M. Uchitelle 提交于
[ci skip]Fix typo in comments.
-
由 haneru 提交于
-
由 Ryuta Kamizono 提交于
Fix "warning: instance variable @defined_root not initialized"
-
由 yuuji.yaginuma 提交于
Currently, the following error is shows only when run the test using `bin/test`. ``` ./bin/test -w test/template/log_subscriber_test.rb Run options: --seed 17167 # Running: /rails/actionview/test/template/log_subscriber_test.rb:34: warning: instance variable @defined_root not initialized ``` In `AVLogSubscriberTest`, if the `Rails.root` is not defined, define the method and undef it in teardown. https://github.com/rails/rails/blob/master/actionview/test/template/log_subscriber_test.rb#L21..L33 However, in `bin/test`, `Rails.root` is defined, which results in referring to uninitialized variables and warnings.
-
由 Guillermo Iguaran 提交于
Ignore "gem "bundler" cannot be uninstalled because it is a default gem" error when tested with ruby-head
-
由 Yasuo Honda 提交于
when tested with ruby-head This pull request attempts to ignore the following error when tested with ruby-head which has bundler as a default gem. ```ruby $ rvm @global do gem uninstall bundler --all --ignore-dependencies --executables ERROR: While executing gem ... (Gem::InstallError) gem "bundler" cannot be uninstalled because it is a default gem The command "rvm @global do gem uninstall bundler --all --ignore-dependencies --executables" failed and exited with 1 during . ``` Refer https://travis-ci.org/rails/rails/jobs/295600391 This workaround should be removed once https://github.com/bundler/bundler/issues/6072 is addressed.
-
- 01 11月, 2017 10 次提交
-
-
由 Xavier Noria 提交于
-
由 Aditya Kapoor 提交于
-
由 Jeremy Daer 提交于
Reverts 4d96be1c References #31026
-
由 Rafael França 提交于
Workaround for ActionMailer failures by not installing mail 2.7
-
由 Yasuo Honda 提交于
```ruby TestHelperMailerTest#test_encode BaseTest#test_implicit_multipart_with_attachments_creates_nested_parts BaseTest#test_implicit_multipart_with_attachments_and_sort_order BaseTest#test_explicit_multipart_with_attachments_creates_nested_parts ``` Refer https://travis-ci.org/rails/rails/jobs/295571582
-
由 Guillermo Iguaran 提交于
Remove bundler 1.16.0
-
由 yuuji.yaginuma 提交于
Since 1.16.0 is installed by default, it seems that the newer one will be used even if specify an older version. Ref: https://travis-ci.org/rails/rails/jobs/295553738#L1718 Follow up of #31023
-
由 Guillermo Iguaran 提交于
Avoid bundler 1.16.0 for now
-
由 yuuji.yaginuma 提交于
It's causing bug report template tests to fail. https://travis-ci.org/rails/rails/jobs/295520851 This seems an issue of bundler. Ref: https://github.com/bundler/bundler/issues/6072
-