- 13 4月, 2016 13 次提交
-
-
由 Rafael Mendonça França 提交于
We are using compare_without_coercion.
-
由 Rafael Mendonça França 提交于
extension synonyms yml and yaml
-
由 Rafael França 提交于
Generate `cable.js` file if does not exist when generating channel
-
由 Sean Griffin 提交于
prevent 'attribute_changed?' from returning nil
-
由 Richard Schneeman 提交于
Lesser '.' objects for number helpers
-
由 Xavier Noria 提交于
Note that the fact that mtimes in the future are ignore was documented just a few lines above. Since we know this has to be done, and the code is quite clear due to variable naming, I think we can get rid of the comment in the middle of the loop and shorten it even further.
-
由 Yves Senn 提交于
Guides changelog pass [ci skip]
-
由 Xavier Noria 提交于
Handle max_time edge cases for epoch times and add test
-
由 Blake Mesdag 提交于
-
由 Blake Mesdag 提交于
-
由 Prathamesh Sonpatki 提交于
- Before this, while generating a channel, we were not creating `cable.js` if it does not already exist. - We have similar code for application mailer here - https://github.com/rails/rails/commit/0b3ae023d27197417541932632055cd6be4810c4. - Based on the comment - https://github.com/rails/rails/issues/24418#issuecomment-205421995.
-
由 Sean Griffin 提交于
In 04ac5655 I assumed that we would never want to pass the "table_name.column_name" form to where with a symbol. However, in Ruby 2.2 and later, you can quote symbols using the new hash syntax, so it's a semi-reasonable thing to do if we want to support the dot notation (which I'd rather deprecate, but that would be too painful of a migration). Instead we've changed the definition of "this is a table name with a dot" to when the value associated is a hash. It would make very little sense to write `where("table_name.column_name": { foo: :bar })` in any scenario (other than equality for a JSON column which we don't support through `where` in this way). Close #24514.
-
由 Blake Mesdag 提交于
-
- 12 4月, 2016 17 次提交
-
-
由 Xavier Noria 提交于
Use a single loop in ActiveSupport:FileUpdateChecker#max_mtime
-
由 Blake Mesdag 提交于
-
由 Blake Mesdag 提交于
-
由 Sen-Zhang 提交于
-
由 Santiago Pastorino 提交于
Railties CHANGELOG Pass [ci skip]
-
由 Santiago Pastorino 提交于
Add `config` to the deprecation warnings of deprecated config options
-
由 Jeremy Daer 提交于
speed up ActiveModel::Dirty#attribute_changed?
-
由 Vipul A M 提交于
Encourage best practice in the HTTP Token authentication example code
-
由 Lihan Li 提交于
Benchmark results: Warming up -------------------------------------- old code 32.176k i/100ms new code 34.837k i/100ms Calculating ------------------------------------- old code 1.595M (± 3.5%) i/s - 7.947M new code 1.942M (± 3.9%) i/s - 9.685M
-
由 Nick Malcolm 提交于
[ci skip] This modifies the HTTP Token authentication example's `authenticate` method, to use the `secure_compare` method with two constant-length strings. This defends against timing attacks, and is best practice. Using `==` for sensitive actions is not recommended, and this was the source of a CVE fixed in October 2015: https://github.com/rails/rails/commit/17e6f1507b7f2c2a883c180f4f9548445d6dfbda
-
由 Jeremy Daer 提交于
Clean up all Rails 5 warnings. Revert auto-added periods.
-
由 Vipul A M 提交于
- we are ending sentences properly - fixing of space issues - fixed continuity issues in some sentences. Reverts https://github.com/rails/rails/commit/8fc97d198ef31c1d7a4b9b849b96fc08a667fb02 . This change reverts making sure we add '.' at end of deprecation sentences. This is to keep sentences within Rails itself consistent and with a '.' at the end.
-
由 Ankit Gupta 提交于
Freezing couple of more string '0' & '.' and using the string appending to do the same string manipulation. This was we avoid the duplicate strings with freeze and append modifies existing string
-
由 Vipul A M 提交于
Improved ActionView flows.rb documention [ci skip]
-
由 Alex Mirkhaydarov 提交于
-
由 Xavier Noria 提交于
The pass touches a few minor things. One important aspect is that the wording treats "railtie" as a regular noun. This is so because Railtie is a constant and generally the text refers to "classes that act as railties", which is different. Railties are so fundamental in Rails that deserve a noun, like engine, class, array, application, etc. They have a meaning per se, beyond constants. Also, make clear an extension's railtie does not need to be called "Railtie" or have "Railtie" in their class name.
-
由 Xavier Noria 提交于
Idiomatically trailing hashes in method calls do not use explicit curlies.
-
- 11 4月, 2016 7 次提交
-
-
由 Richard Schneeman 提交于
Cleanup message shown while running destructive action against protected database
-
由 Yves Senn 提交于
Pass over AM changelog [ci skip]
-
由 Xavier Noria 提交于
Rake includes (an extended version of) FileUtils in tasks. It is more idiomatic that they use this provided interface.
-
由 Xavier Noria 提交于
With the exception of what is loaded in active_support/rails, each file is responsible for its own dependencies. You cannot rely on runtime order of execution.
-
由 Ankit Gupta 提交于
Freezing the dots as they are causing extra string initialization on every iteration of calling the helper. Eases on some memory bloat
-
由 Vipul A M 提交于
- Fixed statement about setting `config.action_mailer.default_url_options = {protocol: 'https'}` . We are just setting the protocol key to 'https', not replacing/initializing the complete config. - Fixed grammar in assert_emails changlog - Added sentence separator for code ":" [ci skip]
-
由 Vipul A M 提交于
- Added missing config to complete config names - Fixed route generators changelog grammar. - rake:stats => rake stats - Fixed grammar of assert_file change - Make sure we end all sentences [ci skip]
-
- 10 4月, 2016 3 次提交
-
-
-
由 Vipul A M 提交于
- Made all sentences to end properly [ci skip]
-
由 Prathamesh Sonpatki 提交于
-