- 31 5月, 2016 2 次提交
-
-
由 Sean Griffin 提交于
This behavior was broken by 36e9be85. When the value is assigned directly, either through mass assignment or directly assigning a hash, the hash gets passed through to this writer method directly. While this is intended to handle certain cases, when an explicit converter has been provided, we should continue to use that instead. The positioning of the added guard caused the new behavior to override that case. Fixes #25210
-
由 Sean Griffin 提交于
Currently `exists?` does some hackery where it assumes that we can join onto anything that we passed to `eager_load` or `includes`, which doesn't work if we are joining onto a polymorphic association. Actually figuring out if we want to include something would require knowledge deep within the join dependency module, which is hard to pull up. The simplest solution is just to pass a flag down that says we're not actually going to try to eager load any of the data. It's not the solution I'd like, but that code really needs to be untangled before we can do much with it. This is another attempt at 6d5b1fdf which should address the concerns that led to reverting it in 4ecabed2.
-
- 30 5月, 2016 1 次提交
-
-
由 Robin Dupret 提交于
Add a missing capital letter and avoid using absolute links to the API because they may refer to out-dated documentation on the Edge site.
-
- 28 5月, 2016 2 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
- 27 5月, 2016 2 次提交
-
-
由 Ryuta Kamizono 提交于
`association_for_table` is unused since 50a8cdf0.
-
由 Jon Moss 提交于
Fixes #25128
-
- 25 5月, 2016 4 次提交
-
-
由 Arthur Neves 提交于
-
由 Arthur Neves 提交于
Instead of passing a separete name variable, we can make the resolver merge a name on the config, and use that before creating the Specification.
-
由 Arthur Neves 提交于
-
由 Javan Makhmali 提交于
Introduced in d6f2000a and was only used by Action Cable. Now handled by Action Cable’s assets:compile task.
-
- 24 5月, 2016 1 次提交
-
-
由 Benjamin Quorning 提交于
The `#[]` method *used to be* an alias of `#read_attribute`, but since Rails 4 (10f6f90d), it will raise an exception for missing attributes. Saying that it is an alias is confusing.
-
- 21 5月, 2016 4 次提交
-
-
由 Jon Moss 提交于
[ci skip]
-
由 Erol Fornoles 提交于
-
由 Rafael Mendonça França 提交于
-
由 Jon Moss 提交于
Sorry for forgetting to include it in my original PR
😬 r? @rafaelfranca [ci skip]
-
- 20 5月, 2016 1 次提交
-
-
由 Benjamin Quorning 提交于
After PR https://github.com/rails/rails/pull/24844 the documentation for `#retrieve_connection_pool` was out of date. This commit changes: - the reference from `@class_to_pool` to `@owner_to_pool`. - with newer Rubies, `#fetch` isn't significantly slower than `#[]`. Since Rails 5 requires Ruby >= 2.2.2, we can just use `#fetch` here.
-
- 19 5月, 2016 1 次提交
-
-
由 Jeremy Daer 提交于
Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005 * Forward compat with new unified Integer class in Ruby 2.4+. * Backward compat with separate Fixnum/Bignum in Ruby 2.2 & 2.3. * Drops needless Fixnum distinction in docs, preferring Integer.
-
- 17 5月, 2016 1 次提交
-
-
由 Jahfer Husain 提交于
If a call to #suppress from the same class occurred inside another #suppress block, the suppression state would be set to false before the outer block completes. This change keeps the previous state around in memory and unwinds it as the blocks exit.
-
- 15 5月, 2016 1 次提交
-
-
由 bUg 提交于
-
- 13 5月, 2016 3 次提交
-
-
由 Kang-Kyu Lee 提交于
-
由 Sean Griffin 提交于
The error message that we give today makes this error difficult to debug if you receive it. I have no clue why we're printing the object ID of the class (the commit doesn't give context), but I've left it as it was deliberate.
-
由 Molchanov Andrey 提交于
-
- 12 5月, 2016 4 次提交
-
-
由 Sean Griffin 提交于
When looking for mutation, we compare the serialized version of the value to the before_type_cast form. `Type::Serialized` was breaking this contract by passing the already serialized attribute to the subtype's mutation detection. This never manifested previously, as all mutable subtypes either didn't do anything in their `serialize` method, or had a way to detect double serialization (e.g. `is_a?(String)`). However, now that JSON types can handle string primitives, we need to avoid double serialization. Fixes #24993.
-
由 Ryuta Kamizono 提交于
Rails 5.0 has been dropped Ruby 1.9 support. I think no need magic comment anymore.
-
由 Arthur Neves 提交于
When calling remove_connection in a subclass, that should not fallback to the parent, otherwise it will remove the parent connection from the handler.
-
由 Matthew Erhard 提交于
Using ActiveRecord::Base.attribute to declare an attribute with a default value on a model where the attribute is not backed by the database would raise a NotImplementedError when model.save is called. The error originates from https://github.com/rails/rails/blob/59d252196b36f6afaafd231756d69ea21537cf5d/activerecord/lib/active_record/attribute.rb#L84. This is called from https://github.com/rails/rails/blob/59d252196b36f6afaafd231756d69ea21537cf5d/activerecord/lib/active_record/attribute.rb#L46 on an ActiveRecord::Attribute::Null object. This commit corrects the behavior by implementing ActiveRecord::Attribute::Null#type_cast. With ActiveRecord::Attribute::Null#type_cast defined, ActiveRecord::Attribute::Null#value (https://github.com/rails/rails/blob/59d252196b36f6afaafd231756d69ea21537cf5d/activerecord/lib/active_record/attribute.rb#L173..L175) can be replaced with its super method (https://github.com/rails/rails/blob/59d252196b36f6afaafd231756d69ea21537cf5d/activerecord/lib/active_record/attribute.rb#L36..L40). fixes #24979
-
- 11 5月, 2016 5 次提交
-
-
由 Arthur Neves 提交于
`remove_connection` can reset the `connection_specification_name`, so we need to to set it after the remove_connection call on `establish_connection` method.
-
由 Arthur Neves 提交于
We cannot cache the connection_specification_name when it doesnt exist. Thats because the parent value could change, and we should keep failling back to the parent. If we cache that in a children as an ivar, we would not fallback anymore in the next call, so the children would not get the new parent spec_name.
-
由 yui-knk 提交于
Follow up of #24844. The key of `@owner_to_pool` was changed from `klass.name` to `spec.name`. By this change "memory leaks in development mode" will not happen, bacause the equality of string is not changed by reloading of model files.
-
由 Arthur Neves 提交于
remove_connection When calling `remove_connection` on a model, we delete the pool so we also need to reset the `connection_specification_name` so it will fallback to the parent. This was the current behavior before rails 5, which will fallback to the parent connection pool. [fixes #24959] Special thanks to @jrafanie for working with me on this fix.
-
由 Jon Moss 提交于
If an attribute was of the binary type, and also was a Hash, it would previously not be logged, and instead raise an error saying that `bytesize` was not defined for the `attribute.value` (a `Hash`). Now, as is done on 4-2-stable, the attribute's database value is `bytesize`d, and then logged out to the terminal. Reproduction script: ```ruby require 'active_record' require 'minitest/autorun' require 'logger' ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:') ActiveRecord::Base.logger = Logger.new(STDOUT) ActiveRecord::Schema.define do create_table :posts, force: true do |t| t.binary :preferences end end class Post < ActiveRecord::Base serialize :preferences end class BugTest < Minitest::Test def test_24955 Post.create!(preferences: {a: 1}) assert_equal 1, Post.count end end ```
-
- 10 5月, 2016 4 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Molchanov Andrey 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
- 09 5月, 2016 1 次提交
-
-
由 Molchanov Andrey 提交于
-
- 08 5月, 2016 1 次提交
-
-
由 Jon Moss 提交于
Some slight documentation edits and fixes. Also, run remove unnecessary `RuntimeError`. r? @arthurnn
-
- 07 5月, 2016 2 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Arthur Neves 提交于
[skip ci]
-