- 15 5月, 2018 2 次提交
-
-
由 Ryuta Kamizono 提交于
Add math test
-
由 Nikolai B 提交于
After #449 was merged math can be done on these nodes, adding a test file to unit test all the math operators.
-
- 14 5月, 2018 1 次提交
-
-
由 Yuji Yaginuma 提交于
Don't generate `config/spring.rb` in `app:update` task when spring isn't loaded
-
- 13 5月, 2018 7 次提交
-
-
由 Tsukuru Tanimichi 提交于
-
由 George Claghorn 提交于
Add available transformations to docs
-
由 wata_mac 提交于
`foreign_key`, `json` and `virtual` are also available.
-
由 Ryuta Kamizono 提交于
Follow up of #32605.
-
由 Ryuta Kamizono 提交于
Remove ActiveRecord::Transactions#rollback_active_record_state!
-
由 Ryuta Kamizono 提交于
Don't clear transaction state after manual rollback
-
由 Eugene Kenny 提交于
`rollback_active_record_state!` was removed from `save!` but not `save` in da840d13. I believe that leaving it in `save` was a mistake, since that commit was intended to move the rollback logic from the `save`/`save!` call to the transaction stack. As of 67d8bb96 the record's original state is lazily restored the first time it's accessed after the transaction, instead of when a rollback occurs. This means that the call to `restore_transaction_record_state` here has no effect: the record's transaction level is incremented twice (in rollback_active_record_state! and `with_transaction_returning_status`), isn't decremented again until the the `ensure` block runs, and won't hit zero until the next time `sync_with_transaction_state` is called.
-
- 12 5月, 2018 4 次提交
-
-
由 yuuji.yaginuma 提交于
I'm not sure what originally wanted to pass to the argument. However, as long as see the document added along with the commit, it seems just to be mistaken that trying to pass the error instance. https://github.com/rails/rails/pull/30622/files#diff-59beb0189c8c6bc862edf7fdb84ff5a7R64 Fixes #32853
-
由 Yuji Yaginuma 提交于
Remove unused `remove_file` method
-
由 Eileen M. Uchitelle 提交于
Remove reference to old `:text` rendering option
-
由 Tyler Hunt 提交于
[ci skip]
-
- 11 5月, 2018 3 次提交
-
-
由 Ryuta Kamizono 提交于
`becomes` creates new object and copies attributes from the receiver. If new object has mutation tracker which is created in `after_initialize`, it should be cleared since it is for discarded attributes. But if the receiver doesn't have mutation tracker yet, it will not be cleared properly. It should be cleared regardless of whether the receiver has mutation tracker or not. Fixes #32867.
-
由 Matthew Draper 提交于
Added a lot of Oxford commas
-
由 Anthony Crumley 提交于
[ci skip] A regular expression was used to find a lot of missing Oxford commas and add them. The regular expression was as follows. ", ([a-zA-Z0-9.\`:'\"]+ ){1,6}(or|and) "
-
- 10 5月, 2018 3 次提交
-
-
由 George Claghorn 提交于
Fix Typo In ActiveSupport Instrumentation Guide
-
由 Eugene Kenny 提交于
If an `ActiveRecord::Rollback` error was raised by a persistence method (e.g. in an `after_save` callback), this logic would potentially discard the original state of the record from before the transaction, preventing it from being restored later when the transaction was rolled back.
-
由 Assain 提交于
-
- 09 5月, 2018 3 次提交
-
-
由 Claudio B 提交于
Fix ActiveRecord::AttributeMethods::Dirty documentation
-
由 George Claghorn 提交于
Add option to ActiveStorage::Blob to set extract_content_type_from_io
-
由 Ryan Davidson 提交于
This adds a boolean argument called identify to ActiveStorage::Blob methods #create_after_upload, #build_after_upload and #upload. It allows a user to bypass the automatic content_type inference from the io.
-
- 08 5月, 2018 4 次提交
-
-
由 Tsukuru Tanimichi 提交于
In #32780, We have supported the `--skip-sprockets` option in the `app:update` task. When `options[:api]` is truthy, `option[:skip_sprockets]` is also truthy. So we can remove this `remove_file` method. https://github.com/rails/rails/blob/42b9e7e50c084e119a679cf155b70b5efc4d36ff/railties/lib/rails/generators/rails/app/app_generator.rb#L281-L283
-
由 yuuji.yaginuma 提交于
The prefix of `new` and `edit` generated by `resources` is singular.
-
由 Ryuta Kamizono 提交于
Remove leftover requires
-
由 T.J. Schuck 提交于
* Concurrent::Map usage was removed from this file in 3239ed48 * Monitor usage was removed in f233598d
-
- 07 5月, 2018 5 次提交
-
-
由 Vipul A M 提交于
Fix output in routing.md [ci skip]
-
由 Yuta Uchida 提交于
-
由 Kieran Trezona-le Comte 提交于
Previously the documentation for the newly introduced (in 5.1) AR::Dirty methods was misleading, as it stated the the new methods were aliases for the old methods. This was false, and caused confusion when the differences in their implementation became apparent. This change attempts to describe the behaviour of these methods more accurately, also noting when they are likely to be useful (i.e. before or after saving a record). This change also makes minor updates to consistently format the documentation of this API, in accordance with the API Documentation Guidelines.
-
由 yuuji.yaginuma 提交于
-
由 Ryuta Kamizono 提交于
Follow up of #32034.
-
- 06 5月, 2018 5 次提交
-
-
由 Xavier Noria 提交于
Once all technicalities have been introduced, the purpose of this paragraph is to precisely unroll expressions like "the String class". That way, the reader is forced to clearly separate concepts that Ruby programmers often have kind of blurred: * Constants are storage, like variables. * Ruby does not have syntax for class or module names. * `String` is a regular constant that holds a value. In this case, the value happens to be a class object. * Constants are stored in class and module objects. In the case of `String`, the holder is the class object stored in the `Object` constant. Understanding that paragraph the way is written is important to accomplish this objective. References #32818.
-
由 Vipul A M 提交于
Active Record postgresql documentation for bit string types corrected [ci skip]
-
由 Sagar Kamble 提交于
-
由 Xavier Noria 提交于
I saw these ones while working on #32362. File.write was introduced in Ruby 1.9.3 and it is the most concise way to perform bulk writes (as File.read is for bulk reading). The existing flags enabled binmode, but we are dumping text here. The portable way to dump text is text mode. The only difference is newlines, and portable code should in particular emit portable newlines. Please note the hard-coded \ns are still correct. In languages with C semantics for newlines like Ruby, Python, Perl, and others, "\n" is a portable newline. Both when writing and when reading. On Windows, the I/O layer is responsible for prepending a CR before each LF on writing, and removing CRs followed by LFs on reading. On Unix, binmode is a no-op.
-
- 05 5月, 2018 3 次提交
-
-
由 Yuji Yaginuma 提交于
Don't generate assets' initializer in `app:update` task if sprockets is skipped
-
由 Tsukuru Tanimichi 提交于
Execute `rails new myapp -S` and then upgrade the app by using the `app:update` task, `bin/rails c` results in `NoMethodError`. ``` $ bin/rails app:update $ bin/rails c Traceback (most recent call last): 44: from bin/rails:4:in `<main>' (snip) 1: from /Users/tanimichi.tsukuru/ghq/github.com/moneyforward/moneyplus/config/initializers/assets.rb:4:in `<top (required)>' /Users/tanimichi.tsukuru/ghq/github.com/moneyforward/moneyplus/vendor/bundle/ruby/2.5.0/gems/railties-5.2.0/lib/rails/railtie/configuration.rb:97:in `method_missing': undefined method `assets' for #<Rails::Application::Configuration:0x00007fcb8d3697e0> (NoMethodError) Did you mean? asset_host ```
-
由 Ryuta Kamizono 提交于
Fix logic on disabling afer_commit callbacks
-