1. 04 2月, 2018 4 次提交
  2. 03 2月, 2018 2 次提交
  3. 02 2月, 2018 7 次提交
    • E
      Merge pull request #31868 from y-yagi/fix-build-failures-on-travis · 95f9c9bf
      Eileen M. Uchitelle 提交于
      Fix build failures on Travis
      95f9c9bf
    • E
      Merge pull request #31276 from freeletics/fix-generators-list · 4df5fa26
      Eileen M. Uchitelle 提交于
      Removed "private" generators from command list.
      4df5fa26
    • W
      Removed "private" generators from command list. · c8dc4f2e
      Wojciech Wnętrzak 提交于
      Appropriate way to handle encrypted command is by `bin/rails credentials` and
      `bin/rails encrypted`
      
      It was displayed on `bin/rails generate` command:
      ```
      Please choose a generator below.
      
      Rails:
        application_record
        assets
        channel
        controller
        encrypted_file
        encryption_key_file
        generator
        ...
      ```
      c8dc4f2e
    • G
      Merge pull request #31854 from huacnlee/allow-more-options-for-service-url · 74aa62cb
      George Claghorn 提交于
      Allow ActiveStorage::Blob#service_url to pass addition options to service.url
      74aa62cb
    • Y
      Avoid bundle clean before caching · dff749eb
      yuuji.yaginuma 提交于
      I'm not sure cause, but due to the influence of `gem clean`, the expected
      gem seems not to be installed correctly.
      In order to avoid a test failure due to this, I fixed that `gem clean` not be executed.
      Ref: https://github.com/travis-ci/travis-ci/issues/2518#issuecomment-121168856
      
      This is a workaround. If Travis fixes something, please revert this.
      dff749eb
    • R
      PERF: Recover marshaling dump/load performance (#31827) · 8f2bb58b
      Ryuta Kamizono 提交于
      * PERF: Recover marshaling dump/load performance
      
      This performance regression which is described in #30680 was caused by
      f0ddf87e due to force materialized `LazyAttributeHash`.
      
      Since 95b86e57, default proc has been removed in the class, so it is no
      longer needed that force materialized.
      
      Avoiding force materialized will recover marshaling dump/load
      performance.
      
      Benchmark:
      
      https://gist.github.com/blimmer/1360ea51cd3147bae8aeb7c6d09bff17
      
      Before:
      
      ```
      it took 0.6248569069430232 seconds to unmarshal the objects
      
      Total allocated: 38681544 bytes (530060 objects)
      
      allocated memory by class
      -----------------------------------
        12138848  Hash
        10542384  String
         7920000  ActiveModel::Attribute::Uninitialized
         5600000  ActiveModel::Attribute::FromDatabase
         1200000  Foo
          880000  ActiveModel::LazyAttributeHash
          400000  ActiveModel::AttributeSet
              80  Integer
              72  ActiveRecord::ConnectionAdapters::SQLite3Adapter::SQLite3Integer
              40  ActiveModel::Type::String
              40  ActiveRecord::Type::DateTime
              40  Object
              40  Range
      
      allocated objects by class
      -----------------------------------
          250052  String
          110000  ActiveModel::Attribute::Uninitialized
           70001  Hash
           70000  ActiveModel::Attribute::FromDatabase
           10000  ActiveModel::AttributeSet
           10000  ActiveModel::LazyAttributeHash
           10000  Foo
               2  Integer
               1  ActiveModel::Type::String
               1  ActiveRecord::ConnectionAdapters::SQLite3Adapter::SQLite3Integer
               1  ActiveRecord::Type::DateTime
               1  Object
               1  Range
      ```
      
      After:
      
      ```
      it took 0.1660824950085953 seconds to unmarshal the objects
      
      Total allocated: 13883811 bytes (220090 objects)
      
      allocated memory by class
      -----------------------------------
         5743371  String
         4940008  Hash
         1200000  Foo
          880000  ActiveModel::LazyAttributeHash
          720000  Array
          400000  ActiveModel::AttributeSet
              80  ActiveModel::Attribute::FromDatabase
              80  Integer
              72  ActiveRecord::ConnectionAdapters::SQLite3Adapter::SQLite3Integer
              40  ActiveModel::Type::String
              40  ActiveModel::Type::Value
              40  ActiveRecord::Type::DateTime
              40  Object
              40  Range
      
      allocated objects by class
      -----------------------------------
          130077  String
           50004  Hash
           10000  ActiveModel::AttributeSet
           10000  ActiveModel::LazyAttributeHash
           10000  Array
           10000  Foo
               2  Integer
               1  ActiveModel::Attribute::FromDatabase
               1  ActiveModel::Type::String
               1  ActiveModel::Type::Value
               1  ActiveRecord::ConnectionAdapters::SQLite3Adapter::SQLite3Integer
               1  ActiveRecord::Type::DateTime
               1  Object
               1  Range
      ```
      
      Fixes #30680.
      
      * Keep the `@delegate_hash` to avoid to lose any mutations that have been made to the record
      8f2bb58b
    • R
      Merge pull request #31859 from bogdanvlviv/add-changelog-entry-for-31844 · 2417f3c5
      Rafael França 提交于
      Add changelog entry for #31844
      2417f3c5
  4. 01 2月, 2018 10 次提交
  5. 31 1月, 2018 15 次提交
  6. 30 1月, 2018 2 次提交