1. 29 10月, 2016 2 次提交
  2. 28 10月, 2016 2 次提交
  3. 27 10月, 2016 4 次提交
    • M
      Fix HABTM associations join table resolver bug on constants and symbols · 94821b4b
      Mehmet Emin İNAÇ 提交于
      Using Constant and symbol class_name option for associations are valid but raises exception on HABTM associations.
      There was a test case which tries to cover symbol class_name usage but doesn't cover correctly. Fixed both symbol usage and constant usage as well.
      
      These are all working as expected now;
      ```
        has_and_belongs_to_many :foos, class_name: 'Foo'
        has_and_belongs_to_many :foos, class_name: :Foo
        has_and_belongs_to_many :foos, class_name: Foo
      ```
      
      Closes #23767
      94821b4b
    • X
      7506f339
    • X
      let Regexp#match? be globally available · 56832e79
      Xavier Noria 提交于
      Regexp#match? should be considered to be part of the Ruby core library. We are
      emulating it for < 2.4, but not having to require the extension is part of the
      illusion of the emulation.
      56832e79
    • S
      Clear the correct query cache · fa7efca5
      Samuel Cochran 提交于
      This executor currently relies on `ActiveRecord::Base.connection` not
      changing between `prepare` and `complete`. If something else returns
      the current ActiveRecord connection to the pool early then this
      `complete` call will fail to clear the correct query cache and restore
      the original `query_cache_enabled` status.
      
      This has for example been happening in Sidekiq:
      
           https://github.com/mperham/sidekiq/pull/3166
      
      We can just keep track of the connection as part of the exector state.
      fa7efca5
  4. 26 10月, 2016 1 次提交
  5. 25 10月, 2016 2 次提交
  6. 24 10月, 2016 1 次提交
  7. 23 10月, 2016 4 次提交
  8. 22 10月, 2016 3 次提交
  9. 21 10月, 2016 1 次提交
    • A
      Use old typecasting method if no type casted binds are passed in · 13455110
      Aaron Patterson 提交于
      Query cache doesn't type cast bind parameters since it isn't
      actually querying the database, so it can't pass those values in.  Type
      casting in the query cache method would cause the values to be type cast
      twice in the case that there is a cache miss (since the methods it calls
      will type cast *again*).  If logging is disabled, then adding the type
      cast code to the query cache method will needlessly typecast the values
      (since the only reason those values are type cast is for display in the
      logs).
      
      Fixes #26828.
      13455110
  10. 20 10月, 2016 2 次提交
  11. 19 10月, 2016 1 次提交
  12. 14 10月, 2016 2 次提交
  13. 12 10月, 2016 1 次提交
    • R
      Fix `warning: ambiguous first argument` · f53f69bd
      Ryuta Kamizono 提交于
      ```
      test/cases/adapters/postgresql/case_insensitive_test.rb:12: warning: ambiguous first argument; put parentheses or a space even after `/' operator
      test/cases/adapters/postgresql/case_insensitive_test.rb:16: warning: ambiguous first argument; put parentheses or a space even after `/' operator
      test/cases/adapters/postgresql/case_insensitive_test.rb:20: warning: ambiguous first argument; put parentheses or a space even after `/' operator
      test/cases/adapters/postgresql/case_insensitive_test.rb:24: warning: ambiguous first argument; put parentheses or a space even after `/' operator
      ```
      f53f69bd
  14. 11 10月, 2016 2 次提交
  15. 10 10月, 2016 2 次提交
    • R
      `name` is not a column option · 24a1a6a8
      Ryuta Kamizono 提交于
      `migration_keys` includes `name` but `name` is not a column option.
      24a1a6a8
    • R
      Dump index options to pretty format · 5025fd3a
      Ryuta Kamizono 提交于
      ```ruby
        # Before
        t.index ["firm_id", "type", "rating"], name: "company_index", order: {"rating"=>:desc}, using: :btree
      
        # After
        t.index ["firm_id", "type", "rating"], name: "company_index", order: { rating: :desc }, using: :btree
      ```
      5025fd3a
  16. 08 10月, 2016 4 次提交
  17. 07 10月, 2016 1 次提交
  18. 04 10月, 2016 1 次提交
  19. 03 10月, 2016 4 次提交