- 15 3月, 2020 2 次提交
-
-
由 Kasper Timm Hansen 提交于
Use latest version of SDoc
-
由 Robin Dupret 提交于
Cross-refs zzak/sdoc#138. [John Hawthorn]
-
- 14 3月, 2020 9 次提交
-
-
由 Quinn Chaffee 提交于
* `expires_in` `extras` documentation Wanted to find how to add `s-maxage` and stumbled across this feature. Wanted to document it for others, but many proxies like Akamai are very insistent on using `s-maxage` rather than `max-age`. * Altered verbiage and fixed spelling
-
由 Kasper Timm Hansen 提交于
Isolate ARGV in Rails::Command.invoke
-
由 Joel Hawksley 提交于
-
由 Eileen M. Uchitelle 提交于
Refactor fetch_attribute
-
由 Eileen M. Uchitelle 提交于
Remove convenience class alias
-
由 Kasper Timm Hansen 提交于
Fix warning: method redefined
-
由 eileencodes 提交于
This convenience class is only used twice in Arel. We can easily write it out instead.
-
由 eileencodes 提交于
Similar to the work done in #38636, instead of using case statements we can make these classes respond to `fetch_attribute`. New classes can implement `fetch_attribute` instead of adding to the case statement, it's more object oriented, and nicer looking. Co-authored-by: NAaron Patterson <aaron.patterson@gmail.com>
-
由 utilum 提交于
-
- 13 3月, 2020 10 次提交
-
-
由 Kasper Timm Hansen 提交于
Fix variable not initialized warnings
-
由 utilum 提交于
``` activesupport/test/concern_test.rb:20: warning: instance variable @included_ran not initialized activesupport/test/concern_test.rb:28: warning: instance variable @prepended_ran not initialized ```
-
由 Rafael França 提交于
Extract building ActiveRecord::Result into a method
-
由 Kir Shatrov 提交于
-
由 Rafael França 提交于
Update code snippets to suggest the use of strong parameters
-
由 Rafael França 提交于
refactor: arel fetch_attribute to get the atrribute node from binary module.
-
由 Rafael França 提交于
Correct the parameter name for deserialize
-
由 Aaron Patterson 提交于
Rails::Command.invoke wants kwargs, so give it kwargs
-
由 Aaron Patterson 提交于
This fixes an exception when generating a new app on Ruby 2.8. Before this commit, I get this exception: ``` $ be ruby railties/exe/rails new ~/git/fix-bug --dev ... ... Traceback (most recent call last): 31: from railties/exe/rails:10:in `<main>' 30: from railties/exe/rails:10:in `require' 29: from /Users/aaron/git/rails/railties/lib/rails/cli.rb:18:in `<top (required)>' 28: from /Users/aaron/git/rails/railties/lib/rails/command.rb:45:in `invoke' 27: from /Users/aaron/git/rails/railties/lib/rails/command/base.rb:69:in `perform' 26: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor.rb:392:in `dispatch' 25: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/invocation.rb:127:in `invoke_command' 24: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/command.rb:27:in `run' 23: from /Users/aaron/git/rails/railties/lib/rails/commands/application/application_command.rb:26:in `perform' 22: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/base.rb:485:in `start' 21: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/group.rb:232:in `dispatch' 20: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/invocation.rb:134:in `invoke_all' 19: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/invocation.rb:134:in `map' 18: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/invocation.rb:134:in `each' 17: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/invocation.rb:134:in `block in invoke_all' 16: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/invocation.rb:127:in `invoke_command' 15: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/command.rb:27:in `run' 14: from (eval):1:in `run_webpack' 13: from /Users/aaron/git/rails/railties/lib/rails/generators/app_base.rb:419:in `run_webpack' 12: from /Users/aaron/git/rails/railties/lib/rails/generators/actions.rb:255:in `rails_command' 11: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/actions.rb:197:in `in_root' 10: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/actions.rb:187:in `inside' 9: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/2.8.0/fileutils.rb:139:in `cd' 8: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/2.8.0/fileutils.rb:139:in `chdir' 7: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/actions.rb:187:in `block in inside' 6: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/actions.rb:197:in `block in in_root' 5: from /Users/aaron/git/rails/railties/lib/rails/generators/actions.rb:256:in `block in rails_command' 4: from /Users/aaron/git/rails/activesupport/lib/active_support/core_ext/kernel/reporting.rb:15:in `silence_warnings' 3: from /Users/aaron/git/rails/activesupport/lib/active_support/core_ext/kernel/reporting.rb:28:in `with_warnings' 2: from /Users/aaron/git/rails/activesupport/lib/active_support/core_ext/kernel/reporting.rb:15:in `block in silence_warnings' 1: from /Users/aaron/git/rails/railties/lib/rails/generators/actions.rb:257:in `block (2 levels) in rails_command' /Users/aaron/git/rails/railties/lib/rails/command.rb:31:in `invoke': wrong number of arguments (given 3, expected 1..2) (ArgumentError) ``` After this commit, things seem to work.
-
由 Rafael França 提交于
Include rack-mini-profiler gem by default
-
- 12 3月, 2020 7 次提交
-
-
由 Rafael Mendonça França 提交于
Revert "Merge pull request #38710 from Madogiwa0124/remove_unecessary_require_from_active_support_time" This reverts commit ffdce018, reversing changes made to d2d8b289. This change behavior for applications that require core_ext/integer/time since it will not load the numeric extensions anymore.
-
由 Rafael França 提交于
Disable colorize logging of SQL and reduce unnecessary invocation of sql_color matching
-
由 Rafael França 提交于
Removed unnecessary require 'core_ext/numeric/time'.
-
由 Madogiwa 提交于
Previously it depended on `core_ext/numeric/time`, but now it doesn't, so we removed require. Previous code ``` ruby class Integer def months ActiveSupport::Duration.new(self * 30.days, [[:months, self]]) end alias :month :months def years ActiveSupport::Duration.new(self * 365.25.days, [[:years, self]]) end alias :year :years end ``` Now the code ``` ruby class Integer def months ActiveSupport::Duration.months(self) end alias :month :months def years ActiveSupport::Duration.years(self) end alias :year :years end ```
-
由 Rafael França 提交于
Updates to ActiveJob::Exceptions.retry_on with jitter documentation [skip ci]
-
由 Rafael França 提交于
AJ `perform_enqueued_jobs` shouldn't perform job retries:
-
由 Aditya Narsapurkar 提交于
- Changelog updated - Method documentation updated
-
- 11 3月, 2020 6 次提交
-
-
由 OsamaSayegh 提交于
-
由 Abhay Nikam 提交于
When the `colorize_logging` is disabled, logs do not colorize the SQL queries. But the `sql_color` method is always invoked which due to regex matching results in slow queries. This PR fixes #38685 and removes unnecessary invokation of `sql_color` method when `colorize_logging` is disabled
-
由 Rafael França 提交于
[skip ci] How to run Action View and Action Pack unit test in serial
-
由 Rafael França 提交于
Fix exceptions raised/rescued in dev by IPAddr
-
由 Nate Berkopec 提交于
Putting ".localhost" at the end causes 4 IPAddr::InvalidAddressError exceptions to be raised and rescued during every request when the HostAuthorization middleware attempts to compare an IPAddr with a "localhost" string.
-
由 Dino Maric 提交于
This PR adds `image/webp` to the default array of variable content types. Without this commit if we want to "handle" webp images overwriting `config.active_storage.variable_content_types` was necessary.
-
- 10 3月, 2020 6 次提交
-
-
由 Yasuo Honda 提交于
Follow up #38613 and #38094 Action View and Action Pack unit tests run in parallel by default and the number of parallel workers is defined by `PARALLEL_WORKERS` value. To investigate some random failures with SEED, Disabling Parallel testing sometimes helps to isolate these failures.
-
由 Yash Ladha 提交于
module. Reason for doing this change is to pull the node specific changes to module itself and to not infer on the attributes, rather than assign responsibility to the member functions to do so.
-
由 Ryuta Kamizono 提交于
-
由 Rafael França 提交于
Clarify index_by and index_with docs [ci skip]
-
由 Edouard CHIN 提交于
- ### Problem If we use `perform_enqueued_jobs` without a block, a job that uses a retry mechanism to reeenqueue itself would get performed right away. This behaviour make sense when using `perform_enqueued_jobs` with a block. However I'm expecting `perform_enqueued_jobs` without a block to perform jobs that are **already** in the queue not the ones that will get enqueued afterwards. ### Solution Dup the array of jobs given to avoid future mutation.
-