- 24 2月, 2016 11 次提交
-
-
由 Jon Moss 提交于
Fix typo in Form Helpers Guide
-
由 Matthew Draper 提交于
Fix `request.ssl?` bug with Action Cable
-
由 Michael Groeneman 提交于
-
由 Michael Groeneman 提交于
-
由 eileencodes 提交于
In order to fix issue #17621 we added a check to validations that determined if a record should be validated. Based on the existing tests and behavior we wanted we determined the best way to do that was by checking if `!record.peristed? || record.changed? || record.marked_for_destruction?` This change didn't make it into a release until now. When #23790 was opened we realized that `valid?` and `invalid?` were broken and did not work on persisted records because of the `!record.persisted?`. While there is still a bug that #17621 brought up, this change was too drastic and should not be a RC blocker. I will work on fixing this so that we don't break `valid?` but also aren't validating parent records through child records if that parent record is validate false. This change removes the code changes to validate and the corresponding tests. It adds tests for two of the bugs found since Rails 5 beta2 release. Fixes #17621
-
由 Richard Schneeman 提交于
Alternative to #23638 log to STDOUT via env var
-
由 Aaron Patterson 提交于
otherwise we don't get the log messages we're looking for and the tests fail intermittently.
-
由 Sean Griffin 提交于
Fix issue #23625
-
由 Rafael França 提交于
Merge pull request #23789 from wisetara/wisetara/deprecate-args-ActiveSupport__TestCase#assert_nothing_raised-for-pr Wisetara/deprecate args active support test case#assert nothing raised for pr
-
由 Aaron Patterson 提交于
creating all databases mutates the connection pool. This patch restores the connection pool to the connection spec established before creating all databases. Fixes #23279
-
- 23 2月, 2016 29 次提交
-
-
由 David Heinemeier Hansson 提交于
Improve Action Cable reconnection reliability
-
由 Javan Makhmali 提交于
-
由 Javan Makhmali 提交于
-
由 Javan Makhmali 提交于
Ensures we don't get "onclose" events from a previous WebSocket that was in the "closing" state
-
由 Javan Makhmali 提交于
-
由 Pratik Naik 提交于
-
由 Pratik Naik 提交于
-
由 Pratik Naik 提交于
We are seeing cases where the websockets get stuck in the 'closing' state after a tab has been in background for a while. So lets treat those websockets as closed.
-
由 Javan Makhmali 提交于
-
由 Rafael Mendonça França 提交于
We are creating the table but not deleting after the test.
-
由 Rafael França 提交于
Remove needless `drop_table :test_limits`
-
由 Ryuta Kamizono 提交于
A `:test_limits` table has not been created.
-
-
-
-
由 Rafael França 提交于
Prevent ActionMailer initializer from triggering load of ActionMailer
-
由 Matthew Draper 提交于
Merge pull request #23419 from prathamesh-sonpatki/fix-showing-of-deprecation-warning-for-legacy-migrations Correctly show deprecation warning for incompatible migrations
-
由 Dave Gynn 提交于
the after_initialize block has been changed to use the configuration from `config.action_mailer` rather than `ActionMailer::Base` so that action mailer is not loaded before it is necessary. the mailer preview routes setup have been moved out of an `on_load(:action_mailer)` block.
-
由 Rafael França 提交于
Action Cable readme fix [ci skip]
-
由 Mehmet Emin İNAÇ 提交于
-
由 Rafael França 提交于
Add `internal` attribute to routes
-
由 Rafael França 提交于
Full Action Cable documentation read through
-
由 Rafael França 提交于
Assorted Railties generators work
-
由 Jon Moss 提交于
Once RubyGems 2.5.0 is required, then the duplicated files can be removed, and symlinks can be used instead. [ci skip]
-
由 Jon Moss 提交于
-
由 Jon Moss 提交于
-
由 Jon Moss 提交于
-
由 Jon Moss 提交于
This is meant to provide a way for Action Cable, Sprockets, and possibly other Rack applications to mark themselves as internal, and to exclude themselves from the routing inspector, and thus `rails routes` / `rake routes`. I think this is the only way to have mounted Rack apps be marked as internal, within AD/Journey. Another option would be to create an array of regexes for internal apps, and then to iterate over that everytime a request comes through. Also, I only had the first `add_route` method set `internal`'s default to false, to avoid littering it all over the codebase.
-
由 Rafael França 提交于
Make sure the parameter parsers register API work with overidden mime types.
-