We have hit dramatic increase in tests time after upgrading rails.
Profiling revealed this particular place. After this fix our test times returned
back to norm.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1173 state:committed]

This fixes connection pool exhaustion for web servers which create new thread per connection (e.g. Webrick).

integration.rb changes are required to keep test transaction active for several requests.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1171 state:committed]

Signed-off-by: NMichael Koziarski <michael@koziarski.com>

[#1169 state:committed]

After releasing monitor some connection(s) may appear in pool before monitor is re-aquired.
When this happens we'll wait for connection which is already available.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>

Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1168 state:committed]

[#983 state:committed]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

Usage : rails app_name -d ibm_db
Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

Make sure recreate MySQL test database with the proper encoding and collation [#1165 state:resolved]
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1165 state:committed]

added nicer failure reporting to #assert_difference to tell you the expression that failed rather than just the expected and actual values
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1161 state:committed]

Signed-off-by: NMichael Koziarski <michael@koziarski.com>

[#1144 state:committed]

Dynamic finders should use the ActiveRecord::Base::find method instead of ::find_initial, :find_last, and ::find_all.

This is so when people override ActiveRecord::Base::find, the new ::find method will also be invoked by the dynamic finders.
Associations for instance do go through ::find, so this makes it more consistent.
Also removed the unnecessary deprecation silence blocks.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>

[#1162 state:committed]

Signed-off-by: NJoshua Peek <josh@joshpeek.com>

Add tests too.

Signed-off-by: NMichael Koziarski <michael@koziarski.com>

wrote a test showing eager loading's misbehavior (sanitizing against the wrong table) when the association has a :conditions hash
Signed-off-by: NMichael Koziarski <michael@koziarski.com>

Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1116 state:committed]

Ignore all exceptions for validates_acceptance_of columns fetch so it can run even without a database connection
Signed-off-by: NMichael Koziarski <michael@koziarski.com>

Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1084 state:committed]

We shouldn't quote the unpack command's requirement as it's passed through GemRunner which takes care of it for us.

Add an additional conditions option to make it slightly easier for certain plugins.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1087 state:committed]

Allowed passing arrays-of-strings to :join everywhere. Merge duplicate join strings to avoid table aliasing problems.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1077 state:committed]

AssociationCollection now starts transactions by calling
AssociationCollection#transaction instead of @owner.transaction or
@reflection.klass.transaction.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>

[#1081 state:committed]

Signed-off-by: NMichael Koziarski <michael@koziarski.com>

[#1096 state:committed]

Signed-off-by: NMichael Koziarski <michael@koziarski.com>

Modified ActiveSupport::Inflector#parameterize with code from slugalizer (http://github.com/henrik/slugalizer)

Handles trailing and leading slashes, and squashes repeated separators into a single character.
Signed-off-by: NMichael Koziarski <michael@koziarski.com>
[#1034 state:committed]

This allows people tracking non-release gems or git submodules to use the constants.

Signed-off-by: NJoshua Peek <josh@joshpeek.com>

Signed-off-by: NPratik Naik <pratiknaik@gmail.com>

Signed-off-by: NPratik Naik <pratiknaik@gmail.com>