1. 13 3月, 2019 9 次提交
    • K
      Modernize size calculation in Schema Cache · f45084c7
      Kasper Timm Hansen 提交于
      Not looking for other contributions like this, but I took the liberty
      since I was already working on this.
      f45084c7
    • R
      Merge pull request #35591 from nisusam/update_link_sign_release · 8b3d2d1a
      Ryuta Kamizono 提交于
      Update URL in RELEASING_RAILS.md [ci skip]
      8b3d2d1a
    • N
      Update URL in RELEASING_RAILS.md [ci skip] · 86230b56
      nisusam 提交于
      * Update valid link for `signing release tag` from `git-scm` book
      * Use `en`(English) instead of `tr`(Turkish) documentation link
      86230b56
    • R
      Remove unused `Row` class in `SelectManager` · 386e2c73
      Ryuta Kamizono 提交于
      The `Row` class is no longer used since d956772b.
      386e2c73
    • R
      Initialize `@default_timezone` and `@timestamp_decoder` in `add_pg_decoders` · 40316aa9
      Ryuta Kamizono 提交于
      Staled `@default_timezone` would cause an error on `reconnect!` after
      `disconnect!`.
      
      https://buildkite.com/rails/rails/builds/59495#23be8079-3a4f-4375-9991-0a6f874554f2
      
      Steps to reproduce:
      
      ```
      % ARCONN=postgresql bin/test test/cases/adapter_test.rb test/cases/base_test.rb -n "/(?:test_attributes_on_dummy_time|test_reconnect_after_a_disconnect)$/" --seed 15849
      Using postgresql
      Run options: -n "/(?:test_attributes_on_dummy_time|test_reconnect_after_a_disconnect)$/" --seed 15849
      
      # Running:
      
      .
      E
      
      Error:
      ActiveRecord::AdapterTestWithoutTransaction#test_reconnect_after_a_disconnect:
      NoMethodError: undefined method `add_coder' for #<PG::TypeMapAllStrings:0x00007f85ab9dd5b8>
          /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:866:in `update_typemap_for_default_timezone'
          /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:652:in `exec_no_cache'
          /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:636:in `execute_and_clear'
          /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:894:in `add_pg_decoders'
          /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:744:in `connect'
          /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:285:in `rescue in block in reconnect!'
          /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:281:in `block in reconnect!'
          /Users/kamipo/.rbenv/versions/2.6.1/lib/ruby/2.6.0/monitor.rb:230:in `mon_synchronize'
          /Users/kamipo/src/github.com/rails/rails/activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb:280:in `reconnect!'
          /Users/kamipo/src/github.com/rails/rails/activerecord/test/cases/adapter_test.rb:465:in `block in <class:AdapterTestWithoutTransaction>'
      ```
      40316aa9
    • R
      Merge pull request #35585 from sharang-d/changelog-update · 1816c4f6
      Rafael França 提交于
      Edit a changelog entry [ci skip]
      1816c4f6
    • E
      Merge pull request #35583 from cpruitt/add-addititonal-tests-for-dummy-erb · 6d7c4ae6
      Eileen M. Uchitelle 提交于
      Add additional ERB DummyCompiler tests
      6d7c4ae6
    • V
      Merge pull request #35577 from sharang-d/typo-opt-out · 2fa03e62
      Vipul A M 提交于
      Change wording of some instances of 'opt out' [ci skip]
      2fa03e62
    • R
      Merge pull request #35586 from KurtRMueller/master · 580dddc3
      Ryuta Kamizono 提交于
      Update small typo in documentation.
      580dddc3
  2. 12 3月, 2019 24 次提交
  3. 11 3月, 2019 7 次提交