- 17 12月, 2015 19 次提交
-
-
由 Sean Griffin 提交于
I didn't mean to commit that!
-
由 Sean Griffin 提交于
Unlike unix, the TZ variable on Windows does not look at a database. It is always expected to be in the form {Standard Time Abbreviation}{UTC-Offset}{Daylight Time Abbriviation}. This changes the relevant tests to use the Windows form when run from Windows.
-
由 Rafael Mendonça França 提交于
[ci skip]
-
由 Sean Griffin 提交于
Add `redirect_to_back_or_default`
-
由 Sean Griffin 提交于
When this test was run on Windows, the database file would still be in use, and `File.unlink` would fail. This would cause the temp directory to be unable to be removed, and error out. By disconnecting the connection when finished, we can avoid this error.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Kasper Timm Hansen 提交于
Use Module.prepend instead of alias_method for Range#to_s
-
由 Rafael França 提交于
Don't leak Object constants in core_ext/module/qualified_const
-
由 Sean Griffin 提交于
"conditionals in the gemfile creates conditional code in the Gemfile.lock. Since it is checked in the repository I think it is better to avoid it"
-
由 Genadi Samokovarov 提交于
-
由 Bernard Potocki 提交于
-
由 Sean Griffin 提交于
bcrypt 3.1.0 doesn't load on Windows. See https://github.com/codahale/bcrypt-ruby/issues/128 for details.
-
由 Derek Prior 提交于
Applications that use `redirect_to :back` can be forced to 500 by clients that do not send the HTTP `Referer` (sic) header. `redirect_back` requires the user to consider this possibility up front and avoids this trivially-caused application error.
-
由 Derek Prior 提交于
`redirect_to :back` is a somewhat common pattern in Rails apps, but it is not completely safe. There are a number of circumstances where HTTP referrer information is not available on the request. This happens often with bot traffic and occasionally to user traffic depending on browser security settings. When there is no referrer available on the request, `redirect_to :back` will raise `ActionController::RedirectBackError`, usually resulting in an application error. `redirect_back` takes a required `fallback_location` keyword argument that specifies the redirect when the referrer information is not available. This prevents 500 errors caused by `ActionController::RedirectBackError`.
-
由 Rafael França 提交于
Introduce ApplicationRecord, an Active Record layer supertype
-
由 Sean Griffin 提交于
It appears that MRI on Windows can also appear as `:mingw`, if it was installed via RubyInstaller.
-
由 Rafael França 提交于
Delete dead code comments
-
由 Sean Griffin 提交于
platform `:ruby` is only MRI on Linux or Mac. Windows MRI shows up as `:mswin` or `:mswin64` depending on if it was installed as 32 or 64 bit. I am unsure if this will cause conflicts with JRuby on Windows, but I don't have the means to test this at the moment.
-
- 16 12月, 2015 19 次提交
-
-
由 Rafael França 提交于
Deprecate passing string to define callback.
-
由 Rafael França 提交于
Fix a couple of grammatical errors in security.md
-
由 Eileen M. Uchitelle 提交于
Mention the correct way to halt callback chains
-
由 Carlos Souza 提交于
The previous title was misleading. [ci skip]
-
由 Existent Ltd 提交于
-
由 yui-knk 提交于
-
由 Genadi Samokovarov 提交于
It's pretty common for folks to monkey patch `ActiveRecord::Base` to work around an issue or introduce extra functionality. Instead of shoving even more stuff in `ActiveRecord::Base`, `ApplicationRecord` can hold all those custom work the apps may need. Now, we don't wanna encourage all of the application models to inherit from `ActiveRecord::Base`, but we can encourage all the models that do, to inherit from `ApplicationRecord`. Newly generated applications have `app/models/application_record.rb` present by default. The model generators are smart enough to recognize that newly generated models have to inherit from `ApplicationRecord`, but only if it's present.
-
由 Tony Ta 提交于
-
由 Tony Ta 提交于
ActiveSupport::Multibyte::Unicode::Codepoint doesn't support this API
-
由 Tony Ta 提交于
-
由 Tony Ta 提交于
-
由 Tony Ta 提交于
-
由 eileencodes 提交于
-
由 eileencodes 提交于
Running railties generated app tests in development env can cause unintended consequences. The environments are different and tests aren't meant to be run in development mode. The changes to the generator exposed this issue where the random test order in the generated apps could cause problems when those tests are run in development mode. Particularly we saw failures in `railties/test/application/rake_test.rb` generated apps that used the scaffold to create applications and then run the migration and immediately run the tests. The error we saw was `ActiveRecord::RecordNotFound: Couldn't find User with 'id'=980190962` and seemed to only occur if the destroy test ran first. I'm not entirely sure _why_ this causes that error to be thrown but I believe it is related to the environments being different.
-
由 Abdelkader Boudih 提交于
In Rails 5.1 `ActionController::TestCase` will be moved out of Rails into it's own gem. Please use `ActionDispatch::IntegrationTest` going forward. This changes the generators to use `ActionDispatch::IntegrationTest` and the required URL setup (rather than symbols) for each of the controller actions. Updated fix to #22076.
-
由 Santiago Pastorino 提交于
We will wait until 5.1 to make a decision
-
由 Jeremy Daer 提交于
Allow users to pass flags from database.yml
-
由 Sean Griffin 提交于
Handle tab in token authentication header.
-
由 Rafael Mendonça França 提交于
-
- 15 12月, 2015 2 次提交
-
-
由 Eileen M. Uchitelle 提交于
remove extra spaces from deprecation message
-
由 Stephen Blackstone 提交于
Fix white-space Add test case demonstrating flags are received by the adapter
-