Skip to content

R
rails

张重言 / rails

通知 1
Star 0
Fork 0
R
rails

前往新版Gitcode，体验更适合开发者的 AI 搜索 >>

切换分支/标签
  1. 19 12月, 2019 2 次提交
  3. 14 12月, 2019 1 次提交
  5. 10 12月, 2019 1 次提交
  7. 27 11月, 2019 1 次提交
  9. 23 11月, 2019 2 次提交
  11. 05 11月, 2019 1 次提交
  13. 01 11月, 2019 1 次提交
  15. 20 10月, 2019 1 次提交
  17. 11 10月, 2019 1 次提交
  19. 10 10月, 2019 1 次提交
  21. 03 9月, 2019 1 次提交
  23. 17 8月, 2019 2 次提交
  25. 10 8月, 2019 1 次提交
  27. 09 8月, 2019 1 次提交
  29. 07 8月, 2019 1 次提交
    • E
      Fix Gemfile.lock · fb716a65
      由 eileencodes 提交于 
      The PR #36860 changed ActionView's required version of
rails-html-sanitizer, but I missed that we needed to run
bundle, otherwise we end up with changes every time.
      fb716a65
  31. 05 8月, 2019 1 次提交
  33. 23 7月, 2019 1 次提交
  35. 07 7月, 2019 2 次提交
  37. 01 7月, 2019 1 次提交
    • X
      bumps Zeitwerk · f51fae1f
      由 Xavier Noria 提交于 
      This version makes eager loading and autoloading consistent,
as documented in the upgrading guide.
      f51fae1f
  39. 25 4月, 2019 1 次提交
  41. 23 4月, 2019 1 次提交
    • X
      upgrades Zeitwerk to 2.1.4 · 1b2efe5a
      由 Xavier Noria 提交于 
      This commit more or less undoes 9b5401fc, restores autoloaded? not to
touch the descendants tracker, and autoloaded_constants because it is
documented in the guide.
      1b2efe5a
  43. 18 4月, 2019 1 次提交
  45. 16 4月, 2019 1 次提交
    • K
      Bump RuboCop to 0.67.2 · c6379fd2
      由 Koichi ITO 提交于 
      Performance cops will be extracted from RuboCop to RuboCop Performance
when next RuboCop 0.68 will be released.
https://github.com/rubocop-hq/rubocop/issues/5977

RuboCop 0.67 is its transition period.

Since rails/rails repository uses Performance cops, This PR added
rubocop-performance gem to Gemfile.

And this PR fixes some offenses using the following auto-correct.

```console
% bundle exec rubocop -a

Offenses:

activerecord/test/cases/connection_adapters/connection_handlers_multi_db_test.rb:212:26:
C: [Corrected] Layout/SpaceAroundOperators: Operator =
> should be surrounded by a single space.
              "primary"  => { adapter: "sqlite3", database: "db/primary.sqlite3" }
                         ^^
activerecord/test/cases/connection_adapters/connection_handlers_multi_db_test.rb:239:26:
C: [Corrected] Layout/SpaceAroundOperators: Operator => should be
surrounded by a single space.
              "primary"  => { adapter: "sqlite3", database: "db/primary.sqlite3" }
                         ^^
actionview/test/template/resolver_shared_tests.rb:1:1: C: [Corrected]
Style/FrozenStringLiteralComment: Missing magic comment #
frozen_string_literal: true.
module ResolverSharedTests
^
actionview/test/template/resolver_shared_tests.rb:10:33: C: [Corrected]
Layout/SpaceAroundEqualsInParameterDefault: Surrounding space missing in
default value assignment.
  def with_file(filename, source="File at #{filename}")
                                ^
actionview/test/template/resolver_shared_tests.rb:106:5: C: [Corrected]
Rails/RefuteMethods: Prefer assert_not_same over refute_same.
    refute_same a, b
    ^^^^^^^^^^^

2760 files inspected, 5 offenses detected, 5 offenses corrected
```
      c6379fd2
  47. 12 4月, 2019 1 次提交
    • X
      improves the reloading disabled error message · 7b6b1054
      由 Xavier Noria 提交于 
      The original message from Zeitwerk is "can't reload, please call
loader.enable_reloading before setup (Zeitwerk::Error)", which is not
very informative for Rails programmers.

Rails should err with a message worded in terms of its interface.
      7b6b1054
  49. 09 4月, 2019 1 次提交
  51. 07 4月, 2019 1 次提交
  53. 05 4月, 2019 1 次提交
  55. 04 4月, 2019 2 次提交
    • F
      Output junit format test report · 61c4be47
      由 Fumiaki MATSUSHIMA 提交于
      61c4be47
    • R
      Use `execute_batch2` rather than `execute_batch` to fix performance regression for fixture loading · 0908184e
      由 Ryuta Kamizono 提交于 
      d8d6bd5e makes fixture loading to bulk statements by using
`execute_batch` for sqlite3 adapter. But `execute_batch` is slower and
it caused the performance regression for fixture loading.

In sqlite3 1.4.0, it have new batch method `execute_batch2`. I've
confirmed `execute_batch2` is extremely faster than `execute_batch`.
So I think it is worth to upgrade sqlite3 to 1.4.0 to use that method.

Before:

```
% ARCONN=sqlite3 bundle exec ruby -w -Itest test/cases/associations/eager_test.rb -n test_eager_loading_too_may_ids
Using sqlite3
Run options: -n test_eager_loading_too_may_ids --seed 35790

# Running:

.

Finished in 202.437406s, 0.0049 runs/s, 0.0049 assertions/s.
1 runs, 1 assertions, 0 failures, 0 errors, 0 skips
ARCONN=sqlite3 bundle exec ruby -w -Itest  -n test_eager_loading_too_may_ids  142.57s user 60.83s system 98% cpu 3:27.08 total
```

After:

```
% ARCONN=sqlite3 bundle exec ruby -w -Itest test/cases/associations/eager_test.rb -n test_eager_loading_too_may_ids
Using sqlite3
Run options: -n test_eager_loading_too_may_ids --seed 16649

# Running:

.

Finished in 8.471032s, 0.1180 runs/s, 0.1180 assertions/s.
1 runs, 1 assertions, 0 failures, 0 errors, 0 skips
ARCONN=sqlite3 bundle exec ruby -w -Itest  -n test_eager_loading_too_may_ids  10.71s user 1.36s system 95% cpu 12.672 total
```
      0908184e
  57. 30 3月, 2019 1 次提交
  59. 27 3月, 2019 3 次提交
  61. 25 3月, 2019 1 次提交
  63. 23 3月, 2019 1 次提交
  65. 22 3月, 2019 1 次提交