- 02 2月, 2015 13 次提交
-
-
由 Andrew White 提交于
Cache `url_helpers`
-
由 eileencodes 提交于
`url_helpers` used to be memoized. This was lost in a refactoring and this PR adds it back. We noticed this while investigating why integration tests are slower than controller tests.
-
由 Aaron Patterson 提交于
-
由 Will Bryant 提交于
Fix Issue #15549, unbounded memory growth when saving records that have any after_create callbacks (or any associations, which makes after_create callbacks for you)
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
the transaction object shouldn't know so much about active record objects, so let's push the conditionals in to the instance.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Abdelkader Boudih 提交于
Add note about has_one :through and :dependent
-
由 Matthew Draper 提交于
Update queue_classic gem to use latest
-
由 Aaron Patterson 提交于
Pre-discard flash messages
-
由 Andrew White 提交于
Show proper traces on Windows for the error pages
-
由 Aaron Patterson 提交于
* master: Move required error message and changelog to Active Record Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846 Use Module#include instead of send :include, since now is a public method [ci skip]
✂ warning from controller renderer test Conflicts: activerecord/CHANGELOG.md
-
- 01 2月, 2015 23 次提交
-
-
由 palkan 提交于
-
由 Carlos Antonio da Silva 提交于
The new association error belongs to Active Record, not Active Model. See #18700 for reference.
-
由 Yves Senn 提交于
✂ warning from controller renderer test -
由 Genadi Samokovarov 提交于
This is an issue brought up by @daniel-rikowski in rails/web-console#91. Citing his PR proposal here: > Prior to this, backtrace lines were simply split by a single colon. > > Unfortunately that is also the drive letter delimiter in Windows paths > which resulted in a lot of empty source fragments of "C:0". ("C" from > the drive letter and 0 from "/path/to/rails/file.rb:16".to_i) > > Now the trace line is split by the first colon followed by some digits, > which works for both Windows and Unix path styles. Now, the PR was sent against web-console, because of the templates copy issue we used to had. Instead of bothering the contributor to reopen the issue against upstream Rails itself, I will make sure he gets the credit by putting his name in [rails-contributors/hard_coded_authors.rb][]. [rails-contributors/hard_coded_authors.rb]: (https://github.com/fxn/rails-contributors/blob/master/app/models/names_manager/hard_coded_authors.rb).
-
由 Sean Griffin 提交于
Use public Module#include, in favor of https://bugs.ruby-lang.org/issues/8846
-
由 Mingdong Luo 提交于
Fix n+1 query problem when eager loading nil associations (fixes #18312)
-
由 Sean Griffin 提交于
Use Module#include instead of send :include, since Module#include is a public method [ci skip]
-
由 Mingdong Luo 提交于
Conflicts: activerecord/CHANGELOG.md
-
-
由 Sean Griffin 提交于
It's finally finished!!!!!!! The reason the Attributes API was kept private in 4.2 was due to some publicly visible implementation details. It was previously implemented by overloading `columns` and `columns_hash`, to make them return column objects which were modified with the attribute information. This meant that those methods LIED! We didn't change the database schema. We changed the attribute information on the class. That is wrong! It should be the other way around, where schema loading just calls the attributes API for you. And now it does! Yes, this means that there is nothing that happens in automatic schema loading that you couldn't manually do yourself. (There's still some funky cases where we hit the connection adapter that I need to handle, before we can turn off automatic schema detection entirely.) There were a few weird test failures caused by this that had to be fixed. The main source came from the fact that the attribute methods are now defined in terms of `attribute_names`, which has a clause like `return [] unless table_exists?`. I don't *think* this is an issue, since the only place this caused failures were in a fake adapter which didn't override `table_exists?`. Additionally, there were a few cases where tests were failing because a migration was run, but the model was not reloaded. I'm not sure why these started failing from this change, I might need to clear an additional cache in `reload_schema_from_cache`. Again, since this is not normal usage, and it's expected that `reset_column_information` will be called after the table is modified, I don't think it's a problem. Still, test failures that were unrelated to the change are worrying, and I need to dig into them further. Finally, I spent a lot of time debugging issues with the mutex used in `define_attribute_methods`. I think we can just remove that method entirely, and define the attribute methods *manually* in the call to `define_attribute`, which would simplify the code *tremendously*. Ok. now to make this damn thing public, and work on moving it up to Active Model.
-
由 Aaron Patterson 提交于
changed deleted_tables list to set
-
由 Hyonjee Joo 提交于
-
由 Aaron Patterson 提交于
Fix STI for fixtures from multi-files
-
由 Yuki Nishijima 提交于
rails/actionpack/test/controller/renderer_test.rb:89: warning: possible reference to past scope - defaults
-
由 Sean Griffin 提交于
This method doesn't need to be lazy, as it is never called from reads. The only time it is called are in write cases, where we're about to loop through the results of it, and build the attribute objects anyway. So we don't gain anything by dodging the instantiation here. This is the only method that coupled `AttributeSet` to `LazyAttributeHash`, so removing it puts us back in a place where we can use a normal hash instead.
-
由 Aaron Patterson 提交于
Provide a better error message on :required association
-
由 Alex Grover 提交于
Remove '<3.0.0' requirement for queue_classic gem. This fixes the issue that the gem was attempting to parse the queue name as a URI, causing all of the tests to fail.
-
由 Robin Dupret 提交于
Add Single Table Inheritance to guides [ci skip]
-
由 Andrey Nering 提交于
-
由 Robin Dupret 提交于
Improving 'Customizing Form Builder' section with example [ci skip]
-
由 Arthur Nogueira Neves 提交于
Fixed test for deprecation warning in actionview for kwargs
-
由 Vipul A M 提交于
Fixed test for deprecation warning in actionview, renaming from https://github.com/rails/rails/commit/baf14ae513337cb185acf865e93dfc48f3aabf6a
-
- 31 1月, 2015 4 次提交
-
-
由 Andrew White 提交于
Fix a typo in deprecation warning. #process takes method instead of http_method.
-
由 Xavier Noria 提交于
This means we know generation works with this version, it does not mean it does not work with the last releases (should be tested).
-
由 Juanito Fatas 提交于
-
由 Abdelkader Boudih 提交于
[ci skip] Document format parameter of process method in AC test_case.
-