- 03 9月, 2016 2 次提交
-
-
由 Guillermo Iguaran 提交于
add Active Job bug report templates to guide [ci skip]
-
由 yuuji.yaginuma 提交于
Follow up to #26362
-
- 02 9月, 2016 12 次提交
-
-
由 Kasper Timm Hansen 提交于
fix class name typo in bug report templates for Active Job
-
由 Vipul A M 提交于
Improve Getting Started [ci skip]
-
由 Shia 提交于
-
由 yuuji.yaginuma 提交于
-
由 Guillermo Iguaran 提交于
Added bug report templates for Active Job
-
由 Prathamesh Sonpatki 提交于
-
由 प्रथमेश Sonpatki 提交于
Grammar fix
-
由 Waitaya Krongapiradee 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
- 01 9月, 2016 18 次提交
-
-
由 Andrew White 提交于
As demonstrated in #25880 the to_time method converts the utc time instance to a local time instance which is an expensive operation. Since to_datetime involves similar expensive operations we should also cache it to speed up comparison with lots of values.
-
由 Vipul A M 提交于
fix document for radio_button [ci skip]
-
由 shingo-nakanishi 提交于
add `# Let's say that @user.receive_newsletter returns "no":` for `def radio_button(object_name, method, tag_value, options = {})`. fix `# Let's say that @user.category returns "no":` to `# Let's say that @user.receive_newsletter returns "no":`
-
由 Sean Griffin 提交于
remove warning from `video_tag`
-
由 yuuji.yaginuma 提交于
This removes the following warning. ``` actionview/lib/action_view/helpers/asset_tag_helper.rb:291: warning: shadowing outer local variable - options ```
-
由 Matthew Draper 提交于
Follow up of #25602
-
由 Vipul A M 提交于
-
由 Vipul A M 提交于
Since keys are truncated, ruby 2.4 doesn't accept keys greater than their lenghts. keys of same value but different lenght and greater than key size of cipher, produce the same results as reproduced at https://gist.github.com/rhenium/b81355fe816dcfae459cc5eadfc4f6f9 Since our default cipher is 'aes-256-cbc', key length for which is 32 bytes, limit the length of key being passed to Encryptor to 32 bytes. This continues to support backwards compat with any existing signed data, already encrupted and signed with 32+ byte keys. Also fixes the passing of this value in multiple tests.
-
由 Jon Moss 提交于
Update Jason Zimdars twitter
-
由 Kasper Timm Hansen 提交于
I consider the missing deprecation warning a bug fix from the point of view of the 5.0.x series and forward.
-
由 Kasper Timm Hansen 提交于
Makes it clearer why we're doing this Add a comment to elaborate on what the undef means and move it closer to the deprecations so it's less likely for whoever pulls the deprecations that it should go too.
-
由 Kasper Timm Hansen 提交于
Do not allow to_param on AC::Parameters
-
由 Devinsuit 提交于
-
由 Sean Griffin 提交于
The fact that this only includes column names is an oversight.
-
由 Sean Griffin 提交于
There are some minor changes to the point type as I had forgotten that this will affect the behavior of `t.point` in migrations and the schema dumper so we need to handle those as well. I'll say this again so I can convince myself to come up with a better structure... TYPES SHOULD NOT CARE ABOUT SCHEMA DUMPING AND WE NEED TO BETTER SEPARATE THESE.
-
由 Sean Griffin 提交于
use `message` that specified in argument to error message
-
由 Sean Griffin 提交于
This reverts commit 3a1f6fe7. This commit takes the code in a direction that I am looking to avoid. The predicate builder should be purely concerned with AST construction as it matters to methods like `where`. Things like case sensitivity should continue to be handled elsewhere.
-
由 Sean Griffin 提交于
I still think that this is something that should be handled in the pg gem, but it's not going to end up happening there so we'll do it here instead. Once we bump to pg 0.19 we can pass the encoding to the `encode` method instead. This issue occurs because C has no concept of encoding (or strings, really). The bytes that we pass here when sending the value to the database will always be interpreted as whatever encoding the connection is currently configured to use. That means that roundtripping to the database will lose no information However, after assigning we round trip through our type system without hitting the database. The only way that we can do the "correct" thin here would be to actually give a reference to the connection to the array type and have it check the current value of the connection's encoding -- which I'm strongly opposed to. We could also pass in the encoding when it's constructed, but since that can change independently of the type I'm not a huge fan of that either. This feels like a reasonable middle ground, where if we have an array of strings we simply use the encoding of the string we're given. Fixes #26326.
-
- 31 8月, 2016 8 次提交
-
-
由 Sean Griffin 提交于
This was almost every case where we are overriding `respond_to?` in a way that mirrors a parallel implementation of `method_missing`. There is one remaining case in Active Model that should probably do the same thing, but had a sufficiently strange implementation that I want to investigate it separately. Fixes #26333.
-
由 Richard Schneeman 提交于
Make public asset use explicit
-
由 Kir Shatrov 提交于
-
由 Sean Griffin 提交于
Use splat `options` hash for `has_and_belongs_to_many`
-
由 Sean Griffin 提交于
Add `Type.default_value` and use it everywhere for internal
-
由 Sean Griffin 提交于
If a parent association was accessed in an `after_find` or `after_initialize` callback, it would always end up loading the association, and then immediately overwriting the association we just loaded. If this occurred in a way that the parent's `current_scope` was set to eager load the child, this would result in an infinite loop and eventually overflow the stack. For records that are created with `.new`, we have a mechanism to perform an action before the callbacks are run. I've introduced the same code path for records created with `instantiate`, and updated all code which sets inverse instances on newly loaded associations to use this block instead. Fixes #26320.
-
由 Guillermo Iguaran 提交于
Refactor remove duplication.
-
由 Santosh Wadghule 提交于
-