1. 27 11月, 2017 2 次提交
    • R
      Add new error class `QueryCanceled` which will be raised when canceling... · 0e2cd3d7
      Ryuta Kamizono 提交于
      Add new error class `QueryCanceled` which will be raised when canceling statement due to user request (#31235)
      
      This changes `StatementTimeout` to `QueryCanceled` for PostgreSQL.
      
      In MySQL, errno 1317 (`ER_QUERY_INTERRUPTED`) is only used when the
      query is manually cancelled.
      
      But in PostgreSQL, `QUERY_CANCELED` error code (57014) which is used
      `StatementTimeout` is also used when the both case. And, we can not tell
      which reason happened.
      
      So I decided to introduce new error class `QueryCanceled` closer to the
      error code name.
      0e2cd3d7
    • R
      Rename `TransactionTimeout` to more descriptive `LockWaitTimeout` (#31223) · ad0630f0
      Ryuta Kamizono 提交于
      Since #31129, new error class `StatementTimeout` has been added.
      `TransactionTimeout` is caused by the timeout shorter than
      `StatementTimeout`, but its name is too generic. I think that it should
      be a name that understands the difference with `StatementTimeout`.
      ad0630f0
  2. 26 11月, 2017 3 次提交
  3. 22 11月, 2017 1 次提交
    • Y
      No difference between JRuby and CRuby at test_read_attributes_before_type_cast_on_a_boolean · 2cc5cced
      Yasuo Honda 提交于
      https://github.com/jruby/activerecord-jdbc-adapter ActiveRecord JDBC Adapter is actively developed
      and it supports Rails 5.1 now. This pull request addresses one of the failure when running
      ActiveRecord unit tests with ActiveRecord JDBC Adapter.
      
      As of right now, ActiveRecord JDBC Adapter supports Rails 5.1, not master branch
      then this test only can run on `5-1-stable` branch. But I have opened this pull request to `master` branch
      since this type cast should be going to work in the future versions of ActiveRecord JDBC Adapter .
      
      ```ruby
      $ ARCONN=jdbcmysql bin/test test/cases/attribute_methods_test.rb:203
      Using jdbcmysql
      Run options: --seed 8874
      
      F
      
      Finished in 0.709120s, 1.4102 runs/s, 1.4102 assertions/s.
      
        1) Failure:
      AttributeMethodsTest#test_read_attributes_before_type_cast_on_a_boolean [/home/yahonda/git/rails/activerecord/test/cases/attribute_methods_test.rb:203]:
      Expected: "0"
        Actual: 0
      
      1 runs, 1 assertions, 1 failures, 0 errors, 0 skips
      $
      ```
      2cc5cced
  4. 18 11月, 2017 1 次提交
    • M
      Improve AR connection fork safety · f32cff55
      Matthew Draper 提交于
      Use whatever adapter-provided means we have available to ensure forked
      children don't send quit/shutdown/goodbye messages to the server on
      connections that belonged to their parent.
      f32cff55
  5. 16 11月, 2017 1 次提交
    • Y
      Allow test_ignored_columns_not_included_in_SELECT column names case · ef0a3d0d
      Yasuo Honda 提交于
      insensitive
      
      i.e. Oracle database identifier is UPPERCASE unlike other databases.
      
      ```ruby
      (byebug) query = Developer.all.to_sql
      "SELECT \"DEVELOPERS\".\"ID\", \"DEVELOPERS\".\"NAME\", \"DEVELOPERS\".\"SALARY\", \"DEVELOPERS\".\"FIRM_ID\", \"DEVELOPERS\".\"MENTOR_ID\", \"DEVELOPERS\".\"CREATED_AT\", \"DEVELOPERS\".\"UPDATED_AT\", \"DEVELOPERS\".\"CREATED_ON\", \"DEVELOPERS\".\"UPDATED_ON\" FROM \"DEVELOPERS\""
      ```
      ef0a3d0d
  6. 15 11月, 2017 2 次提交
    • R
      Fix CI failure due to invalid `up_only` for MySQL · 6a34ef52
      Ryuta Kamizono 提交于
      `oldie = 'true'` to `tinyint(1)` column is invalid value for MySQL:
      
      ```
      Mysql2::Error: Incorrect integer value: 'true' for column 'oldie' at row 1: update horses set oldie = 'true'
      ```
      6a34ef52
    • R
      Add a #populate method to migrations (#31082) · df82237a
      Rich 提交于
      * Add a #populate method to migrations
      
      * Address rubocop issues
      
      * Rename to #up_only and use #execute in the examples intead of the model
      
      * Update CHANGELOG
      
      [Rich Daley & Rafael Mendonça França]
      df82237a
  7. 14 11月, 2017 4 次提交
    • S
      Properly cast input in `update_all` · 68fe6b08
      Sean Griffin 提交于
      The documentation claims that given values go through "normal AR type
      casting and serialization", which to me implies
      `serialize(cast(value))`, not just serialization. The docs were changed
      to use this wording in #22492. The tests I cited in that PR (which is
      the same test modified in this commit), is worded in a way that implies
      it should be using `cast` as well.
      
      It's possible that I originally meant "normal type casting" to imply
      just the call to `serialize`, but given that `update_all(archived:
      params['archived'])` seems to be pretty common, I'm inclined to make
      this change as long as no tests are broken from it.
      68fe6b08
    • G
      f8627dfe
    • J
      54e10185
    • J
      Do not use `Arel.star` when `ignored_columns` · 6acde957
      Jon Moss 提交于
      If there are any ignored columns, we will now list out all columns we
      want to be returned from the database.
      
      Includes a regression test.
      6acde957
  8. 13 11月, 2017 1 次提交
  9. 11 11月, 2017 3 次提交
  10. 10 11月, 2017 3 次提交
  11. 09 11月, 2017 17 次提交
  12. 07 11月, 2017 1 次提交
  13. 06 11月, 2017 1 次提交