- 06 7月, 2015 5 次提交
-
-
由 Kasper Timm Hansen 提交于
ActionMailer::MessageDelivery respects current I18n.locale
-
由 Matthew Draper 提交于
Fix the random caching test failure. (Take two)
-
由 Johannes Opper 提交于
When #deliver_now is called all translations within the generated email will be looked up for the current I18n locale. I18n.locale = ‘de’ mail.deliver_now # Generates german email, correct In #enqueue_delivery the locale was not considered and the resulting job uses the default locale. I18n.locale = ‘de’ mail.deliver_later # Generate english email, incorrect In order to achieve a consistent behaviour the current locale is now always passed to `ActionMailer::DeliveryJob`.
-
由 Eileen M. Uchitelle 提交于
Display a more human readable list of reserved names
-
由 eileencodes 提交于
This change decouples `cookie_jar` allocation from the request object. We need this for moving controller tests to integration tests so we can access the `cookie_jar` object separately.
-
- 05 7月, 2015 6 次提交
-
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
Improve error message when serializing unsaved records for jobs, Fixes #19861
-
由 Kasper Timm Hansen 提交于
-
由 Robin Dupret 提交于
remove reference to `country_options_for_select` and `country_select` from guide [ci skip]
-
由 yuuji.yaginuma 提交于
these methods were removed in 2d27b82d
-
由 Vijay Dev 提交于
Create Adding images in Action Mailer Views on guides
-
- 03 7月, 2015 7 次提交
-
-
由 Kasper Timm Hansen 提交于
[skip ci] #distinct instead of #uniq
-
由 Mauro George 提交于
[ci skip]
-
由 Jon Atack 提交于
as #uniq will be removed from Rails 5.0 as per the Active Support exception raised: ActiveSupport::DeprecationException: DEPRECATION WARNING: uniq is deprecated and will be removed from Rails 5.0 (use distinct instead).
-
由 Rafael Mendonça França 提交于
changes names in guides to better reflect diversity
-
由 Thomas Osborn 提交于
-
由 eileencodes 提交于
Not much of a thought leader if I can't spell it correctly
😉 -
由 eileencodes 提交于
After 908cfef6 was introduced fixtures that did not set an enum would return nil instead of the default enum value. The fixtures should assume the default if a different enum is not defined. The change checks first if the enum is defined in the fixture before setting it based on the fixture.
-
- 02 7月, 2015 3 次提交
-
-
由 Xavier Noria 提交于
[ci skip] Don't use TrueClass, FalseClass in docs
-
由 claudiob 提交于
This sort of documentation style comes from 2009, probably due to the merging of merb (see https://github.com/rails/rails/commit/38b608ecab2441cd0c4e75bc08bdf57fcf85dd71#diff-017d9bc9b1d2bdae199b938d72c15488R120). Rails follows Ruby's convention to define which values are "truthy" or "falsey", so there is no need to specify that the returned value must strictly be a TrueClass or FalseClass. /cc @fxn
-
由 Robin Dupret 提交于
[ci skip] Improve the url_for documentation
-
- 01 7月, 2015 6 次提交
-
-
由 Roque Pinel 提交于
Clarify the `url_for` usage in mailers. Re-add the documentation about `url_for` and Route's path parameters, first introduced by 5c4f1859. This was reported on #15097 and until it is decided to deprecate it or not, I believe the documentation should exist.
-
由 Robin Dupret 提交于
Interpolating an array inside a String will call #inspect on it. Let's call #join to display a more human-readable error message.
-
由 Robin Dupret 提交于
Only one constraint option can be used at a time (except for the minimum and maximum ones that can eventually be combined). However, other options can be used with them (e.g. the validation failure message). So let's make the distinction between these two different options categories. [Yves Senn, Matthew Draper & Robin Dupret]
-
由 Kasper Timm Hansen 提交于
Avoid crashing when minitest-rails is loaded.
-
由 Victor Costan 提交于
The improvments to the test runner's integration with minitest in commit b6fc8e25 add methods to the Minitest module that refer to the Rails module. Unfortunately, when the minitest-rails gem is loaded, the reference is incorrectly resolved to the Minitest::Rails module.
-
由 Sean Griffin 提交于
The changes introduced to through associations in c80487eb were quite interesting. Changing `relation.merge!(scope)` to `relation = relation.merge(scope)` should in theory never cause any changes in behavior. The subtle breakage led to a surprising conclusion. The old code wasn't doing anything! Since `merge!` calls `instance_exec` when given a proc, and most scopes will look something like `has_many :foos, -> { where(foo: :bar) }`, if we're not capturing the return value, it's a no-op. However, removing the `merge` causes `unscope` to break. While we're merging in the rest of the chain elsewhere, we were never merging in `unscope` values, causing a breakage on associations where a default scope was being unscoped in an association scope (yuk!). This is subtly related to #20722, since it appears we were previously relying on this mutability. Fixes #20721. Fixes #20727.
-
- 30 6月, 2015 11 次提交
-
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
Closes #20743. The task `db:_dump` now only dumps the schema if `ActiveRecord::Base.dump_schema_after_migration` is true. This has effects: - `db:migrate:up` - `db:migrate:down` - `db:forward` - `db:rollback`
-
由 Yves Senn 提交于
We recommend using the `bin/` executables in our docs and guides. Let's make sure that our tests execute the same code path.
-
由 Rafael Mendonça França 提交于
Improve integration_tool documentation
-
由 Ryan Bigg 提交于
As per railties/lib/rails/test_unit/railtie.rb, where it sets it explicitly. This can be confirmed by starting a new Rails console session in a new app and running this code: Rails.application.config.app_generators.rails[:integration_tool] I also beefed up the documentation slightly to be more explicit about what this configuration setting does.
-
由 Rafael Mendonça França 提交于
To fix #20644
-
由 Rafael Mendonça França 提交于
fix pluralization in doc [ci skip]
-
由 Jordon Dornbos 提交于
-
由 Sean Griffin 提交于
Minor addition to getting started guide for foreign_key description
-
由 Mehmet Emin İNAÇ 提交于
Minor addition to getting started guide for foreign_key description of references migration [ci skip]
-
由 Srikanth Shreenivas 提交于
Added a note on development kit for Windows Users. This is required as Windows users can get frustrated when their first rails project creation would fail as some native gem won't get built.
-
- 29 6月, 2015 2 次提交