- 08 8月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
Since Rails 4.0, `config.ru` generated by default uses instances of `Rails.application`. Therefore, I think that it is good to deprecate the old behavior. Related: #9669
-
- 07 8月, 2017 4 次提交
-
-
由 David Heinemeier Hansson 提交于
Fix wrong service name in the storage.yml
-
由 David Heinemeier Hansson 提交于
Merge pull request #30099 from bogdanvlviv/set_version_of_active_storage_to_5_2_0_alpha_inside_package_json Active Storage to 5.2.0.alpha inside `activestorage/package.json`
-
由 bogdanvlviv 提交于
Follow #30083
-
由 Ryuta Kamizono 提交于
Replaces the 17 for the actual call to params[:id] that would make th…
-
- 06 8月, 2017 5 次提交
-
-
由 Mariano Giagante 提交于
Replaces the 17 for the actual call to params[:id] that would make the code work as intended. [ci skip]
-
由 dixpac 提交于
-
由 Vipul A M 提交于
-
由 Ryuta Kamizono 提交于
Remove outdated comment [ci skip]
-
由 Youssef Boulkaid 提交于
The comment was describing a previous version of the method with a different signature. This is outdated since e76c38ef
-
- 05 8月, 2017 27 次提交
-
-
由 David Heinemeier Hansson 提交于
`module ActiveStorage`, not `ActiveStorage::Class`
-
由 David Heinemeier Hansson 提交于
-
由 David Heinemeier Hansson 提交于
Use `content_type.start_with?("...")` than `content_type =~ /^.../`
-
由 David Heinemeier Hansson 提交于
Fix ruby warnings
-
由 David Heinemeier Hansson 提交于
Active Storage: check for `app.secrets.secret_key_base`, not `app.config.secret_key_base`
-
由 David Heinemeier Hansson 提交于
Add missing blank line between `config.active_storage` and `config.action_cable`
-
由 David Heinemeier Hansson 提交于
Change gem version of Active Storage to 5.2.0.alpha
-
由 George Claghorn 提交于
By default, apps only have the former set.
-
由 David Heinemeier Hansson 提交于
Remove unnecessary variable
-
由 dixpac 提交于
-
由 Matthew Draper 提交于
It was right as originally written in #15440.
-
由 Koichi ITO 提交于
-
由 Ryuta Kamizono 提交于
-
由 yuuji.yaginuma 提交于
This fixes following warnings: ``` test/models/variant_test.rb:11: warning: ambiguous first argument; put parentheses or a space even after `/' operator lib/active_storage/attached/macros.rb:63: warning: instance variable @active_storage_attached_highlights not initialized lib/active_storage/attached/macros.rb:25: warning: instance variable @active_storage_attached_avatar not initialized ```
-
由 claudiob 提交于
The reasons for this commit are: - uniformity with the other Rails libraries - (possibly) behave better with respect to autoloading - fix the index in the generated documentation Before this commit, run `rake rdoc` generates this left sidebar (ActiveStorage entries are indexed twice, both inside and outside the module): <img width="308" alt="before" src="https://user-images.githubusercontent.com/10076/28939523-7c087dec-7846-11e7-9289-38ed4a2930cd.png"> After this commit, run `rake rdoc` generates this left sidebar: (ActiveStorage entries are only indexed inside the module): <img width="303" alt="after" src="https://user-images.githubusercontent.com/10076/28939524-7c090be0-7846-11e7-8ee5-29dfecae548e.png">
-
由 Ryuta Kamizono 提交于
Fix repository URL [ci skip]
-
由 yuuji.yaginuma 提交于
changed `rails/activestorage` to `rails/rails`.
-
由 Ryuta Kamizono 提交于
`start_with?` is a little faster than regexp for prefix matching by a fixed string.
-
由 David Heinemeier Hansson 提交于
Add Active Storage to Rails
-
由 Dino Maric 提交于
-
由 Claudio B 提交于
If an AWS bucket name includes a `.` (e.g. `bucket.name`), then the canonical URL for an object will start with "https://s3.amazonaws.com/bucket.name/" and not with "https://bucket.name.s3.amazonaws.com/". The URL tests have now been separated into two separate asserts, to ensure that both the "s3.amazonaws.com" and the "bucket.name" components are included, but not specifically in that order.
-
由 Claudio B 提交于
Before we forget...
-
由 Sean Griffin 提交于
Do not let use `serialize` on native JSON/array column
-
由 Rafael Mendonça França 提交于
The test was passing before because it was not being testes correctly. Now we create a different engine that is loaded before the already exising and we make sure that the first call for isolate_namespace is what takes effect.
-
由 Rafael Mendonça França 提交于
What we want to test is that two different calls to isolate_namespace with the same module doesn't change the original railtie. We can do that defining two different railties. We can't call in the application because this method is not supposed to be called in an Application class.
-
由 Rafael França 提交于
Use `assert_nil` if `value` is nil in `assert_field_default_value`
-
由 David Heinemeier Hansson 提交于
And deal with a temporary test fix until we allow you to skip active storage.
-
- 04 8月, 2017 3 次提交
-
-
由 David Heinemeier Hansson 提交于
-
由 Sean Griffin 提交于
Use `Concurrent::Map` than `Mutex` and `Mutex_m` for statement caches
-
由 Kir Shatrov 提交于
-