- 08 4月, 2019 2 次提交
-
-
由 Ryuta Kamizono 提交于
The `table_name` was added at #23677 to detect whether serial column or not correctly. We can do that detection before initialize column object, it makes column object size smaller, and it probably helps column object de-duplication.
-
由 Ryuta Kamizono 提交于
Follow up of c9e4c848.
-
- 07 4月, 2019 1 次提交
-
-
由 Xavier Noria 提交于
-
- 06 4月, 2019 5 次提交
-
-
由 Ryuta Kamizono 提交于
This refactors `execute_grouped_calculation` and slightly changes generated GROUP BY queries, since I'd not prefer to repeat same expression in SELECT and GROUP BY clauses. Before: ``` SELECT COUNT(*) AS count_all, "topics"."author_name" AS topics_author_name, COALESCE(type, title) AS coalesce_type_title FROM "topics" GROUP BY "topics"."author_name", COALESCE(type, title) ``` After: ``` SELECT COUNT(*) AS count_all, "topics"."author_name" AS topics_author_name, COALESCE(type, title) AS coalesce_type_title FROM "topics" GROUP BY topics_author_name, coalesce_type_title ``` Although we generally don't guarantee to support Arel node constructed by user itself, this also fixes #24207.
-
由 Ryuta Kamizono 提交于
`values[:extending]` includes `NullRelation` if `null_relation?`.
-
由 Ryuta Kamizono 提交于
Follow up of #35868. Closes #19349.
-
由 Ryuta Kamizono 提交于
Association loading isn't to be affected by scoping consistently
-
由 प्रथमेश Sonpatki 提交于
See https://github.com/rails/rails/pull/35873#issuecomment-480333333 for reference [Prathamesh Sonpatki, bogdanvlviv]
-
- 05 4月, 2019 27 次提交
-
-
由 Eileen M. Uchitelle 提交于
Fix the deprecation warning about `config.active_job.return_false_on_aborted_enqueue`
-
由 Ryuta Kamizono 提交于
Fix typo for touch later test description. laster -> later
-
由 Abhay Nikam 提交于
-
由 प्रथमेश Sonpatki 提交于
-
由 Prathamesh Sonpatki 提交于
- It will return false in Rails 6.1 not 6.0. Also fixed the default value which is true for new applications.
-
由 Ryuta Kamizono 提交于
Add missing `touch_all` delegation to relation
-
由 Ryuta Kamizono 提交于
Follow up of #31513.
-
由 Ryuta Kamizono 提交于
[ci skip] Mark ActiveRecord::TouchLater as private doc
-
由 Abhay Nikam 提交于
-
由 Yuji Yaginuma 提交于
Do not exclude paths in the global level of Code Climate
-
由 Ryuta Kamizono 提交于
Follow-up of 5c71000d, #29834, and #30271. Currently, preloading and eager loading are not to be affected by scoping, with the exception of `unscoped`. But non eager loaded association access is still affected by scoping. Although this is a breaking change, the association loading will work consistently whether preloaded / eager loaded or not. Before: ```ruby Post.where("1=0").scoping do Comment.find(1).post # => nil Comment.preload(:post).find(1).post # => #<Post id: 1, ...> Comment.eager_load(:post).find(1).post # => #<Post id: 1, ...> end ``` After: ```ruby Post.where("1=0").scoping do Comment.find(1).post # => #<Post id: 1, ...> Comment.preload(:post).find(1).post # => #<Post id: 1, ...> Comment.eager_load(:post).find(1).post # => #<Post id: 1, ...> end ``` Fixes #34638. Fixes #35398.
-
由 yuuji.yaginuma 提交于
We use only RuboCop in Code Climate and exclude paths are specified in RuboCop's setting. The global level excludes paths should not be specified to match the behavior of local and CodeClimate.
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
This is completely same with `test_last`.
-
由 Ryuta Kamizono 提交于
Stash `left_joins` into `joins` to deduplicate redundant LEFT JOIN
-
由 Vipul A M 提交于
fix typo in the guides (use Rails instead of rails) [ci skip]
-
由 Edward Rudd 提交于
-
由 Ryuta Kamizono 提交于
Originally the `JoinDependency` has the deduplication for eager loading (LEFT JOIN). This re-uses that deduplication for `left_joins`. And also, This makes left join order into part of joins, i.e.: Before: ``` association joins -> stash joins (eager loading, etc) -> string joins -> left joins ``` After: ``` association joins -> stash joins (eager loading, left joins, etc) -> string joins ``` Now string joins are able to refer left joins. Fixes #34325. Fixes #34332. Fixes #34536.
-
由 Vipul A M 提交于
Add documentation for 'after_save_commit' [ci skip]
-
由 Sharang Dashputre 提交于
-
由 Rafael França 提交于
Adds 'detach_from' to 'ActiveSupport::Subscriber' to detach a subscriber from a namespace.
-
由 Rafael França 提交于
Fix arity warning for template handlers
-
由 localhostdotdev 提交于
Mainly to help with knowning which template is reponsible for the warning. handler.class # => Class handler.to_s # => Coffee::Rails::TemplateHandler Before: Change: >> Class#call(template) To: >> Class#call(template, source) After: Change: >> Coffee::Rails::TemplateHandler.call(template) To: >> Coffee::Rails::TemplateHandler.call(template, source)
-
由 Ryuta Kamizono 提交于
Follow up of #26764 and #35700. And add test case for #35700.
-
由 Ryuta Kamizono 提交于
Reintroduce support for overriding `has_secure_password` attributes
-
- 04 4月, 2019 5 次提交
-
-
由 Ryuta Kamizono 提交于
``` % be rubocop -a Inspecting 2777 files ..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................. Offenses: tools/test_common.rb:1:1: C: [Corrected] Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. if ENV["BUILDKITE"] ^ 2777 files inspected, 1 offense detected, 1 offense corrected ```
-
由 Kasper Timm Hansen 提交于
Fix deprecation warning about variants and formats
-
由 Prathamesh Sonpatki 提交于
- After https://github.com/rails/rails/pull/35408 and https://github.com/rails/rails/pull/35406, the `formats` and `variants` methods are deprecated in favor of `format` and `variant`.
-
由 Matthew Draper 提交于
Output junit format test report
-
由 Ryuta Kamizono 提交于
Fix `count(:all)` with eager loading and explicit select and order
-