- 24 8月, 2015 3 次提交
-
-
由 Aaron Patterson 提交于
try to remove dependencies on `@env` so we can have more flexible internals
-
由 Yves Senn 提交于
Remove test helper method to inside test method
-
由 Yves Senn 提交于
Another place to use a request object in NullSessionHash
-
- 23 8月, 2015 21 次提交
-
-
由 Arun Agrawal 提交于
Remove a link to the site that seems to be gone. [ci skip]
-
由 Eileen M. Uchitelle 提交于
Added docs for CollectionProxy#take
-
由 shunsukeaida 提交于
Followup to #20637.
-
由 yui-knk 提交于
Remove `MigrationTest#connection` and write `ActiveRecord::Base.connection` directly to test, because `MigrationTest#connection` is only used in `test_migration_instance_has_connection`.
-
由 Ronak Jangir 提交于
May be missed in 5fe14163 commit Also fixes the broken build
-
由 Abdelkader Boudih 提交于
fix syntax error in strip_links example [ci skip]
-
由 yuuji.yaginuma 提交于
can not use double quotes in double quoted string without escape
-
由 Yves Senn 提交于
Remove not used a block argument (`&block`)
-
由 yui-knk 提交于
-
由 Richard Schneeman 提交于
[ci skip] Add style guide about comma
-
由 Ronak Jangir 提交于
-
由 Aaron Patterson 提交于
This commit allows us to use one request object rather than allocating multiple request objects to deal with the session.
-
由 yui-knk 提交于
-
由 Aaron Patterson 提交于
We're going to implement storing env values differently in the future, so let's disconnect these methods from the instance variables
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
we're already doing this with a bunch of other header data.
-
由 Aaron Patterson 提交于
we have a method that knows how to get rack.input, so lets use that.
-
由 Aaron Patterson 提交于
We need to abstract the internals of the request object away from this instance variable so that the values for `@env` can be calculated in a different way.
-
由 Aaron Patterson 提交于
-
由 Santiago Pastorino 提交于
Rack changed their status codes to IETF RFC 7231
-
由 eileencodes 提交于
Since none of the action pack tests failed without this conditional it didn't seem necessary. This fixes the build because it correctly returns a 404 instead of a 500 for the asset routes test. Test that was failing was in the `assets_test.rb` file and was the test named `test_assets_routes_are_not_drawn_when_compilation_is_disabled`.
-
- 22 8月, 2015 16 次提交
-
-
由 eileencodes 提交于
This refactoring moves the controller class name that was on the route set to the request. The purpose of this refactoring is for changes we need to move controller tests to integration tests, mainly being able to access the controller on the request instead of having to go through the router. [Eileen M. Uchitelle & Aaron Patterson]
-
由 Kasper Timm Hansen 提交于
[skip ci] Debugging Rails Guide fixes
-
由 Jon Atack 提交于
- Fixes: "we want go deep" -> "we won't go deep" "to next next line" -> "to the next line" - Minor improvements in clarity and grammar. Cheers :)
-
由 Akira Matsuda 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
we want to go through methods to access `env` because in the future that ivar may not be available, or may be calculated lazily
-
由 Aaron Patterson 提交于
now the parameter filter doesn't need to know about the env hash in these two methds.
-
由 Aaron Patterson 提交于
Now the Headers internals don't depend on the env hash.
-
由 Aaron Patterson 提交于
This prevents external mutations from impacting the internals of the request or the Header object.
-
由 Aaron Patterson 提交于
this reduces the API footprint for the env hash so that we can be more flexible when changing API in the future
-
由 Aaron Patterson 提交于
This allows us to avoid calling `env_name` twice.
-
由 Aaron Patterson 提交于
duping the request will dup it's underlying env hash.
-
由 Sean Griffin 提交于
Several changes were made in #21110 which I am strongly opposed to. (this is what I get for going on vacation. :trollface:) No type should be introduced into the generic `ActiveRecord::Type` namespace, and *certainly* should not be registered into the registry unconstrained unless it is supported by *all* adapters (which basically means that it was specified in the ANSI SQL standard). I do not think `# :nodoc:` ing the type is sufficient, as it still makes the code of Rails itself very unclear as to what the role of that class is. While I would argue that this shouldn't even be a super class, and that MySql and PG's JSON types are only superficially duplicated (they might look the same but will change for different reasons in the future). However, I don't feel strongly enough about it as a point of contention (and the biggest cost of harming the blameability has already occured), so I simply moved the superclass into a namespace where its role is absolutely clear. After this change, `attribute :foo, :json` will once again work with MySQL and PG, but not with Sqlite3 or any third party adapters. Unresolved questions -------------------- The types that and adapter publishes (at least those are unique to that adapter, and not adding additional behavior like `MysqlString` should probably be part of the adapter's public API. Should we standardize the namespace for these, and document them?
-
由 Godfrey Chan 提交于
-
由 eileencodes 提交于
`ActiveSupport::Dependencies.constantize(const_name)` calls `Reference.new` which is defined as `ActiveSupport::Dependencies.constantize(const_name)` meaning this call is already cached and we're doing caching that isn't necessary.
-
由 Aaron Patterson 提交于
-