- 24 11月, 2018 7 次提交
-
-
由 Rafael França 提交于
Allow using queue prefix with a default queue name
-
由 Rafael França 提交于
Deliver parameterized mail with DeliveryJob
-
由 Rafael França 提交于
Add progressive JPG MIME-type to default variable content types
-
由 Rafael França 提交于
Redact SQL in errors
-
由 Alberto Almagro 提交于
* Keep executions for each specific declaration Fixes #34337 ActiveJob used the global executions counter to control the number of times a job should be retried. The problem with this approach was that in case a job raised different exceptions during its executions they weren't retried the number of times defined by their `attemps` number. **Example:** Having the following job: ```ruby class BuggyJob < ActiveJob::Base retry_on CustomException, attemps: 3 retry_on OtherException, attempts: 3 end ``` If the job raised `CustomException` in the first two executions and then it raised `OtherException`, the job wasn't retried anymore because the global executions counter was already indicating 3 attempts. With this patch each `retry_on` declaration has its specific counter so that the first two executions that raise `CustomException` don't affect the retries count that future exceptions may have. * Revert "clarifies documentation around the attempts arugment to retry_on" This reverts commit 86aa8f8c.
-
由 Gannon McGibbon 提交于
Use direction instead of rtl flag
-
由 Gannon McGibbon 提交于
Add ? for Whats Rails
-
- 23 11月, 2018 5 次提交
-
-
由 TomSpencerLondon 提交于
-
由 Gannon McGibbon 提交于
Deliver parameterized mail with `ActionMailer::DeliveryJob` and remove `ActionMailer::Parameterized::DeliveryJob`.
-
由 Alberto Almagro 提交于
Improve readability by using `direction` as CSS does. More info: https://developer.mozilla.org/en-US/docs/Web/CSS/direction Continues: #34486 [Alberto Almagro + Ufuk Kayserilioglu]
-
由 Rafael França 提交于
`atomic_write`: Ensure correct permission when `tmpdir` is the same as `dirname`.
-
由 Gannon McGibbon 提交于
Move `ActiveRecord::StatementInvalid` SQL to error property. Also add bindings as an error property.
-
- 22 11月, 2018 8 次提交
-
-
由 Ryuta Kamizono 提交于
Before: ``` LOG: execute <unnamed>: SELECT t.oid, t.typname FROM pg_type as t WHERE t.typname IN ('int2', 'int4', 'int8', 'oid', 'float4', 'float8', 'bool') LOG: execute <unnamed>: SELECT t.oid, t.typname, t.typelem, t.typdelim, t.typinput, r.rngsubtype, t.typtype, t.typbasetype FROM pg_type as t LEFT JOIN pg_range as r ON oid = rngtypid WHERE t.typname IN ('int2', 'int4', 'int8', 'oid', 'float4', 'float8', 'text', 'varchar', 'char', 'name', 'bpchar', 'bool', 'bit', 'varbit', 'timestamptz', 'date', 'money', 'bytea', 'point', 'hstore', 'json', 'jsonb', 'cidr', 'inet', 'uuid', 'xml', 'tsvector', 'macaddr', 'citext', 'ltree', 'interval', 'path', 'line', 'polygon', 'circle', 'lseg', 'box', 'time', 'timestamp', 'numeric') OR t.typtype IN ('r', 'e', 'd') OR t.typinput::varchar = 'array_in' OR t.typelem != 0 LOG: statement: SHOW TIME ZONE LOG: statement: SELECT 1 LOG: execute <unnamed>: SELECT COUNT(*) FROM pg_class c LEFT JOIN pg_namespace n ON n.oid = c.relnamespace WHERE c.relkind IN ('r','v','m') -- (r)elation/table, (v)iew, (m)aterialized view AND c.relname = 'accounts' AND n.nspname = ANY (current_schemas(false)) ``` After: ``` LOG: execute <unnamed>: SELECT t.oid, t.typname FROM pg_type as t WHERE t.typname IN ('int2', 'int4', 'int8', 'oid', 'float4', 'float8', 'bool') LOG: execute <unnamed>: SELECT t.oid, t.typname, t.typelem, t.typdelim, t.typinput, r.rngsubtype, t.typtype, t.typbasetype FROM pg_type as t LEFT JOIN pg_range as r ON oid = rngtypid WHERE t.typname IN ('int2', 'int4', 'int8', 'oid', 'float4', 'float8', 'text', 'varchar', 'char', 'name', 'bpchar', 'bool', 'bit', 'varbit', 'timestamptz', 'date', 'money', 'bytea', 'point', 'hstore', 'json', 'jsonb', 'cidr', 'inet', 'uuid', 'xml', 'tsvector', 'macaddr', 'citext', 'ltree', 'interval', 'path', 'line', 'polygon', 'circle', 'lseg', 'box', 'time', 'timestamp', 'numeric') OR t.typtype IN ('r', 'e', 'd') OR t.typinput::varchar = 'array_in' OR t.typelem != 0 LOG: statement: SHOW TIME ZONE LOG: statement: SELECT 1 LOG: execute <unnamed>: SELECT COUNT(*) FROM pg_class c LEFT JOIN pg_namespace n ON n.oid = c.relnamespace WHERE c.relkind IN ('r','v','m') -- (r)elation/table, (v)iew, (m)aterialized view AND c.relname = 'accounts' AND n.nspname = ANY (current_schemas(false)) ```
-
由 yuuji.yaginuma 提交于
Sometimes `test_scaffold_tests_pass_by_default` test fails in CI. https://travis-ci.org/rails/rails/jobs/457621750#L2095-L2120 It seems `manifest.json` was broken. `webpacker` will compile automatically if packs is not compiled. If parallel test is enabled, it seems that this compilation process is executed simultaneously in multiple processes, and it may become an inconsistent state. In order to avoid this, compile before running the test.
-
由 yuuji.yaginuma 提交于
This fixes following warnings: ``` test/dependencies_test.rb:287: warning: possibly useless use of :: in void context test/dependencies_test.rb:300: warning: possibly useless use of a constant in void context ```
-
由 Rafael França 提交于
Fix ActionMailer assertion not working for mail defining delivery_job:
-
由 Maurice Kühlborn 提交于
-
由 Edouard CHIN 提交于
- If a Mail defines a custom delivery_job, all ActionMailer assertion helper (assert_emails, assert_enqueued_emails ...) wouldn't work. ```ruby MyMailer < ApplicationMailer self.delivery_job = MyJob end # This assertion will fail assert_emails(1) do MyMailer.my_mail.deliver_later end This PR leverage the new ActiveJob feature that accepts Procs for the `only` keyword and check if the delivery job is one of ActionMailer registered ones.
-
由 Edouard CHIN 提交于
- That feature is useful to enqueue or assert that jobs got enqueued or performed based on dynamic conditions. We will be able to leverage that feature to fix all ActionMailer assertion helper issue when a Mailer define a custom delivery job (see next commit).
-
由 Ryuta Kamizono 提交于
Fixing an issue when parsing an opclass by allowing indexed column in indexdef to be wrapped up by double quotes
-
- 21 11月, 2018 13 次提交
-
-
由 Thomas Bianchini 提交于
in indexdef to be wrapped up by double quotes Fixes #34493. *Thomas Bianchini*
-
由 Eileen M. Uchitelle 提交于
Fix query cache for multiple connections
-
由 Ryuta Kamizono 提交于
-
由 Rafael França 提交于
Add slice! method to ActiveModel::Errors
-
由 Daniel Lopez Prat 提交于
-
由 Rafael França 提交于
Expand documentation for Hash#slice!
-
由 Daniel Lopez 👾 提交于
-
由 Eileen Uchitelle 提交于
Currently the query cache is only aware of one handler so once we added multiple databases switching on the handler we broke query cache for those reading connections. While #34054 is the proper fix, that fix is not straight forward and I want to make sure that the query cache isn't just broken for all other connections not in the main handler.
-
由 Eileen M. Uchitelle 提交于
Make connection handler per thread instead of per fiber
-
由 Eileen Uchitelle 提交于
The connection handler was using the RuntimeRegistry which kind of implies it's a per thread registry. But it's actually per fiber. If you have an application that uses fibers and you're using multiple databases, when you switch the connection handler to swap connections new fibers running on the same thread used to get a different connection id. This PR changes the code to actually use a thread so that we get the same connection. Fixes https://github.com/rails/rails/issues/30047 [Eileen M. Uchitelle, Aaron Patterson, & Arthur Neeves]
-
由 Rafael França 提交于
Stop using unnamed roots on conflict
-
由 Gannon McGibbon 提交于
Raises an ArgumentError when multiple root routes are defined in the same context instead of assigning nil names to subsequent roots.
-
由 Aaron Patterson 提交于
Fix handling of duplicates for `replace` on has_many-through
-
- 20 11月, 2018 7 次提交
-
-
由 Vipul A M 提交于
Fix typo in development_dependencies_install.md [ci skip]
-
由 Alfonso Jiménez 提交于
-
由 Ryuta Kamizono 提交于
Since #33449, `event.end = Time.now` is not used anymore and should use `event.finish!`. We can't use `deprecate :end=` in definition time in this module due to circular require in `active_support/deprecation/behaviors`.
-
由 Rafael Mendonça França 提交于
ActionMailer: support overriding template name in multipart
-
由 Rafael Mendonça França 提交于
:only and :except are now chained for routing resource(s)
-
由 Rafael França 提交于
Prevent TextHelper#word_wrap from stripping white space on the left side of long lines; Fixes #34487
-
由 Rafael França 提交于
Homogenize also rails help command output
-