1. 24 11月, 2018 7 次提交
  2. 23 11月, 2018 5 次提交
  3. 22 11月, 2018 8 次提交
    • R
      Use squiggly heredoc to strip odd indentation in the executed SQL · 1b68ead8
      Ryuta Kamizono 提交于
      Before:
      
      ```
      LOG:  execute <unnamed>:             SELECT t.oid, t.typname
                          FROM pg_type as t
                          WHERE t.typname IN ('int2', 'int4', 'int8', 'oid', 'float4', 'float8', 'bool')
      
      LOG:  execute <unnamed>:               SELECT t.oid, t.typname, t.typelem, t.typdelim, t.typinput, r.rngsubtype, t.typtype, t.typbasetype
                            FROM pg_type as t
                            LEFT JOIN pg_range as r ON oid = rngtypid
                            WHERE
                              t.typname IN ('int2', 'int4', 'int8', 'oid', 'float4', 'float8', 'text', 'varchar', 'char', 'name', 'bpchar', 'bool', 'bit', 'varbit', 'timestamptz', 'date', 'money', 'bytea', 'point', 'hstore', 'json', 'jsonb', 'cidr', 'inet', 'uuid', 'xml', 'tsvector', 'macaddr', 'citext', 'ltree', 'interval', 'path', 'line', 'polygon', 'circle', 'lseg', 'box', 'time', 'timestamp', 'numeric')
                              OR t.typtype IN ('r', 'e', 'd')
                              OR t.typinput::varchar = 'array_in'
                              OR t.typelem != 0
      
      LOG:  statement: SHOW TIME ZONE
      LOG:  statement: SELECT 1
      LOG:  execute <unnamed>:               SELECT COUNT(*)
                            FROM pg_class c
                            LEFT JOIN pg_namespace n ON n.oid = c.relnamespace
                            WHERE c.relkind IN ('r','v','m') -- (r)elation/table, (v)iew, (m)aterialized view
                            AND c.relname = 'accounts'
                            AND n.nspname = ANY (current_schemas(false))
      ```
      
      After:
      
      ```
      LOG:  execute <unnamed>: SELECT t.oid, t.typname
              FROM pg_type as t
              WHERE t.typname IN ('int2', 'int4', 'int8', 'oid', 'float4', 'float8', 'bool')
      
      LOG:  execute <unnamed>: SELECT t.oid, t.typname, t.typelem, t.typdelim, t.typinput, r.rngsubtype, t.typtype, t.typbasetype
              FROM pg_type as t
              LEFT JOIN pg_range as r ON oid = rngtypid
                            WHERE
                              t.typname IN ('int2', 'int4', 'int8', 'oid', 'float4', 'float8', 'text', 'varchar', 'char', 'name', 'bpchar', 'bool', 'bit', 'varbit', 'timestamptz', 'date', 'money', 'bytea', 'point', 'hstore', 'json', 'jsonb', 'cidr', 'inet', 'uuid', 'xml', 'tsvector', 'macaddr', 'citext', 'ltree', 'interval', 'path', 'line', 'polygon', 'circle', 'lseg', 'box', 'time', 'timestamp', 'numeric')
                              OR t.typtype IN ('r', 'e', 'd')
                              OR t.typinput::varchar = 'array_in'
                              OR t.typelem != 0
      
      LOG:  statement: SHOW TIME ZONE
      LOG:  statement: SELECT 1
      LOG:  execute <unnamed>: SELECT COUNT(*)
              FROM pg_class c
              LEFT JOIN pg_namespace n ON n.oid = c.relnamespace
              WHERE c.relkind IN ('r','v','m') -- (r)elation/table, (v)iew, (m)aterialized view
              AND c.relname = 'accounts'
              AND n.nspname = ANY (current_schemas(false))
      ```
      1b68ead8
    • Y
      Compile packs before run test · 6d854f9d
      yuuji.yaginuma 提交于
      Sometimes `test_scaffold_tests_pass_by_default` test fails in CI.
      https://travis-ci.org/rails/rails/jobs/457621750#L2095-L2120
      It seems `manifest.json` was broken.
      
      `webpacker` will compile automatically if packs is not compiled.
      If parallel test is enabled, it seems that this compilation process is
      executed simultaneously in multiple processes, and it may become an
      inconsistent state.
      In order to avoid this, compile before running the test.
      6d854f9d
    • Y
      Fix ruby warnings · f8bd01cd
      yuuji.yaginuma 提交于
      This fixes following warnings:
      
      ```
      test/dependencies_test.rb:287: warning: possibly useless use of :: in void context
      test/dependencies_test.rb:300: warning: possibly useless use of a constant in void context
      ```
      f8bd01cd
    • R
      Merge pull request #34339 from Edouard-chin/ec-mail-test-helper · 47ab6b36
      Rafael França 提交于
      Fix ActionMailer assertion not working for mail defining delivery_job:
      47ab6b36
    • M
      455a122e
    • E
      Fix ActionMailer assertion not working for mail defining delivery_job: · e139a3ce
      Edouard CHIN 提交于
      - If a Mail defines a custom delivery_job, all ActionMailer assertion
        helper (assert_emails, assert_enqueued_emails ...) wouldn't work.
      
        ```ruby
          MyMailer < ApplicationMailer
            self.delivery_job = MyJob
          end
      
          # This assertion will fail
          assert_emails(1) do
            MyMailer.my_mail.deliver_later
          end
      
        This PR leverage the new ActiveJob feature that accepts Procs for the
        `only` keyword and check if the delivery job is one of ActionMailer
         registered ones.
      e139a3ce
    • E
      Allow all ActiveJob assertion helper to accept Proc in their `only` kw: · cdb16ac5
      Edouard CHIN 提交于
      - That feature is useful to enqueue or assert that jobs got enqueued
        or performed based on dynamic conditions.
        We will be able to leverage that feature to fix all ActionMailer
        assertion helper issue when a Mailer define a custom delivery job
        (see next commit).
      cdb16ac5
    • R
      Merge pull request #34498 from ThomBian/thombian/fix-opclass-parsing · ca033921
      Ryuta Kamizono 提交于
      Fixing an issue when parsing an opclass by allowing indexed column in indexdef to be wrapped up by double quotes
      ca033921
  4. 21 11月, 2018 13 次提交
  5. 20 11月, 2018 7 次提交