- 18 5月, 2018 4 次提交
-
-
由 Rafael França 提交于
Generate ActiveStorage attachment getter and setter methods in mixin
-
由 Rafael Mendonça França 提交于
-
由 Josh Susser 提交于
Generated attachment getter and setter methods are created within the model's `GeneratedAssociationMethods` module to allow overriding and composition using `super`. Includes tests for new functionality. Co-authored-by: NJosh Susser <josh@hasmanythrough.com> Co-authored-by: NJamon Douglas <terrildouglas@gmail.com>
-
由 Rafael França 提交于
Fix user_input_in_time_zone to coerce non valid string into nil
-
- 17 5月, 2018 10 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Active storage: Image variant options not correct in docs [ci skip]
-
由 lucfranken 提交于
### Steps to reproduce Using Rails 5.2.0 When following this example: http://api.rubyonrails.org/classes/ActiveStorage/Variant.html `avatar.variant(resize: "100x100", monochrome: true, flip: "-90")` ### Expected behavior Image should be rendered as flipped. ### Actual behavior I get an error: > failed with error: gm mogrify: Unrecognized option (-90). ### Fix: According to: https://github.com/minimagick/minimagick the option should be called rotate: `avatar.variant(resize: "100x100", monochrome: true, rotate: "-90")` So **flip** changed to **rotate**. ### System configuration **Rails version**: 5.2.0 **Ruby version**: ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-darwin17]
-
由 Ryuta Kamizono 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
[David Robertson & George Claghorn]
-
由 Annie-Claude Côté 提交于
Before it was coercing an invalid string into "2000-01-01 00:00:00".
-
由 Annie-Claude Côté 提交于
Inside user_input_in_time_zone we call in_time_zone on the value and value can be a String.
-
- 16 5月, 2018 1 次提交
-
-
由 Ryuta Kamizono 提交于
Originally `SingularAssociation#replace` abstract method is private, and doesn't intend to be called directly.
-
- 15 5月, 2018 3 次提交
-
-
由 Ryuta Kamizono 提交于
Follow up of #19171 and #26825.
-
由 Ryuta Kamizono 提交于
Add math test
-
由 Nikolai B 提交于
After #449 was merged math can be done on these nodes, adding a test file to unit test all the math operators.
-
- 14 5月, 2018 1 次提交
-
-
由 Yuji Yaginuma 提交于
Don't generate `config/spring.rb` in `app:update` task when spring isn't loaded
-
- 13 5月, 2018 7 次提交
-
-
由 Tsukuru Tanimichi 提交于
-
由 George Claghorn 提交于
Add available transformations to docs
-
由 wata_mac 提交于
`foreign_key`, `json` and `virtual` are also available.
-
由 Ryuta Kamizono 提交于
Follow up of #32605.
-
由 Ryuta Kamizono 提交于
Remove ActiveRecord::Transactions#rollback_active_record_state!
-
由 Ryuta Kamizono 提交于
Don't clear transaction state after manual rollback
-
由 Eugene Kenny 提交于
`rollback_active_record_state!` was removed from `save!` but not `save` in da840d13. I believe that leaving it in `save` was a mistake, since that commit was intended to move the rollback logic from the `save`/`save!` call to the transaction stack. As of 67d8bb96 the record's original state is lazily restored the first time it's accessed after the transaction, instead of when a rollback occurs. This means that the call to `restore_transaction_record_state` here has no effect: the record's transaction level is incremented twice (in rollback_active_record_state! and `with_transaction_returning_status`), isn't decremented again until the the `ensure` block runs, and won't hit zero until the next time `sync_with_transaction_state` is called.
-
- 12 5月, 2018 4 次提交
-
-
由 yuuji.yaginuma 提交于
I'm not sure what originally wanted to pass to the argument. However, as long as see the document added along with the commit, it seems just to be mistaken that trying to pass the error instance. https://github.com/rails/rails/pull/30622/files#diff-59beb0189c8c6bc862edf7fdb84ff5a7R64 Fixes #32853
-
由 Yuji Yaginuma 提交于
Remove unused `remove_file` method
-
由 Eileen M. Uchitelle 提交于
Remove reference to old `:text` rendering option
-
由 Tyler Hunt 提交于
[ci skip]
-
- 11 5月, 2018 3 次提交
-
-
由 Ryuta Kamizono 提交于
`becomes` creates new object and copies attributes from the receiver. If new object has mutation tracker which is created in `after_initialize`, it should be cleared since it is for discarded attributes. But if the receiver doesn't have mutation tracker yet, it will not be cleared properly. It should be cleared regardless of whether the receiver has mutation tracker or not. Fixes #32867.
-
由 Matthew Draper 提交于
Added a lot of Oxford commas
-
由 Anthony Crumley 提交于
[ci skip] A regular expression was used to find a lot of missing Oxford commas and add them. The regular expression was as follows. ", ([a-zA-Z0-9.\`:'\"]+ ){1,6}(or|and) "
-
- 10 5月, 2018 3 次提交
-
-
由 George Claghorn 提交于
Fix Typo In ActiveSupport Instrumentation Guide
-
由 Eugene Kenny 提交于
If an `ActiveRecord::Rollback` error was raised by a persistence method (e.g. in an `after_save` callback), this logic would potentially discard the original state of the record from before the transaction, preventing it from being restored later when the transaction was rolled back.
-
由 Assain 提交于
-
- 09 5月, 2018 3 次提交
-
-
由 Claudio B 提交于
Fix ActiveRecord::AttributeMethods::Dirty documentation
-
由 George Claghorn 提交于
Add option to ActiveStorage::Blob to set extract_content_type_from_io
-
由 Ryan Davidson 提交于
This adds a boolean argument called identify to ActiveStorage::Blob methods #create_after_upload, #build_after_upload and #upload. It allows a user to bypass the automatic content_type inference from the io.
-
- 08 5月, 2018 1 次提交
-
-
由 Tsukuru Tanimichi 提交于
In #32780, We have supported the `--skip-sprockets` option in the `app:update` task. When `options[:api]` is truthy, `option[:skip_sprockets]` is also truthy. So we can remove this `remove_file` method. https://github.com/rails/rails/blob/42b9e7e50c084e119a679cf155b70b5efc4d36ff/railties/lib/rails/generators/rails/app/app_generator.rb#L281-L283
-