1. 03 7月, 2016 1 次提交
  2. 02 7月, 2016 34 次提交
  3. 01 7月, 2016 5 次提交
    • E
      Add regression test for foreign key schema dump caching · 0d8d64e9
      eileencodes 提交于
      If you had a foreign key set and then decided to add `on_delete:
      :cascade` later in another migration that migration would run but
      wouldn't refresh the schema dump.
      
      The reason for this was because `create_table_info` caches the statement
      and sets it to be the same as the original declaration for the foreign
      key (without the `on_delete: :cascade`.
      
      PR #25307 ended up fixing this bug because it removes the check for
      `create_table_info` and relies on reading from `information_schema`. The
      fix however was intended to patch another bug. The reason this fixes the
      issue is we're no longer parsing the regex from the cached
      `create_table_info`.
      
      This regression test is to ensure that the issue does not return if we
      for some reason go back to using `create_table_info` to set the foreign
      keys.
      0d8d64e9
    • E
      Merge pull request #25307 from kamipo/extract_foreign_key_action_from_information_schema · 4abd389e
      Eileen M. Uchitelle 提交于
      Extract foreign key action from `information_schema`
      4abd389e
    • E
      Fix release task now that NPM is part of the build · 297e2620
      eileencodes 提交于
      Note: this commit looks super weird becuase git. I'm moving the entire
      NPM section to the part where we actually push the gems/npm package for
      the reasons below. That's not how the git diff looks though.
      
      When we release Rails we run `rake prep_release` which calls
      `update_versions`. This was updating the NPM version as well. But when we
      would later run `rake install` to test the installed gem
      `update_versions` gets called again which causes the install to fail
      because NPM sees the version is the same as the last run and refuses to
      continue. If you forget to stash this will then cause the push to
      RubyGems to fail because `update_versions` is called again and then NPM
      will not continue because it thinks the version hasn't been changed even
      though it has.
      
      The correct solution would be to not update the NPM verion if it matches
      the version already in the file but after an hour I could not find a
      simple way to use NPM to read the current version. Honestly that's not
      the best way to do it either because say you forget to update something
      else and then the script thinks it's already been updated.
      
      With that in mind I think the best solution is to not update the NPM
      version until right before we are going to push to NPM because then that
      won't cause the push to RubyGems to fail.
      297e2620
    • V
    • R