- 23 4月, 2017 8 次提交
- 22 4月, 2017 4 次提交
-
-
由 Rafael França 提交于
Set to `form_with_generates_remote_forms` only when config is explicitly specified
-
由 yuuji.yaginuma 提交于
Without this check, even if config is not specified, `ActionView::Helpers::FormHelper.form_with_generates_remote_forms` always be set to nil and remote form not be generated. Follow up to 128b804c
-
由 Rafael Mendonça França 提交于
This is a small breaking change that we chose to make in 5.1 since the fix can be done with a search and replace tool.
-
由 Rafael Mendonça França 提交于
This configuration is not present in ActionView::Base so we can't let the action_view.set_configs initializer set it. Also add tests to make sure this config works. Fixes #28824
-
- 21 4月, 2017 14 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
Update 'Building Complex Forms' with `inverse_of`
-
由 Rafael França 提交于
Add missing require
-
由 Rafael Mendonça França 提交于
Fix #24032
-
由 Isaac Betesh 提交于
Fixes #24032
-
由 Rafael França 提交于
Prevent double firing the before save callback of new object when the parent association saved in the callback
-
由 yuuji.yaginuma 提交于
Without this, unit test fails. ``` bundle exec ruby -w -Ilib:lib:test test/cases/logging_test.rb Using inline Run options: --seed 41246 # Running: SE......S.... Finished in 0.052938s, 245.5696 runs/s, 831.1585 assertions/s. 1) Error: LoggingTest#test_job_error_logging: NameError: uninitialized constant LoggingTest::RescueJob test/cases/logging_test.rb:130:in `rescue in test_job_error_logging' test/cases/logging_test.rb:129:in `test_job_error_logging' 13 runs, 44 assertions, 0 failures, 1 errors, 2 skips You have skipped tests. Run with --verbose for details. ```
-
由 Jon Moss 提交于
[ci skip]
-
由 Ryuta Kamizono 提交于
Prevent double firing the before save callback of new object when the parent association saved in the callback Related #18155, #26661, 268a5bb0, #27434, #27442, and #28599. Originally #18155 was introduced for preventing double insertion caused by the after save callback. But it was caused the before save issue (#26661). 268a5bb0 fixed #26661, but it was caused the performance regression (#27434). #27442 added new record to `target` before calling callbacks for fixing #27434. But it was caused double firing before save callback (#28599). We cannot add new object to `target` before saving the object. This is improving #18155 to only track callbacks after `save`. Fixes #28599.
-
由 Rafael Mendonça França 提交于
Fix quoting in db:create grant all statement.
-
由 Rafael França 提交于
Add error logging to Active Job
-
由 Rafael França 提交于
Fixes Hash.from_xml with frozen strings for all engines
-
由 Josh Nussbaum 提交于
-
由 Rafael França 提交于
Namespace CSS selectors on error pages
-
- 20 4月, 2017 14 次提交
-
-
由 Jan Krutisch 提交于
The css selectors on the generated error pages are too broad (for example `text-align: center` on `body` and thus bleed out to the following pages (say, by pressing the back button) when using Turbolinks. This commit namespaces all the selectors.
-
由 Kasper Timm Hansen 提交于
Remove outdated comment
-
The database name used in the test would have actually shown this if it had tried to execute on a real Mysql instead of being stubbed out (dashes in database names needs quotes).
-
由 Marion Bouguet 提交于
Since 3aee9126, this class hasn't inherited from Array.
-
由 Rafael França 提交于
Don't fallback to utf8mb3 after MySQL 8.0.0
-
由 Rafael França 提交于
`cache_key` respects the limit in a relation even if a relation is not loaded
-
由 Rafael França 提交于
Don't generate system test files if `skip_system_test` option is specified
-
由 Rafael Mendonça França 提交于
Closes #28382 Closes #28651
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
Log any write errors originating from the socket
-
由 Rafael França 提交于
Fix migration tasks
-
由 Rafael França 提交于
Include gem name and deprecation horizon when calling the deprecation behaviors
-
由 Willem van Bergen 提交于
Send deprecation horizon and gem name as arguments to deprecation heavier handler, and make sure they are used for the ActiveSupport::Notifications message.
-
由 Rafael França 提交于
Improve the upgrade path of Strong Parameters
-